Skip to content

Conversation

andreaskienle
Copy link
Contributor

This PR fixes an issue with the managed resources when the server response contains an error and the items field ist not included.

(condition) => condition.type === 'Ready',
);
managedResources
?.filter((managedResource) => managedResource.items)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s just this

Copy link
Contributor

@enrico-kaack-comp enrico-kaack-comp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents crashing and therefore fix the bug but would silently ignore the error. So if a resource cant be queried because of e.g. rate limiting, the user would expect to see its resource and would be confused. I think we should indicate this somehow that we failed to query certain resources.

@andreaskienle
Copy link
Contributor Author

this prevents crashing and therefore fix the bug but would silently ignore the error. So if a resource cant be queried because of e.g. rate limiting, the user would expect to see its resource and would be confused. I think we should indicate this somehow that we failed to query certain resources.

True, we should keep this in mind when we move to the new backend.

@andreaskienle andreaskienle merged commit 09350c5 into main Mar 28, 2025
4 checks passed
@andreaskienle andreaskienle deleted the fix-managed-resources branch March 28, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants