Skip to content

Fix managed resources #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Fix managed resources #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions src/components/ControlPlane/ManagedResources.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,26 +83,28 @@ export function ManagedResources() {
];

const rows: ResourceRow[] =
managedResources?.flatMap((managedResource) =>
managedResource.items?.map((item) => {
const conditionSynced = item.status.conditions?.find(
(condition) => condition.type === 'Synced',
);
const conditionReady = item.status.conditions?.find(
(condition) => condition.type === 'Ready',
);
managedResources
?.filter((managedResource) => managedResource.items)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s just this

.flatMap((managedResource) =>
managedResource.items?.map((item) => {
const conditionSynced = item.status.conditions?.find(
(condition) => condition.type === 'Synced',
);
const conditionReady = item.status.conditions?.find(
(condition) => condition.type === 'Ready',
);

return {
kind: item.kind,
name: item.metadata.name,
created: timeAgo.format(new Date(item.metadata.creationTimestamp)),
synced: conditionSynced?.status === 'True',
syncedTransitionTime: conditionSynced?.lastTransitionTime ?? '',
ready: conditionReady?.status === 'True',
readyTransitionTime: conditionReady?.lastTransitionTime ?? '',
};
}),
) ?? [];
return {
kind: item.kind,
name: item.metadata.name,
created: timeAgo.format(new Date(item.metadata.creationTimestamp)),
synced: conditionSynced?.status === 'True',
syncedTransitionTime: conditionSynced?.lastTransitionTime ?? '',
ready: conditionReady?.status === 'True',
readyTransitionTime: conditionReady?.lastTransitionTime ?? '',
};
}),
) ?? [];

return (
<>
Expand Down Expand Up @@ -138,10 +140,7 @@ export function ManagedResources() {
);
}

function ResourceStatusCell({
value,
transitionTime,
}: StatusCellProps) {
function ResourceStatusCell({ value, transitionTime }: StatusCellProps) {
return (
<Icon
design={value ? 'Positive' : 'Negative'}
Expand Down