Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow datasets without qualities to be downloaded. #847

Merged
merged 4 commits into from
Oct 17, 2019

Conversation

PGijsbers
Copy link
Collaborator

Allow datasets without qualities to be downloaded (because of the use of the cache function, subsequent get_dataset calls will always check if qualities are now available on the server). I am not aware of any dataset which will have no qualities indefinitely, so I don't know how to add a unit test or if we should.

@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@35dd7d3). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #847   +/-   ##
==========================================
  Coverage           ?   88.44%           
==========================================
  Files              ?       37           
  Lines              ?     4277           
  Branches           ?        0           
==========================================
  Hits               ?     3783           
  Misses             ?      494           
  Partials           ?        0
Impacted Files Coverage Δ
openml/datasets/functions.py 94.06% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35dd7d3...4634a47. Read the comment docs.

@PGijsbers PGijsbers merged commit a5b35e6 into develop Oct 17, 2019
@PGijsbers PGijsbers deleted the AllowDatasetNoQuality branch October 17, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants