Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow datasets without qualities to be downloaded. #847

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Allow datasets without qualities to be downloaded. #847

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ada518
Allow datasets without qualities to be downloaded.
PGijsbers Oct 17, 2019
917ab9e
Remove future tense to bring comply with the character limit
PGijsbers Oct 17, 2019
1791aa2
move downloading qualities back into main try/except
PGijsbers Oct 17, 2019
4634a47
Write warning message to log if no qualities could be found when gett…
PGijsbers Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/20_basic/simple_suites_tutorial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
print(tasks)

####################################################################################################
# and iterated over for benchmarking. For speed reasons we'll only iterate over the first three tasks:
# and iterated over for benchmarking. For speed reasons we only iterate over the first three tasks:

for task_id in tasks[:3]:
task = openml.tasks.get_task(task_id)
Expand Down
9 changes: 7 additions & 2 deletions openml/datasets/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,10 +498,15 @@ def get_dataset(
remove_dataset_cache = True
description = _get_dataset_description(did_cache_dir, dataset_id)
features = _get_dataset_features(did_cache_dir, dataset_id)
qualities = _get_dataset_qualities(did_cache_dir, dataset_id)

arff_file = _get_dataset_arff(description) if download_data else None
try:
qualities = _get_dataset_qualities(did_cache_dir, dataset_id)
except OpenMLServerException as e:
if not (e.code == 362 and str(e) == 'No qualities found - None'):
raise
qualities = None

arff_file = _get_dataset_arff(description) if download_data else None
remove_dataset_cache = False
except OpenMLServerException as e:
# if there was an exception,
Expand Down