Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App Shell #13

Merged
merged 38 commits into from
Oct 2, 2020
Merged

New App Shell #13

merged 38 commits into from
Oct 2, 2020

Conversation

FlorianRappl
Copy link
Contributor

Brings the new app shell to live.

  • Allows local first development, right now uses a set of ESMs defined in the CDN as a placeholder
  • Comes with alias possibilities, currently aliasing @openmrs/esm-module-config to @openmrs/esm-config
  • Moved @openmrs/esm-api, @openmrs/esm-styleguide, @openmrs/esm-error-handling into the esm-core repository
  • Has a framework independent global state container (contained in esm-api), which allows store creation per esm (multiple if wanted), but already comes with a central one shared from the app
  • Builds on the central Lerna tooling
  • Has an HTML template that is flexible regarding where the OpenMRS API is and where the SPA is placed
  • Aligned / unified the dependencies and the way of consumption

There's more to it. I'll demo everything tomorrow.

@FlorianRappl FlorianRappl added the enhancement New feature or request label Oct 1, 2020
@brandones
Copy link
Collaborator

Starting into it. This might involve a tricky rebase, but do you think you could merge the other repos in in a way that preserves their histories, for example using lerna import?

@FlorianRappl
Copy link
Contributor Author

FlorianRappl commented Oct 1, 2020

Starting into it. This might involve a tricky rebase, but do you think you could merge the other repos in in a way that preserves their histories, for example using lerna import?

I'd love to avoid that. Its unnecessary work imho - if you want to do it then please go ahead. Otherwise, I'd just archive the other repos (if one really needs to know the past the old repos are still there).

(Through the squash merge we would lose the history anyway.)

.prettierignore Outdated Show resolved Hide resolved
@brandones
Copy link
Collaborator

Awesome work. Just requesting those four minor changes above.

@FlorianRappl
Copy link
Contributor Author

All done!

@jonathandick
Copy link
Member

Great work Florian!

@FlorianRappl FlorianRappl merged commit cbddc8a into master Oct 2, 2020
@FlorianRappl FlorianRappl deleted the feature/app-shell branch October 20, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants