MF-221 Migrate deprecated i18next-xhr-backend to i18next-http-bakend #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianRappl
reviewed
Oct 1, 2020
sure @FlorianRappl i think it will be easier that way |
FlorianRappl
added a commit
that referenced
this pull request
Oct 1, 2020
|
Brought it over to #13 - thanks @donaldkibet ! 🍻 |
FlorianRappl
added a commit
that referenced
this pull request
Oct 2, 2020
* Generate the HTML * Bringing elementary packages to the core * Prepared for exposing packages as shared deps * Realigned and improved * Use default import map and favicon * Bring api and error-handling to core * Enhanced FHIR * Incldued fihr typings * Renamed to config * Renamed module-config to config * Improved sync * Finished debugging * Enhanced local settings * Refinement * Alignment * Final alignment of basis * Merged with latest changes * Prettified * Prepare for openmrs run command * Changed version number * Reordered deps * Removed prepublishOnly script * Updated dep version * Rewired postcss * Improved webpack * Use submodule for running * Adjusted for deployment; only need to publish app shell * Added backend parameter * Updated with importmap flag * Changed to better i18n backend see #14 * Review comments * Review comments * Warn if importmap seems wrong * Prettified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate from deprecated 18next-xhr-backend to i18next-http-backend
Description of Task completed?
At the moment translation is loaded using ajax function of the i18next-xhr-backend to the new i18next-http-backend request function.
The old i18next-xhr-back is deprecated for reasons explained here
Screenshots