24 enh test and push docker container for petdeface to dockerhub #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated petutils and requirements to use new version - added option local version of freesurfer for docker build, no speedup - updating make file to build images
pwighton
reviewed
Dec 4, 2023
|
@mnoergaard take a look at this, I think it's ready to close out today (or tomorrow even). I'm attempting to minify the image with neurodocker, but that's still running at this point and could be done at any other time. |
|
Oh and I think, we might want to modify the entry point. Currently this is set up for use directly from the python cli, but there's no reason we couldn't make the container more independent. I mean, I probably should have done that from the start, but it's an easy enough change to make. |
mnoergaard
reviewed
Dec 7, 2023
bendhouseart
deleted the
24-enh-test-and-push-docker-container-for-petdeface-to-dockerhub
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates and pushes a docker container to dockerhub, see -> https://hub.docker.com/r/openneuropet/petdeface