-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: ISR Working Locally But Not Working on Netify #2127
Comments
We're in the process of upgrading to Next.js 13.4. See #2080. ISR was working, so most likely once this is merged, things should be working again. |
Please be aware also that we don't expect to see your new content in the reproduction steps you mentioned, @AresTransitGraphics . Here's the request cycle for a page with a 60 second revalidation set:
So - a test of "made a change, waited 60 s, loaded the page, see old content" is very expected. To be clear: I do believe you're seeing more misbehavior than that, and am not rejecting your bug report - just wanted to mention that a better test plan would be:
|
Thanks @fool, I understand what you mean by the request cycle. I should have explained it in more details. Actually I waited for far more than 60s to refresh and see the result and refresh and wait for serveral times. Thanks again for the test plan. I will update it in the initial request. |
Thanks a lot for your reply @nickytonline, I can confirm now it's related to the Next.js version 13.4.0. I've done another test after roll back the nextjs version to 13.3.0, the ISR is working on Netlify now. Really look forward to the new version nextjs being supported by new version of the next-runtime soon! Thanks again for your help. |
Any updated on this issue, and progress on next 13.4.4 support ? |
@bentrynning, we're still working on it. See #2080 |
Thanks for reply @nickytonline. Do you have a working version that I can fallback to with the current version of netlify-runtime. As of now I have tried all the way down to 13.0.0. And the issue still exist, so there is not an optimal situation for the user experience in NextJS sites 🙏 |
Hey, @bentrynning. We've just had one final issue to sort out and we'll be rolling out a fix this week (11th July 2023). |
@MarcL is the related to this issue? |
Yes - quite possibly @nickhow83. That's been raised internally and we're looking for you now. 👍🏻 |
Thanks @MarcL . It's possible it's also linked to this issue vercel/next.js#49169 (comment) |
Thanks for the additional info. That's super useful. 🙏🏻 |
@MarcL Sorry to just tag you, but I don't know who else is appropriate to message on this thread. I have some more information about what could be going wrong... The error states the path However It shouldn't be looking there for it, it should be looking at the next bundled version of react-dom It looks like somewhere, I don't know where, the handler is looking to the wrong react-dom for nextjs. |
I have found there are 2x issues:
|
@MarcL But I still get hard page reload when navigating in NextJS App. On version "next": "13.4.5", |
@nickhow83 - Thanks for the additional context. @bentrynning - We're aware of this issue. See also: #2089 |
Hi there, just wanted to mention that downgrading to next version /** @type {import('next').NextConfig} */
const nextConfig = {
experimental: {
appDir: true,
},
};
module.exports = nextConfig; Any estimation on when will be a fix available? It's very frustrating to downgrade to a version of May and missing important fixes. Thanks in advance! |
Hi @AresTG2612. ISR works in the Next Runtime v5. Please give that a try and open a new issue if necessary. Thanks! |
Summary
I’m trying to build a headless wordpress with nextjs and deploy on Netify. I’m using a starter template from GitHub - colbyfayock/next-wordpress-starter: 📝 Bring WordPress to the static world with Next.js.
I’ve watched the video tutorial Auto Update Static Content in Next.js with Incremental Static Regeneration (ISR) - YouTube and follow the same steps to set up the ISR properly by adding revalidate: 10 to getStaticProps(), which will be defaulted to be 60 when building on Netlify.
It’s working perfectly on local host. The problem is, after deploying it on Netlify, the ISR is not working anymore.
Any help would be greatly appreciated!
The frontend can be found from https://main--bright-nougat-01bbb4.netlify.app/.
A link to a reproduction repository
https://github.com/AresTG2612/next-wp
Expected Result
Update posts title content on wordpress, after refresh and wait for 60 seconds and refresh again the new title and content will be updated on frontend https://main--bright-nougat-01bbb4.netlify.app/.
Actual Result
Update posts title content on wordpress, after refresh and wait for 60 seconds and refresh again nothing was updated on frontend https://main--bright-nougat-01bbb4.netlify.app/.
Steps to reproduce
Next Runtime version
6.37.0
Is your issue related to the
app
directory?app
directoryMore information about your build
netlify.toml
)What OS are you using?
Mac OS
Your netlify.toml file
`netlify.toml`
Your public/_redirects file
`_redirects`
Your
next.config.js
file`next.config.js`
Builds logs (or link to your logs)
Build logs
Function logs
Function logs
.next JSON files
generated .next JSON files
The text was updated successfully, but these errors were encountered: