Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff: dev vs main #140

Draft
wants to merge 219 commits into
base: main
Choose a base branch
from
Draft

Diff: dev vs main #140

wants to merge 219 commits into from

Conversation

jthompson-arcus
Copy link
Collaborator

PR to show differences between dev and main branches

LDSamson and others added 30 commits September 30, 2024 13:32
@LDSamson
Increment version number to 0.1.0.9000
92d4659
@aclark02-arcus
Add pkgdown gha workflow
d62de80
@aclark02-arcus
don't rely on renv.lock
3381f26
@aclark02-arcus
update certain functions with '@Keywords internal' for pkddown
78e9927
@aclark02-arcus
Increment version number to 0.1.0.9000
19b8f83
@aclark02-arcus
update news
279bc5c
@aclark02-arcus
Merge branch 'dev' into ac-95
9c03622
@aclark02-arcus
Update golem config with new app version
0aff3a9
@aclark02-arcus
Merge branch 'ac-95' of https://github.com/openpharma/clinsight into …
0f08edf 
…ac-95
@jthompson-arcus
Add callback to "go to form" on double click event
f927749
@jthompson-arcus
Pass additional modifying functions in arguments of `merge_meta_with_…
a7b8eaa 
…data()`
@jthompson-arcus
Recode to use base R and character values
f091000
@jthompson-arcus
Move additional merging functions to metadata
1ff5c2d
@jthompson-arcus
Adjust %||% to check for empty values, not just NULL
5d4a444
@jthompson-arcus
Specify add_fns as post_merge_fns
6451405
@jthompson-arcus
Add pre_merge_fns setting
2270fdc
@jthompson-arcus
Add inline function to check existence of an object for dplyr mutat…
7cf9ee4 
…ions
@jthompson-arcus
Impute event_name from event instead of event_name
ba6c086
@jthompson-arcus
Fix broken tests
8dc00e0
@jthompson-arcus
Further generalize add_timevars_to_data()
8154349
@jthompson-arcus
Initialize region field
325c27d
@jthompson-arcus
Add mid-merging functions
2506500
@jthompson-arcus
Update version and NEWS
c9755b7
@jthompson-arcus
Move logic to dblclick_to_form() function
ed64d65
@jthompson-arcus
Remove duplicate type conversion
f48ebac
@jthompson-arcus
Create apply_custom_functions() to handle
6087b0e
@jthompson-arcus
Clean up metadata settings element generation
a980920
@jthompson-arcus
Remove extraneous pipe
c90e778
@jthompson-arcus
Reset %||% to standard evaluation
4d7fd45
@jthompson-arcus
Display message if using user supplied data.
6adecea
jthompson-arcus and others added 30 commits November 21, 2024 08:48
@jthompson-arcus
Grab un-duplicated rv_records
c177a30
@jthompson-arcus
Remove unnecessary dplyr::select()
d2fa0d6
@jthompson-arcus
Remove unneeded dplyr::distinct()
de24777
@jthompson-arcus
Return db_get_review() when ... is empty
d372afa
@LDSamson
Update to latest test-coverage. Remove package installation since it …
8261441 
…is redundant
@LDSamson
Fix codecov arguments for codecov-actvion V5 https://github.com/marke…
0f4a693 
…tplace/actions/codecov#v5-release
@LDSamson
Print codecov results again
c547862
@jthompson-arcus
Update test-mod_review_forms.R
f28f174
@LDSamson
Update version and news
047b459
@jthompson-arcus
Update only one table in db_save_review()
7e26f83
@jthompson-arcus
Fix oopsies
ad3f05e
@jthompson-arcus
Merge pull request #139 from openpharma/ls_update_codecov
b2bd9bb 
Fix codecov uploads
@jthompson-arcus
Fix merge conflict with dev
939566f 
Merge branch 'dev' into jt-99-review_by_row

# Conflicts:
#	DESCRIPTION
#	inst/golem-config.yml
@jthompson-arcus
Add test for db_get_review() when no filters are specified
439d14b
@jthompson-arcus
Fix updated_items_memory
0079348
@LDSamson
Don't export db_get_review anymore
ca83997
@LDSamson
Update documentation
0f680cd
@LDSamson
Ensure db_get_review errors before sending a db query if ... cannot…
a08c510 
… be coerced to a data frame
@LDSamson
Add additional tests
f7ba04a
@LDSamson
Use more consistent naming in the save review process
205896f
@LDSamson
Change a dplyr::filter call to base R filter for performance reasons
b8f3f52
@LDSamson
Ensure that updated_records_memory has the same columns as in the db
0154355
@LDSamson
Ensure tests will fail if there is a review discrepancy
f0144a2
@LDSamson
Export review_save_error to ensure errors are captured when saving re…
5360760 
…view in in a shinytest2 test
@LDSamson
Update snaps
88f5b04
@LDSamson
Also update mod_main_sidebar snaps
23b6e91
@LDSamson
Change to base R filter
6ce5827
@LDSamson
Fix review saving by selecting correct rows to update within the appl…
0e8ecc7 
…ication
@LDSamson
Remove the (now) redundant filtering by timestamp for updated_records…
d8e24d4 
…_memory
@LDSamson
Merge pull request #137 from openpharma/jt-99-review_by_row
5845568 
Review by records instead of `subject_id` & `form_id` "rv_row"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jthompson-arcus @LDSamson @aclark02-arcus