Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link issue with lj_vm_IITERN on s390x #136

Closed
velemas opened this issue Oct 15, 2021 · 3 comments
Closed

Link issue with lj_vm_IITERN on s390x #136

velemas opened this issue Oct 15, 2021 · 3 comments

Comments

@velemas
Copy link
Contributor

velemas commented Oct 15, 2021

After applying this PR #135, i have a link issue on s390x:

lj_dispatch_dyn.o: In function `lj_dispatch_init':
/home/linux1/luajit2/src/lj_dispatch.c:72: undefined reference to `lj_vm_IITERN'
lj_dispatch_dyn.o: In function `lj_dispatch_update':
/home/linux1/luajit2/src/lj_dispatch.c:145: undefined reference to `lj_vm_IITERN'
/usr/bin/ld: libluajit.so: hidden symbol `lj_vm_IITERN' isn't defined
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:739: libluajit.so] Error 1

It looks like this commit bb0f241 lacks the changes for s390x made for all other archs concerning vm_IITERN.
@xiaocang
Copy link
Contributor

Hi @zhuizhuhaomeng Can you help with this?

@velemas velemas mentioned this issue Oct 19, 2021
Closed
@zhuizhuhaomeng
Copy link
Contributor

I don't think I can give you more help because I am not so familiar with this part of the code. And I do not have an s390 machine to verify.

@velemas
Copy link
Contributor Author

velemas commented Oct 19, 2021

@zhuizhuhaomeng free community s390x VMs are available, see https://linuxone.cloud.marist.edu/#/login

@velemas velemas mentioned this issue Nov 5, 2021
Closed
velemas pushed a commit to velemas/luajit2 that referenced this issue Nov 8, 2021
This PR fixes issue openresty#136
4a81549 
and breakage introduced by commit 5980ef9 seen in
kubernetes/ingress-nginx#6504 on s390x.

Additionally implemented:
- Table traversal changes for s390x introduced in commits c6f5ef6 and bb0f241.
- CI for s390x.

Signed-off-by: Artiom Vaskov <artiom.vaskov@ibm.com>
@velemas velemas mentioned this issue Nov 8, 2021
Merged
velemas pushed a commit to velemas/luajit2 that referenced this issue Nov 8, 2021
This PR fixes issue openresty#136
8c10bbc 
and breakage introduced by commit 5980ef9 seen in
kubernetes/ingress-nginx#6504 on s390x.

Additionally implemented:
- Table traversal changes for s390x introduced in commits c6f5ef6 and bb0f241.
- CI for s390x.

Signed-off-by: Artiom Vaskov <artiom.vaskov@ibm.com>
velemas pushed a commit to velemas/luajit2 that referenced this issue Nov 8, 2021
This PR fixes issue openresty#136
ee669f3 
and breakage introduced by commit 5980ef9 seen in
kubernetes/ingress-nginx#6504 on s390x.

Additionally implemented:
- Table traversal changes for s390x introduced in commits c6f5ef6 and bb0f241.
- CI (valgrind disabled for s390x because of unimplemented instruction).

Signed-off-by: Artiom Vaskov <artiom.vaskov@ibm.com>
zhuizhuhaomeng pushed a commit that referenced this issue Nov 17, 2021
bugfix: This PR fixes issue #136 (#144)
1085a4d 
and breakage introduced by commit 5980ef9 seen in
kubernetes/ingress-nginx#6504 on s390x.

Additionally implemented:
- Table traversal changes for s390x introduced in commits c6f5ef6 and bb0f241.
- CI (valgrind disabled for s390x because of unimplemented instruction).

Signed-off-by: Artiom Vaskov <artiom.vaskov@ibm.com>
@khvzak khvzak mentioned this issue Nov 29, 2021
Closed
@velemas velemas closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xiaocang @zhuizhuhaomeng @velemas