Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR fixes issues on s390x #142

Closed
wants to merge 1 commit into from
Closed

This PR fixes issues on s390x #142

wants to merge 1 commit into from

Conversation

velemas
Copy link
Contributor

@velemas velemas commented Nov 5, 2021

This PR fixes issue #136
and breakage introduced by commit 5980ef9 seen in
kubernetes/ingress-nginx#6504 on s390x.

Signed-off-by: Artiom Vaskov artiom.vaskov@ibm.com

and breakage introduced by commit 5980ef9 seen in
kubernetes/ingress-nginx#6504 on s390x.

Signed-off-by: Artiom Vaskov <artiom.vaskov@ibm.com>
@velemas velemas changed the title This PR fixes issue https://github.com/openresty/luajit2/issues/136 This PR fixes issues on s390x Nov 5, 2021
@zhuizhuhaomeng
Copy link
Contributor

This PR fixes issue #136 and breakage introduced by commit 5980ef9 seen in kubernetes/ingress-nginx#6504 on s390x.

Signed-off-by: Artiom Vaskov artiom.vaskov@ibm.com

@velemas would you please add s390 for ci just like https://github.com/openresty/luajit2/pull/137/files?
only one line code is needed.

@velemas
Copy link
Contributor Author

velemas commented Nov 8, 2021

@zhuizhuhaomeng i will but before that it needs additional s390x fixes for changes introduced in commits c6f5ef6 and bb0f241 (table traversal).
I am preparing updates to allow s390x to pass all the tests from luajit2-test-suite with new table traversal.

@velemas
Copy link
Contributor Author

velemas commented Nov 8, 2021

@zhuizhuhaomeng sorry, i accidentally removed my fork, i will close this PR and create a new one with all the changes to pass the tests and CI enabled.
New PR #144

@velemas velemas closed this Nov 8, 2021
@velemas
Copy link
Contributor Author

velemas commented Nov 8, 2021

This PR fixes issue #136 and breakage introduced by commit 5980ef9 seen in kubernetes/ingress-nginx#6504 on s390x.
Signed-off-by: Artiom Vaskov artiom.vaskov@ibm.com

@velemas would you please add s390 for ci just like https://github.com/openresty/luajit2/pull/137/files? only one line code is needed.

Actually i see another exception for archs other than amd64 (currently only arm64):
if [ ${TRAVIS_CPU_ARCH} != "arm64" ]; then PATH=/opt/luajit21/bin:$PATH prove -I. t; fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants