Strive for a more complete Joda-time migration #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Sep 8, 2025
timtebeek
reviewed
Sep 8, 2025
…/remove-safe-migration # Conflicts: # src/main/java/org/openrewrite/java/joda/time/JodaTimeScanner.java
timtebeek
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/FieldTemplate.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/Templates.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
changed the title
added 3 commits
October 31, 2025 18:20
# Conflicts: # src/main/java/org/openrewrite/java/joda/time/JodaTimeScanner.java # src/main/java/org/openrewrite/java/joda/time/templates/AllTemplates.java
…ve-safe-migration
fix merge issues
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/Templates.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/Templates.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Outdated
Show resolved
Hide resolved
added 2 commits
December 2, 2025 16:15
# Conflicts: # src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java # src/main/java/org/openrewrite/java/joda/time/templates/AllTemplates.java # src/test/java/org/openrewrite/java/joda/time/JodaTimeScannerTest.java
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/AllTemplates.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit c2d235e.
…isitor.java" This reverts commit e995a5d.
…isitor.java" This reverts commit 1dec07a.
src/main/java/org/openrewrite/java/joda/time/JodaTimeVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/joda/time/templates/TimeClassMap.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Joda recipe is no longer required to be a safe migration
Fixed some issues
Added array type
Add experimental FieldMatcher as an analog of MethodMatcher
What's your motivation?
Imrove the quality of migration
Preparation to add mappings
Anything in particular you'd like reviewers to focus on?
FieldMatcher can ba a candidate for common library
Anyone you would like to review specifically?
@timtebeek
Anshuman Mishra
Checklist