Convert Lombok @Value classes to Java records

[kevin0x90]

What's changed?

Adds a recipe for converting lombok value annotated classes to java records.

What's your motivation?

I am working on a case study to evaluate the effort and benefit of automated refactorings.

Anyone you would like to review specifically?

@timtebeek

Checklist

• I've added unit tests to cover both positive and negative cases
• I've added the license header to any new files through ./gradlew licenseFormat
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

This is looking very promising already! Thanks for getting this started. Could you run ./gradlew lF to add the license headers? That would make the tests run here.

[kevin0x90]

This is looking very promising already! Thanks for getting this started. Could you run ./gradlew lF to add the license headers? That would make the tests run here.

Hi,

Sorry for the late reply and thank you for adding the copyright information.

I added more changes to approach the defined acceptability.
During the replacement of the getter methods I ran into some type problems. Maybe you have an idea how to prevent this?

[timtebeek]

Quick first round of feedback; really like that you took this on! Hope to get this closer to a merge soon, and start trying it out on projects.

Did you ever look towards using the Moderne CLI? That might allow you to run it locally across projects quickly, after a first round of building serialized LSTs. Not a requirement, but could give you feedback on how this works on your own projects without the repeated wait for the lossless semantic tree models to be built.

[kevin0x90]

Quick first round of feedback; really like that you took this on! Hope to get this closer to a merge soon, and start trying it out on projects.

Did you ever look towards using the Moderne CLI? That might allow you to run it locally across projects quickly, after a first round of building serialized LSTs. Not a requirement, but could give you feedback on how this works on your own projects without the repeated wait for the lossless semantic tree models to be built.

I did not yet try out the Moderne CLI but will give it a try for my sample project.

[timtebeek]

Finally found some more time to review; haven't yet gotten to the missing type information, but did find some simplifications and a case not yet covered around static fields. Not quite sure what records allow there, but might be safest to just not convert those cases. I've also grouped the tests into a nested class, such that it's easier to spot what should and should not be supported.

Let me know if you'd like to fix that failing test yourself, or if you'd at any point want to hand this over. :)

[kevin0x90]

Finally found some more time to review; haven't yet gotten to the missing type information, but did find some simplifications and a case not yet covered around static fields. Not quite sure what records allow there, but might be safest to just not convert those cases. I've also grouped the tests into a nested class, such that it's easier to spot what should and should not be supported.

Let me know if you'd like to fix that failing test yourself, or if you'd at any point want to hand this over. :)

Hi,

I will fix the failing test and keep on working on this branch whenever I find the time to do so.

[timtebeek]

Looks good to me! Thanks again.

Any last minute feedback @knutwannheden or @joanvr ?

[knutwannheden]

I can take a look.

[knutwannheden]

I just added a few small remarks. Apart from that I think this looks very good!

[timtebeek]

Thanks a lot @kevin0x90 ! You can try out this change through our snapshot versions, pending the next release.

I'll deploy it to https://app.moderne.io as well, and see how it performs against our own code base as well.

[timtebeek]

Ran it on a first few projects; think we might need some minor tweaks and polish. Example diff below

Two quick findings:

1. the fields converted to constructor args lack the corresponding indentation
2. we remove the @Value annotation anywhere in the compilation unit, not just on the record

[timtebeek]

Follow up now in:

• Polish LombokValueToRecord #334