Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish LombokValueToRecord #334

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Polish LombokValueToRecord #334

merged 1 commit into from
Oct 31, 2023

Conversation

timtebeek
Copy link
Contributor

What's changed?

  • Only remove annotations from record class.
  • Do not retain final or static modifiers on records.
  • Do not convert non static inner classes.

Any additional context

@timtebeek timtebeek self-assigned this Oct 31, 2023
timtebeek
timtebeek commented Oct 31, 2023
View reviewed changes
src/main/java/org/openrewrite/java/migrate/lombok/LombokValueToRecord.java
@@ -42,7 +40,7 @@
@EqualsAndHashCode(callSuper = false)
public class LombokValueToRecord extends ScanningRecipe<Map<String, Set<String>>> {

private static final AnnotationMatcher LOMBOK_VALUE_MATCHER = new AnnotationMatcher("@lombok.Value");
private static final AnnotationMatcher LOMBOK_VALUE_MATCHER = new AnnotationMatcher("@lombok.Value()");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an attempt to have the annotation matcher only match annotations without arguments; that didn't work, but I think it should.

@timtebeek timtebeek mentioned this pull request Oct 31, 2023
Merged
3 tasks
@timtebeek timtebeek added the bug Something isn't working label Oct 31, 2023
@sambsnyd sambsnyd merged commit 7b8083f into main Oct 31, 2023
1 check passed
@sambsnyd sambsnyd deleted the polish_lombok_value_to_record branch October 31, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden Awaiting requested review from knutwannheden

@joanvr joanvr Awaiting requested review from joanvr

Assignees

@timtebeek timtebeek

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @sambsnyd