Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MavenVisitor and Maven Pom model support for plugins and pluginManagement sections #585

Open
aegershman opened this issue May 26, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request parser-maven

Comments

@aegershman
Copy link
Contributor

In order to support operations similar to what is possible with dependencies, and managedDependencies, the MavenVisitor and Pom models should be enhanced to support identifying plugin and pluginManagement content.

This would make issues like #570 easier, which need to identify whether a version for a plugin is managed in a pluginManagement section or within a parent pom/bom.

see:

DependencyManagement dependencyManagement,

@fonvitale
Copy link

Hi! First of all, amazing tool. Thank you very much.

Do you have any progress on this? I've written a little test for the UpgradePluginVersion (really simple) just to check in the recipe (the inner visitor actually) was taking into account the pluginManagement section. Obviously not.

Following your Contribution Guide, I was about to create a draft, but I cannot create a branch of course. After all, it's a silly test and you have already detected the problem.

It would be great if you can give some news on the matter!

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parser-maven
Projects
Status: Backlog
Development

No branches or pull requests

6 participants