-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MavenVisitor and Maven Pom model support for plugins
and pluginManagement
sections
#585
Comments
Hi! First of all, amazing tool. Thank you very much. Do you have any progress on this? I've written a little test for the UpgradePluginVersion (really simple) just to check in the recipe (the inner visitor actually) was taking into account the pluginManagement section. Obviously not. Following your Contribution Guide, I was about to create a draft, but I cannot create a branch of course. After all, it's a silly test and you have already detected the problem. It would be great if you can give some news on the matter! Thank you in advance! |
In order to support operations similar to what is possible with
dependencies
, andmanagedDependencies
, the MavenVisitor and Pom models should be enhanced to support identifyingplugin
andpluginManagement
content.This would make issues like #570 easier, which need to identify whether a version for a plugin is managed in a
pluginManagement
section or within a parent pom/bom.see:
rewrite/rewrite-maven/src/main/java/org/openrewrite/maven/tree/Pom.java
Line 99 in f07c0f0
The text was updated successfully, but these errors were encountered: