UpgradePluginVersion -- ability to upgrade maven plugin version
#579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aegershman
force-pushed
the
upgrade-maven-plugin-version
branch
from
05a03f6 to
17f49ad
Compare
aegershman
changed the title
UpgradePluginVersion -- ability to upgrade maven plugin version
aegershman
force-pushed
the
upgrade-maven-plugin-version
branch
from
17f49ad to
ca14620
Compare
aegershman
force-pushed
the
upgrade-maven-plugin-version
branch
2 times, most recently
from
3d3587c to
105dc35
Compare
2 tasks
aegershman
force-pushed
the
upgrade-maven-plugin-version
branch
from
105dc35 to
34c0322
Compare
aegershman
force-pushed
the
upgrade-maven-plugin-version
branch
6 times, most recently
from
e45173b to
535b0d5
Compare
tkvangorder
suggested changes
Jun 9, 2021
| } | ||
|
|
||
| @Override | ||
| public Maven visitMaven(Maven maven, ExecutionContext ctx) { |
There was a problem hiding this comment.
Thinking we can move the logic for finding if we are going to make a change to the applicability test.
There was a problem hiding this comment.
I implemented an applicability test which simply checks for the existance of the desired plugin to upgrade. I fully expect for this entire visitor to be cleaned up to be more efficient, though the API for it's usage (options) should be stable, and it does work (assuming you aren't trying to get a version from pluginManagement, etc.). But, it does work. Forgive me for this, but I'm going to merge it knowing full-well it could use more love 😬
aegershman
force-pushed
the
upgrade-maven-plugin-version
branch
3 times, most recently
from
b604b38 to
3d94cf4
Compare
aegershman
force-pushed
the
upgrade-maven-plugin-version
branch
from
3d94cf4 to
04e45da
Compare
knutwannheden
pushed a commit
that referenced
this pull request
Mar 4, 2025
…ings (#579) * Fix issue 568, trailing semi-colon on property accessor without surroundings * polish * clean up warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #570
see downstream issue which prompted this: openrewrite/rewrite-quarkus#6
see: #585
This code looks wonky, I know. It's loosely based on upgradePluginDependency. Would be enhanced by virtue of having
pomandmavenmodel supports pluginManagementIn order to enable upgrading a maven plugin to a different version, include a recipe for specifying a
versionto upgrade a plugin to a later version.