[Plugins] update default url for installing plugins #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmarkley
reviewed
Mar 4, 2022
kavilla
force-pushed
the
avillk/plugin_http
branch
from
6b47705 to
e0be5a5
Compare
ashwin-pc
reviewed
Mar 7, 2022
Update old and invalid reference to custom plugins within the OpenSearch Project. Note: At the time that this is committed there is no gurantee that the latest build is the build that was select as the final build. Issue resolved: opensearch-project#1038 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
force-pushed
the
avillk/plugin_http
branch
from
e0be5a5 to
d728364
Compare
ashwin-pc
approved these changes
Mar 7, 2022
| return [plugin, generatePluginUrl(version, plugin)]; | ||
| } | ||
|
|
||
| function generatePluginUrl(version, plugin) { |
There was a problem hiding this comment.
Nit: This could have just been in generateUrls since that function doesn't do anything anymore 😂
There was a problem hiding this comment.
I think there is one called generateUrls (line 42) right?
ananzh
approved these changes
Mar 8, 2022
| return [plugin, generatePluginUrl(version, plugin)]; | ||
| } | ||
|
|
||
| function generatePluginUrl(version, plugin) { |
There was a problem hiding this comment.
I think there is one called generateUrls (line 42) right?
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
Update old and invalid reference to custom plugins within the OpenSearch Project. Note: At the time that this is committed there is no gurantee that the latest build is the build that was select as the final build. Issue resolved: #1038 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 9c82c52)
ananzh
pushed a commit
that referenced
this pull request
Mar 8, 2022
Update old and invalid reference to custom plugins within the OpenSearch Project. Note: At the time that this is committed there is no gurantee that the latest build is the build that was select as the final build. Issue resolved: #1038 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 9c82c52) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
tmarkley
reviewed
Mar 15, 2022
Comment on lines
+41
to
+42
| const ORIGINAL_PLATFORM = process.platform; | ||
| const ORIGINAL_ARCHITECTURE = process.arch; |
There was a problem hiding this comment.
This causes tests to be inconsistent depending on which platform/architecture you're running them from.
There was a problem hiding this comment.
My snapshots were updated on my arm64 machine and then they failed in GitHub Actions: https://github.com/opensearch-project/OpenSearch-Dashboards/runs/5548019026?check_suite_focus=true
There was a problem hiding this comment.
Going to submit a PR to fix this now.
tmarkley
pushed a commit
to tmarkley/OpenSearch-Dashboards
that referenced
this pull request
Mar 15, 2022
* The tests assumed that the platform/architecture combo the tests were run from was always linux/x64. * Introduced in opensearch-project#1316. Signed-off-by: Tommy Markley <markleyt@amazon.com>
7 tasks
tmarkley
pushed a commit
to tmarkley/OpenSearch-Dashboards
that referenced
this pull request
Mar 17, 2022
* The tests assumed that the platform/architecture combo the tests were run from was always linux/x64. * Introduced in opensearch-project#1316. Signed-off-by: Tommy Markley <markleyt@amazon.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 23, 2022
* The tests assumed that the platform/architecture combo the tests were run from was always linux/x64. * Introduced in #1316. Signed-off-by: Tommy Markley <markleyt@amazon.com>
tmarkley
pushed a commit
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update old and invalid reference to custom plugins within
the OpenSearch Project.
Note: At the time that this is committed there is no gurantee
that the latest build is the build that was select as the
final build.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#1038
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr