Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes inconsistent plugin installation tests #1346

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Fixes inconsistent plugin installation tests #1346

merged 1 commit into from
Mar 23, 2022

Conversation

tmarkley
Copy link
Contributor

Description

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@tmarkley tmarkley requested a review from a team as a code owner March 15, 2022 17:54
@tmarkley tmarkley mentioned this pull request Mar 15, 2022
Merged
7 tasks
Fixes inconsistent plugin installation tests
0a4fe56 
* The tests assumed that the platform/architecture combo the tests were
  run from was always linux/x64.
* Introduced in opensearch-project#1316.

Signed-off-by: Tommy Markley <markleyt@amazon.com>
kavilla
kavilla approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@kavilla kavilla merged commit 7aba935 into opensearch-project:main Mar 23, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2022
@github-actions
Fixes inconsistent plugin installation tests (#1346)
0089deb 
* The tests assumed that the platform/architecture combo the tests were
  run from was always linux/x64.
* Introduced in #1316.

Signed-off-by: Tommy Markley <markleyt@amazon.com>
(cherry picked from commit 7aba935)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 23, 2022
Merged
@tmarkley tmarkley deleted the plugin_test_fix branch March 23, 2022 21:13
tmarkley pushed a commit that referenced this pull request Mar 23, 2022
@opensearch-trigger-bot
Fixes inconsistent plugin installation tests (#1346) (#1372)
253d74b 
* The tests assumed that the platform/architecture combo the tests were
  run from was always linux/x64.
* Introduced in #1316.

Signed-off-by: Tommy Markley <markleyt@amazon.com>
(cherry picked from commit 7aba935)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 28, 2022
@github-actions
Fixes inconsistent plugin installation tests (#1346)
074f615 
* The tests assumed that the platform/architecture combo the tests were
  run from was always linux/x64.
* Introduced in #1316.

Signed-off-by: Tommy Markley <markleyt@amazon.com>
(cherry picked from commit 7aba935)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 28, 2022
Merged
ananzh pushed a commit that referenced this pull request Apr 28, 2022
@opensearch-trigger-bot
Fixes inconsistent plugin installation tests (#1346) (#1508)
49ef208 
* The tests assumed that the platform/architecture combo the tests were
  run from was always linux/x64.
* Introduced in #1316.

Signed-off-by: Tommy Markley <markleyt@amazon.com>
(cherry picked from commit 7aba935)

Co-authored-by: Tommy Markley <markleyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boktorbb boktorbb boktorbb approved these changes

@kavilla kavilla kavilla approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

Assignees
No one assigned
Labels
backport 1.3 test:unit v1.3.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmarkley @AMoo-Miki @kavilla @boktorbb