Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Vis Augmenter] Update base vis height in view events flyout (#4535) #4539

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] [Vis Augmenter] Update base vis height in view events flyout (#4535) #4539

wants to merge 1 commit into from

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Jul 10, 2023

Description

Manual backport of #4535

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ohltyler @lezzago
[Vis Augmenter] Update base vis height in view events flyout (opensea…
5dc9575 
…rch-project#4535)

* [Vis Augmenter] Update base vis height in view events flyout

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Update CHANGELOG

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

---------

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@lezzago lezzago mentioned this pull request Jul 10, 2023
Merged
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #4539 (5dc9575) into 2.x (3b9d45f) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #4539      +/-   ##
==========================================
- Coverage   66.44%   66.39%   -0.06%     
==========================================
  Files        3288     3288              
  Lines       63288    63288              
  Branches     9846     9846              
==========================================
- Hits        42051    42017      -34     
- Misses      18857    18885      +28     
- Partials     2380     2386       +6
Flag Coverage Δ
Linux 66.39% <ø> (ø)
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ew_events_flyout/components/view_events_flyout.tsx 3.84% <ø> (ø)

... and 7 files with indirect coverage changes

@manasvinibs
Copy link
Member

@lezzago Can we close this PR as #4538 this is already merged?

@ohltyler
Copy link
Member

Looks like it, will close. @lezzago re-open if needed

@ohltyler ohltyler closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manasvinibs manasvinibs manasvinibs approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

Assignees
No one assigned
Labels
v2.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lezzago @manasvinibs @ohltyler