Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Vis Augmenter] Update base vis height in view events flyout (#4535) #4539

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] [Vis Augmenter] Update base vis height in view events flyout (#4535) #4539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Saved Object Service] Add Repository Factory Provider ([#4149](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4149))
- Enable plugins to augment visualizations with additional data and context ([#4361](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4361))
- New management overview page and rename stack management to dashboard management ([#4287](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4287))
- [Vis Augmenter] Update base vis height in view events flyout ([#4535](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4535))


### 🐛 Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/vis_augmenter/public/view_events_flyout/components/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
$vis-description-width: 200px;
$event-vis-height: 55px;
$timeline-panel-height: 100px;
$timeline-panel-height: 90px;
$content-padding-top: 110px; // Padding needed within view events flyout content to sit comfortably below flyout header
$date-range-height: 45px; // Static height we want for the date range picker component
$error-icon-padding-right: -8px; // This is so the error icon is aligned consistent with the event count icons
Expand Down
8 changes: 6 additions & 2 deletions src/plugins/vis_augmenter/public/view_events_flyout/components/view_events_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,14 @@ export function ViewEventsFlyout(props: Props) {
>
<DateRangeItem timeRange={timeRange as TimeRange} reload={reload} />
</EuiFlexItem>
<EuiFlexItem className="view-events-flyout__contentPanel" grow={5}>
<EuiFlexItem
className="view-events-flyout__contentPanel"
grow={7}
style={{ maxHeight: '40vh' }}
>
<BaseVisItem embeddable={visEmbeddable as VisualizeEmbeddable} />
</EuiFlexItem>
<EuiFlexItem className="view-events-flyout__contentPanel show-y-scroll" grow={5}>
<EuiFlexItem className="view-events-flyout__contentPanel show-y-scroll" grow={3}>
<EventsPanel
eventVisEmbeddablesMap={eventVisEmbeddablesMap as EventVisEmbeddablesMap}
/>
Expand Down