-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Worksapce][Feature] Update application category and retire dashboard management section #5281
Conversation
…ement and SavedObject management as standalone app, retire dashboard management (opensearch-project#208) * feat: init retire dashboard management Signed-off-by: tygao <tygao@amazon.com> * move index pattern to Library (opensearch-project#91) * move index pattern to libaray Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> index pattern always show under library Signed-off-by: Hailong Cui <ihailong@amazon.com> * functional test Signed-off-by: Hailong Cui <ihailong@amazon.com> * feat: move data source / advanced settings / saved objects management out of Dashboard management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: fix failed overview header ut Signed-off-by: tygao <tygao@amazon.com> * fix: deeplink inside saved objects management page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test fail Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test for each page wrapper Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * remove management dependency Signed-off-by: Hailong Cui <ihailong@amazon.com> * test: update cypress config to use workspace branch Signed-off-by: tygao <tygao@amazon.com> * Replace ManagementAppMountParams with AppMountParameters Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #5281 +/- ##
==========================================
+ Coverage 66.74% 66.75% +0.01%
==========================================
Files 3284 3288 +4
Lines 63095 63107 +12
Branches 10049 10048 -1
==========================================
+ Hits 42110 42128 +18
- Misses 18488 18582 +94
+ Partials 2497 2397 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: tygao <tygao@amazon.com>
a7858d4
to
d5a8477
Compare
Signed-off-by: tygao <tygao@amazon.com>
c831dc6
to
8a936d0
Compare
@kavilla could you help to run cypress manually with branch |
I think @opensearch-project/opensearch-ux mind commenting on this? 2.10 including nesting these settings deeper into management and then if this has a targetted release in minor branch we will be moving this again? I'd imagine as a user it would be frustrating within a couple minor bumps the navigation changed twice. Could UX expand on this: #4287 (comment) and how come this is no longer relevant? |
[MANUAL CYPRESS TEST RUN RESULTS]❌ Cypress test run failed!Inputs:
Link to results:https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/6501446059 |
Hi, Rocky, the change in 4287 is relevant, we move functions that's considered as management related to management section/category. In workspace, this section and the applications under it (ISM, snapshot, security, etc) will only be available in management workspace. @kgcreative |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
I think these changes reflect the evolving thoughts as we get ready to launch workspaces. To be more specific, the Admin changes allows us to better organize those items. As we build workspaces, however, we realized that |
Do we have a mechanism that can help feed into making data back decisions? I know we don't have telemetry enabled but it might be useful to get to see the usage of users and maybe dog food into why we made menu changes. |
This makes a lot of sense. As I've seen huge features implement without realizing the the power of OpenSearch Dashboards core. Saved objects and index patterns being the backbone of OpenSearch Dashboards and it would be better for a cohesive experience if OSD Core and other plugins unified the way it queried data. This makes integrations eligible to rapid development. For example if all plugins onboarded to the data plugin and query service, then we can add the support for different query languages in the service itself and plugins do not have to do anything to get that support. IMO, |
Before this PR, In this PR, items in this section are all moved out, and this section no longer exists. |
Is this PR still valid based on: #5280 (comment)? If not then we close or place into draft? |
Thanks for the reminder, I'll close it first. |
Description
The main change of this PR are:
Opensearch Dashboards
category toLibrary
.SavedObject management
toManage library
as standalone application.Issues Resolved
#5280
Screenshot
Before change
After change
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration