Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save query management render bug on discover #5867

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Feb 13, 2024

Description

Fix save query management render bug on discover.

Issues Resolved

resolves #5833

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bd75107) 66.95% compared to head (d53bf5b) 66.98%.
Report is 1 commits behind head on main.

Files Patch % Lines
...lication/utils/state_management/discover_slice.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5867      +/-   ##
==========================================
+ Coverage   66.95%   66.98%   +0.03%     
==========================================
  Files        3302     3304       +2     
  Lines       63532    63564      +32     
  Branches    10146    10149       +3     
==========================================
+ Hits        42536    42577      +41     
+ Misses      18530    18520      -10     
- Partials     2466     2467       +1     
Flag Coverage Δ
Linux_1 35.21% <0.00%> (-0.01%) ⬇️
Linux_2 55.11% <ø> (ø)
Linux_3 43.53% <0.00%> (-0.32%) ⬇️
Linux_4 35.19% <ø> (-0.02%) ⬇️
Windows_1 35.24% <0.00%> (-0.01%) ⬇️
Windows_2 55.07% <ø> (ø)
Windows_3 43.54% <0.00%> (-0.33%) ⬇️
Windows_4 35.19% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc
Copy link
Member

Update opensearch-project/opensearch-build#4115 when merged and again when backported.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
ashwin-pc
ashwin-pc previously approved these changes Feb 13, 2024
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000
Copy link
Member Author

Will close this PR since this solution will introduce another bug.

@abbyhu2000 abbyhu2000 closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix glitch for save query management
3 participants