Upgrade chromedriver to fix bootstrapping errors

[derek-ho]

Description

Bumps chromdriver dependency causing errors during bootstrap due to URL change.

Issues Resolved

Potentially #5925

Screenshot

Testing the changes

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[derek-ho]

@AMoo-Miki @kavilla can you folks take a look and leave any thoughts? I don't know how we are determining the URL of chromedriver internally, so not sure if this will fix the whole issue.

[derek-ho]

I found this link: https://googlechromelabs.github.io/chrome-for-testing/#stable, looks like the URL changed

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.98%. Comparing base (352d304) to head (7b7187e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5926   +/-   ##
=======================================
  Coverage   66.98%   66.98%           
=======================================
  Files        3305     3305           
  Lines       63574    63574           
  Branches    10153    10153           
=======================================
+ Hits        42582    42585    +3     
+ Misses      18523    18521    -2     
+ Partials     2469     2468    -1     

Flag	Coverage Δ
Linux_1	35.21% <ø> (?)
Linux_2	55.11% <ø> (ø)
Linux_3	43.55% <ø> (+<0.01%)	⬆️
Linux_4	35.20% <ø> (ø)
Windows_1	35.24% <ø> (ø)
Windows_2	55.07% <ø> (ø)
Windows_3	43.56% <ø> (ø)
Windows_4	35.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kavilla]

Thanks @derek-ho,

Sometimes we have issues with Chrome not be available on GitHub envs. So we have a script

node scripts/upgrade_chromedriver.js

and then run yarn osd bootstrap. But doesn't hurt to bump it up if the GitHub env is available. Thank you for doing this, will wait for the CI to finish.

[derek-ho]

Thanks @derek-ho,

Sometimes we have issues with Chrome not be available on GitHub envs. So we have a script

node scripts/upgrade_chromedriver.js

and then run yarn osd bootstrap. But doesn't hurt to bump it up if the GitHub env is available. Thank you for doing this, will wait for the CI to finish.

I see. I took a quick look at the script, and it doesn't seem like it is hard coding any links. The fundamental issue seems to be chromedriver moved locations from
https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/XXX
to:
https://storage.googleapis.com/chrome-for-testing-public/XXX

So would this PR actually fix anything? Where is the https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/XXX coming from?

[BionIT]

Thanks @derek-ho,
Sometimes we have issues with Chrome not be available on GitHub envs. So we have a script

node scripts/upgrade_chromedriver.js

and then run yarn osd bootstrap. But doesn't hurt to bump it up if the GitHub env is available. Thank you for doing this, will wait for the CI to finish.

I see. I took a quick look at the script, and it doesn't seem like it is hard coding any links. The fundamental issue seems to be chromedriver moved locations from https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/XXX to: https://storage.googleapis.com/chrome-for-testing-public/XXX

So would this PR actually fix anything? Where is the https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/XXX coming from?

Looks like the upgrade chromedriver script only runs for a few tasks but not build and verify which might be why the tests pass but build and verify fails https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.github/workflows/build_and_test_workflow.yml#L32C5-L32C9

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5926-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4081154eeb79dcf601d20c08ab0efeae78ab7cbb
# Push it to GitHub
git push --set-upstream origin backport/backport-5926-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5926-to-2.x.

[opensearch-trigger-bot]

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.12
# Create a new branch
git switch --create backport/backport-5926-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4081154eeb79dcf601d20c08ab0efeae78ab7cbb
# Push it to GitHub
git push --set-upstream origin backport/backport-5926-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport/backport-5926-to-2.12.

[opensearch-trigger-bot]

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.12
# Create a new branch
git switch --create backport/backport-5926-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4081154eeb79dcf601d20c08ab0efeae78ab7cbb
# Push it to GitHub
git push --set-upstream origin backport/backport-5926-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport/backport-5926-to-2.12.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5926-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4081154eeb79dcf601d20c08ab0efeae78ab7cbb
# Push it to GitHub
git push --set-upstream origin backport/backport-5926-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5926-to-2.x.

[kavilla]

Manual backport #5928

[AMoo-Miki]

This should not have been backported since it breaks Node 14.