[Manual backport][2.x] Upgrade chromedriver to fix bootstrapping errors (#5926) #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5926) Bumps chromdriver dependency causing errors during bootstrap due to URL change. Issues Resolved: Signed-off-by: Derek Ho <dxho@amazon.com>
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5928 +/- ##
=======================================
Coverage 67.02% 67.02%
=======================================
Files 3303 3303
Lines 63615 63615
Branches 10147 10147
=======================================
Hits 42639 42639
Misses 18512 18512
Partials 2464 2464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Feb 23, 2024
abbyhu2000
approved these changes
Feb 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
Bumps chromdriver dependency causing errors during bootstrap due to URL change. Issues Resolved: Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 4f11775) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
This change cannot go into 2.x due to Node 14 requirements. We will need to roll this back. |
|
Will revert this PR. |
abbyhu2000
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this pull request
Feb 29, 2024
…project#5926) (opensearch-project#5928)" This reverts commit 4f11775. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
added a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5926 to 2.x