Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate backwards compatibility testing in CI workflow #113

Closed
peternied opened this issue Feb 22, 2021 · 6 comments
Closed

Separate backwards compatibility testing in CI workflow #113

peternied opened this issue Feb 22, 2021 · 6 comments
Assignees
Labels
Build Libraries & Interfaces >test-failure Test failure from CI, local build, etc.

Comments

@peternied
Copy link
Member

In the ./gradlew check process the build tasks for backwards compatibility of the previous version of elasticsearch are run. During CI runs it would be better to block this part of the workflow until after the more basic tests are run.

@peternied peternied added >test-failure Test failure from CI, local build, etc. Build Libraries & Interfaces labels Feb 22, 2021
peternied added a commit that referenced this issue Feb 24, 2021
* Update CI workflow to work on new infra

- Backward compatability tests are disabled during CI by default #113
- Added property to allow for disabling bwc tests
- Added agent label to use specific hardware https://www.jenkins.io/doc/book/pipeline/syntax/#agent

Signed-off-by: Peter Nied <petern@amazon.com>
setiah added a commit that referenced this issue Feb 25, 2021
…137)

* Remove any non oss from build, package, and distribution (#102)

This commit changes the building, packaging, and testing framework to only support OSS on different distributions. 

Next steps:

completely remove -oss flag dependencies in package and build tests
move 6.x bwc testing to be an explicit option
remove any references to elastic.co download site (or replace with downloads from the OSS website)

Co-authored-by: Himanshu Setia <setiah@amazon.com>
Co-authored-by: Rabi Panda <pandarab@amazon.com>
Co-authored-by: Himanshu Setia <58999915+setiah@users.noreply.github.com>
Co-authored-by: Sarat Vemulapalli <vemsarat@amazon.com>

* Remove x-pact from RESI API username and password (#117)

* Update signoff message (#121)

Signed-off-by: Harold Wang <harowang@amazon.com>

* Update CI workflow to work on new infra (#123)

* Update CI workflow to work on new infra

- Backward compatability tests are disabled during CI by default #113
- Added property to allow for disabling bwc tests
- Added agent label to use specific hardware https://www.jenkins.io/doc/book/pipeline/syntax/#agent

Signed-off-by: Peter Nied <petern@amazon.com>

* Disable BWC checks. (#130)

As part of this PR, we are disabling the BWC checks. Once we have finalized the versions for the fork, we can re-enable it with right configurations.

Relates #105

Signed-off-by: Rabi Panda <pandarab@amazon.com>

* Adding test distribution logic to fix failures from main merge

Co-authored-by: Nick Knize <nknize@gmail.com>
Co-authored-by: Rabi Panda <pandarab@amazon.com>
Co-authored-by: Sarat Vemulapalli <vemsarat@amazon.com>
Co-authored-by: Harold Wang <74381974+harold-wang@users.noreply.github.com>
Co-authored-by: Peter Nied <petern@amazon.com>
peternied added a commit that referenced this issue Mar 13, 2021
* Update CI workflow to work on new infra

- Backward compatability tests are disabled during CI by default #113
- Added property to allow for disabling bwc tests
- Added agent label to use specific hardware https://www.jenkins.io/doc/book/pipeline/syntax/#agent

Signed-off-by: Peter Nied <petern@amazon.com>
setiah added a commit that referenced this issue Mar 18, 2021
* [PURIFY] Remove x-pack directory

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove docs directory (#3)

This commit removes the doc directory

Signed-off-by: Peter Nied <petern@amazon.com>

* Cleanup build-scan, remove publish scan to elastic server (#1) (#4)

Co-authored-by: Huan Jiang <huanji@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack eql (#5)

This commit removes all trace of EQL from the sanitized fork.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove issue, pr tempalte to avoid confusion, we could add olater (#10) (#6)

Co-authored-by: Huan Jiang <huanji@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] update build.gradle files to ensure build completes; gradle check fails (#7)

Signed-off-by: Peter Nied <petern@amazon.com>

* Cleanup build script to exclude security-authorization-engine  (#8) (#8)

* Cleanup build-scan, remove publish scan to elastic server

* Cleanup build script to exclude security-authorization-engine which test has dependency on xpack

* Cleanup build script to exclude security-authorization-engine which test has dependency on xpack

Co-authored-by: Huan Jiang <huanji@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack enrichment processor (#9)

This commit removes all trace of the Elastic licensed enrichment processor.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack async-search (#10)

This commit removes all trace of Elastic licensed asyc-search

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack ccr (#11)

This committ removes all trace of Elastic licensed CCR.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove the Elastic license file, all checks for this license and the license REST APIs. (#12)

Co-authored-by: Rabi Panda <rabipanda@icloud.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack graph (#13)

This commit removes all trace of Elastic licensed graph feature

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack ml (#14)

This commit removes all trace of x-pack ml.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Add InferenceConfig to org.elasticsearch.client.analytics (#15)

This commits adds InferenceConfig back to org.elasticsearch.client.analytics for use in InferencePipelineAggregationBuilder.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack security (#16)

This commit removes all trace of the security high level rest client and other reference to x-pack security

Co-authored-by: Rabi Panda <rabipanda@icloud.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack rollups (#17)

This commit removes all trace of Elastic licensed rollups

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack sql (#18)

This commit removes all trace of Elastic licensed SQL

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack migration (#19)

This commit removes all trace of Elastic licensed Migration

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack index lifecycle management (#20)

This commit removes all trace of Elastic licensed ILM.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack watcher (#21)

This commit removes all trace of Elastic licensed watcher

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack monitoring (#22)

This commit removes all trace of Elastic licensed monitoring

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove remaining x-pack license. (#25)

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Revert "Move data stream transport and rest action to xpack (#59593)" (#28)

This commit reverts commit 2a89e13. Relicensing data streams from OSS to XPack.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack transforms (#31)

This commit removes all trace of Elastic licensed transforms.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] fix GetDataStreamsRequestTests build failure

This fixes the constructor for IndexNameExpressionResolver to pass in
Settings.EMPTY to a ThreadContext used by the resolver.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove the AuthorizationEnginePlugin from examples. (#26)

Signed-off-by: Peter Nied <petern@amazon.com>

* Fix compilation issues for tests. (#29)

Some of the tests that use the x-pack code are failing compilation. This PR cleans up the references to fix the issue.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Cleanup build and unblock HLRC integration tests (#33)

This commit cleans up the following:

* Remove unused imports
* Remove ILM settings in hlrc testCluster formation
* Comment out security users settings in ElasticsearchNode creation for build-tools tests

Signed-off-by: Peter Nied <petern@amazon.com>

* Adding initial CI workflow for search (#35)

Signed-off-by: Peter Nied <petern@amazon.com>

* [TEST] Fix unit test failure in RestHighLevelClientTests (#36)

* fix testProvidedNamedXContents by modifying the assertion

Signed-off-by: Peter Nied <petern@amazon.com>

* [TEST] fix DeleteDataStreamRequestTests failure (#37)

This commit fixes DeleteDataStreamRequestTests.testDeleteSnapshottingDataStream unit test failure by passing SnapshotsInProgress.Entry.SUCCESS in the createEntrymethod.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove license option in gradlew command (#41)

* Remove license option in gradlew command

* Remove "This username and password is part of trial license. Let's remove this too" from TESTING.asciidoc

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove x-pack from build, distribution and packaging. (#43)

This PR removes references to x-pack from buildSrc, distribution and qa modules.

Signed-off-by: Peter Nied <petern@amazon.com>

* Removing _reload_search_analyzers related changes since the related x-pack support is removed (#48)

Signed-off-by: Peter Nied <petern@amazon.com>

* Fixing Rest Converters Tests after x-pack removal (#54)

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove license statement from CONTRIBUTING.md (#58)

Signed-off-by: Peter Nied <petern@amazon.com>

* Revert back refresh policy in RequestConverters. (#55)

This PR reverts back the deleted code (#16, #54) related to refresh policies.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove unused imports in RemoteClustersIT and InternalTestCluster

This commit removes unused imports that are causing checkStyle failures.

Signed-off-by: Peter Nied <petern@amazon.com>

* [DOCS] temporarily comment verifyDocsLuceneVersion in qa:verify-version-constants

Docs have temporarily been removed. This commit can be reverted if the OSS
docs are restored.

Signed-off-by: Peter Nied <petern@amazon.com>

* Mute AnalyticsAggsIT test failure

AnalyticsAggsIT needs to be removed. This mutes the test until removal is complete.

Signed-off-by: Peter Nied <petern@amazon.com>

* [MUTE] AwaitsFix failing tests

This commit mutes failing tests in:
    * IndicesClientIT
    * SearchIT (Freeze/UnFreeze)
    * IndicesClientDocumentationIT

Fixes are identified and will be merged in a followup PR.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove packaging tests for the x-pack command line tools. (#56)

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove x-pack aggregations. (#59)

This PR removes the x-pack aggregations: string_stats, top_metrics and inference.

Resolves #51
Relates #2

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove x-pack data-frame analytics hlrc. (#62)

This PR removes the hlrc for x-pack data-frame analytics.

Relates #2

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove ILM policy from GetDataStreamAction Response. (#63)

Signed-off-by: Peter Nied <petern@amazon.com>

* Ensure ReplicationOperation notify listener once (#68256)

ReplicationOperation can notify the listener twice if the primary shard
is demoted after it has completed the primary operation.

Closes #68049

Signed-off-by: Peter Nied <petern@amazon.com>

* Fix search template request (#43509)

A seed was hit in (#43157) that caused mutateInstance to generate an identical
instance. This change prevents that.

Signed-off-by: Peter Nied <petern@amazon.com>

* Lower skip version for token_cound yaml test (#68583)

Signed-off-by: Peter Nied <petern@amazon.com>

* Revert previous change to fix import issue.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove unused imports in ArchiveTests

Signed-off-by: Peter Nied <petern@amazon.com>

* Fix unit test for removal of x-pack aggregations. (#65)

This PR fixes the unit test which failed after removal of the x-pack aggregations #59.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove ProtocolUtils, TimeUtils, and XContentSource from HLRC (#64)

This commit removes the ProtocolUtils, TimeUtils, and XContentSource utility classes which is only used for xpack HLRC.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove x-pack feature flag from yaml test (#68)

This commit removes the xpack no_xpack feature flag from the yaml test suite.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove testcase testSearchWithBasicLicensedQuery since basic license is no longer applicable (#74)

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove UnusedImports (#76)

Signed-off-by: Peter Nied <petern@amazon.com>

* Bring back the REST specs for data streams. (#78)

Add back the REST specs for data streams which were moved to x-pack as part of the commit fe12217

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove unused imports after x-pack feature flag removed from yaml test (#81)

Signed-off-by: Peter Nied <petern@amazon.com>

* [TEST] Fix Feature Flags in Test Framework and SortTemplates yaml failure (#82)

This commit adds parse logic to correctly parse feature flags in the test framework. It also fixes a test failure in cat.templates/Sort Templates yaml test.

Signed-off-by: Peter Nied <petern@amazon.com>

* Run precommit and unit tests as part of github actions. (#84)

Signed-off-by: Peter Nied <petern@amazon.com>

* Removing FreezeIndex related code since its x-pack counterpart is removed (#85)

Signed-off-by: Peter Nied <petern@amazon.com>

* Only run pre-commit checks in GitHub actions. (#94)

Signed-off-by: Peter Nied <petern@amazon.com>

* Fixing Bwc checks for 7.10.3 (#93)

Signed-off-by: Peter Nied <petern@amazon.com>

* Temporary fix for license check path for debian packaging. (#97)

This currently unblocks the gradle check and subsequently will be removed by the meta issue #50

Signed-off-by: Peter Nied <petern@amazon.com>

* Disable plugincli feature (#101)

Plugins CLI - disable installing official plugins by name.

Currently the plugin cli allows installation of a plugin by name in which case it downloads the plugin artifacts from the official elastic artifacts repository.

We will enable it once we have the new official artifacts download URL (Tracking Issue: #100)

Signed-off-by: Peter Nied <petern@amazon.com>

* Support for continious integration with Jenkins (#96)

Adding jenkinsfile to describe the build / test / deployment process for this repository

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove any non oss from build, package, and distribution (#102)

This commit changes the building, packaging, and testing framework to only support OSS on different distributions.

Next steps:

completely remove -oss flag dependencies in package and build tests
move 6.x bwc testing to be an explicit option
remove any references to elastic.co download site (or replace with downloads from the OSS website)

Co-authored-by: Himanshu Setia <setiah@amazon.com>
Co-authored-by: Rabi Panda <pandarab@amazon.com>
Co-authored-by: Himanshu Setia <58999915+setiah@users.noreply.github.com>
Co-authored-by: Sarat Vemulapalli <vemsarat@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Remove x-pact from RESI API username and password (#117)

Signed-off-by: Peter Nied <petern@amazon.com>

* Update signoff message (#121)

Signed-off-by: Harold Wang <harowang@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Update CI workflow to work on new infra (#123)

* Update CI workflow to work on new infra

- Backward compatability tests are disabled during CI by default #113
- Added property to allow for disabling bwc tests
- Added agent label to use specific hardware https://www.jenkins.io/doc/book/pipeline/syntax/#agent

Signed-off-by: Peter Nied <petern@amazon.com>

* Disable BWC checks. (#130)

As part of this PR, we are disabling the BWC checks. Once we have finalized the versions for the fork, we can re-enable it with right configurations.

Relates #105

Signed-off-by: Rabi Panda <pandarab@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Create CODE_OF_CONDUCT.md (#124)

Explicitly adding code of conduct from https://opendistro.github.io/for-elasticsearch/codeofconduct.html

Signed-off-by: Peter Nied <petern@amazon.com>

* Add script to perform signoff check between commits (#152)

* Add script to perform signoff check between commits

Signed-off-by: Peter Nied <petern@amazon.com>

* [Rename] server/src/main/java/org/apache (#162)

This commit refactors all instances of elasticsearch in
server/src/main/java/org/apache to opensearch.

Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Revert "[Rename] server/src/main/java/org/apache (#162)"

This reverts commit c50e8c8
which went should have merged to the rename branch instead of
the main branch.

Signed-off-by: Peter Nied <petern@amazon.com>

* Update CODE_OF_CONDUCT.md

replaced renameme

Signed-off-by: Peter Nied <petern@amazon.com>

* Dummy commit to test the CI/CD workflow

Signed-off-by: Peter Nied <petern@amazon.com>

* Update .gitignore

Signed-off-by: Peter Nied <petern@amazon.com>

* Fixing transport deserialization with oss distribution (#218)

Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Update LICENSE.txt (#227)

updating to Apache 2.0 License from https://www.apache.org/licenses/LICENSE-2.0.txt

Signed-off-by: Peter Nied <petern@amazon.com>

* Update NOTICE.TXT with OpenSearch copyright (#232)

This commit updates the NOTICE.txt file to include the OpenSearch copyright
notice.

Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* fixed reference to old repo (#333)

This commit fixes the url reference to bwc disabled message.

Signed-off-by: Kyle Davis <kyledvs@amazon.com>

Co-authored-by: nknize <nknize@gmail.com>
Co-authored-by: Huan Jiang <huanji@amazon.com>
Co-authored-by: Rabi Panda <rabipanda@icloud.com>
Co-authored-by: Rabi Panda <adnapibar@gmail.com>
Co-authored-by: nknize <nknize@amazon.com>
Co-authored-by: Sarat Vemulapalli <vemsarat@amazon.com>
Co-authored-by: Harold Wang <74381974+harold-wang@users.noreply.github.com>
Co-authored-by: Himanshu Setia <58999915+setiah@users.noreply.github.com>
Co-authored-by: Nhat Nguyen <nhat.nguyen@elastic.co>
Co-authored-by: Jack Conradson <osjdconrad@gmail.com>
Co-authored-by: Christoph Büscher <cbuescher@posteo.de>
Co-authored-by: Abbas Hussain <abbas_10690@yahoo.com>
Co-authored-by: Peter Nied <pnied@microsoft.com>
Co-authored-by: Himanshu Setia <setiah@amazon.com>
Co-authored-by: Rabi Panda <pandarab@amazon.com>
Co-authored-by: Peter Nied <petern@amazon.com>
Co-authored-by: CEHENKLE <henkle@amazon.com>
Co-authored-by: Barani <bbarani@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Kyle J. Davis <halldirector@gmail.com>
@adnapibar adnapibar mentioned this issue May 28, 2021
2 tasks
@dblock
Copy link
Member

dblock commented Jun 3, 2021

@adnapibar this is saying something else than #799, which one's right?

@adnapibar
Copy link
Contributor

@adnapibar this is saying something else than #799, which one's right?

As the description of #799 says - ./gradlew check only runs a small number of bwc checks (only against compatible versions that are not yet released).

Our main goal of bwc check is to run it against compatible released versions e.g. against Elasticsearch 7.10.2. This is only run as part of ./gradlew bwcTest . See https://github.com/opensearch-project/OpenSearch/blob/main/TESTING.md#testing-backwards-compatibility for more details.

@dblock
Copy link
Member

dblock commented Jun 3, 2021

So this issue as stated is incorrect and should be closed?

@adnapibar
Copy link
Contributor

So this issue as stated is incorrect and should be closed?

Yes

@dblock
Copy link
Member

dblock commented Jun 3, 2021

Closing, thanks! @peternied lmk if I shouldn't have ;)

@dblock dblock closed this as completed Jun 3, 2021
@peternied
Copy link
Member Author

Thanks for cleaning this up @dblock - deferring to the newer issue!

Rishikesh1159 referenced this issue in Rishikesh1159/OpenSearch Apr 13, 2023
* test fix for failing test suites

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* addressed review comments

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

---------

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Rishikesh1159 referenced this issue in Rishikesh1159/OpenSearch Apr 18, 2023
* test fix for failing test suites

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* addressed review comments

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

---------

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Libraries & Interfaces >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

No branches or pull requests

4 participants