Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to perform signoff check between commits #152

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Add script to perform signoff check between commits #152

merged 3 commits into from
Mar 1, 2021

Conversation

peternied
Copy link
Member

Issue #24 - adding script for automated check of signoff on commits

Signed-off-by: Peter Nied petern@amazon.com

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@peternied
Add script to perform signoff check between commits
4949107 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied requested a review from setiah February 26, 2021 23:31
@chloe-zh
Copy link
Contributor

An open question is it ok to expose the internal email address? (Sql repository also made this change and for now we just linked the account with personal email and set it primary.)

@peternied
Copy link
Member Author

An open question is it ok to expose the internal email address? (Sql repository also made this change and for now we just linked the account with personal email and set it primary.)

Thanks for bringing this up! Lets work on this question inside of Amazon - as this is about our internal policies. Note! We should have this figured out very soon so that we can apply this sign off check with the expected email addresses ASAP.

@stockholmux
Copy link
Member

@peternied I think you need the chicken beaks around your email address (e.g. <petern@amazon.com>)

@peternied
Copy link
Member Author

@peternied I think you need the chicken beaks around your email address (e.g. <petern@amazon.com>)

I think that is the markdown processor coming into effect, this is what I see on the commit log

search git:(signoff-check) git show HEAD
commit 4949107f2c97dc2c76ad938f7ae7a02756d5fcf5 (HEAD -> signoff-check, peternied/signoff-check)
Author: Peter Nied <petern@amazon.com>
Date:   Fri Feb 26 17:29:25 2021 -0600

    Add script to perform signoff check between commits
    
    Signed-off-by: Peter Nied <petern@amazon.com>

@stockholmux
Copy link
Member

@peternied Ah! Makes total sense. That's going to be super confusing to folks learning the ropes.

@peternied peternied requested a review from nknize March 1, 2021 19:02
setiah
setiah reviewed Mar 1, 2021
View reviewed changes
dev-tools/signoff-check.sh Outdated Show resolved Hide resolved
@peternied
Fixing inverted signoff check
6885ff0 
Signed-off-by: Peter Nied <petern@amazon.com>
setiah
setiah reviewed Mar 1, 2021
View reviewed changes
dev-tools/signoff-check.sh Outdated Show resolved Hide resolved
@peternied
Adding newline at the end of the file
bb862ad 
Signed-off-by: Peter Nied <petern@amazon.com>
@setiah setiah self-requested a review March 1, 2021 19:26
setiah
setiah approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@setiah setiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@peternied peternied merged commit 29d5b00 into opensearch-project:main Mar 1, 2021
@peternied peternied deleted the signoff-check branch March 8, 2021 18:17
peternied added a commit that referenced this pull request Mar 13, 2021
@peternied
Add script to perform signoff check between commits (#152)
9070dde 
* Add script to perform signoff check between commits

Signed-off-by: Peter Nied <petern@amazon.com>
setiah added a commit that referenced this pull request Mar 18, 2021
@nknize @seraphjiang
@adnapibar @saratvemulapalli @harold-wang @setiah @dnhatn @jdconrad @abbashus @peternied @CEHENKLE @bbarani @peterzhuamazon @stockholmux
[DOCS] Merge 'main' into 'oss-docs' - after DCO check was added (#349)
1c4b922 
* [PURIFY] Remove x-pack directory

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove docs directory (#3)

This commit removes the doc directory

Signed-off-by: Peter Nied <petern@amazon.com>

* Cleanup build-scan, remove publish scan to elastic server (#1) (#4)

Co-authored-by: Huan Jiang <huanji@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack eql (#5)

This commit removes all trace of EQL from the sanitized fork.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove issue, pr tempalte to avoid confusion, we could add olater (#10) (#6)

Co-authored-by: Huan Jiang <huanji@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] update build.gradle files to ensure build completes; gradle check fails (#7)

Signed-off-by: Peter Nied <petern@amazon.com>

* Cleanup build script to exclude security-authorization-engine  (#8) (#8)

* Cleanup build-scan, remove publish scan to elastic server

* Cleanup build script to exclude security-authorization-engine which test has dependency on xpack

* Cleanup build script to exclude security-authorization-engine which test has dependency on xpack

Co-authored-by: Huan Jiang <huanji@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack enrichment processor (#9)

This commit removes all trace of the Elastic licensed enrichment processor.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack async-search (#10)

This commit removes all trace of Elastic licensed asyc-search

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack ccr (#11)

This committ removes all trace of Elastic licensed CCR.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove the Elastic license file, all checks for this license and the license REST APIs. (#12)

Co-authored-by: Rabi Panda <rabipanda@icloud.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack graph (#13)

This commit removes all trace of Elastic licensed graph feature

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack ml (#14)

This commit removes all trace of x-pack ml.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Add InferenceConfig to org.elasticsearch.client.analytics (#15)

This commits adds InferenceConfig back to org.elasticsearch.client.analytics for use in InferencePipelineAggregationBuilder.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack security (#16)

This commit removes all trace of the security high level rest client and other reference to x-pack security

Co-authored-by: Rabi Panda <rabipanda@icloud.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack rollups (#17)

This commit removes all trace of Elastic licensed rollups

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack sql (#18)

This commit removes all trace of Elastic licensed SQL

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack migration (#19)

This commit removes all trace of Elastic licensed Migration

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack index lifecycle management (#20)

This commit removes all trace of Elastic licensed ILM.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack watcher (#21)

This commit removes all trace of Elastic licensed watcher

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack monitoring (#22)

This commit removes all trace of Elastic licensed monitoring

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove remaining x-pack license. (#25)

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Revert "Move data stream transport and rest action to xpack (#59593)" (#28)

This commit reverts commit 2a89e13. Relicensing data streams from OSS to XPack.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] remove all trace of x-pack transforms (#31)

This commit removes all trace of Elastic licensed transforms.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] fix GetDataStreamsRequestTests build failure

This fixes the constructor for IndexNameExpressionResolver to pass in
Settings.EMPTY to a ThreadContext used by the resolver.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove the AuthorizationEnginePlugin from examples. (#26)

Signed-off-by: Peter Nied <petern@amazon.com>

* Fix compilation issues for tests. (#29)

Some of the tests that use the x-pack code are failing compilation. This PR cleans up the references to fix the issue.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Cleanup build and unblock HLRC integration tests (#33)

This commit cleans up the following:

* Remove unused imports
* Remove ILM settings in hlrc testCluster formation
* Comment out security users settings in ElasticsearchNode creation for build-tools tests

Signed-off-by: Peter Nied <petern@amazon.com>

* Adding initial CI workflow for search (#35)

Signed-off-by: Peter Nied <petern@amazon.com>

* [TEST] Fix unit test failure in RestHighLevelClientTests (#36)

* fix testProvidedNamedXContents by modifying the assertion

Signed-off-by: Peter Nied <petern@amazon.com>

* [TEST] fix DeleteDataStreamRequestTests failure (#37)

This commit fixes DeleteDataStreamRequestTests.testDeleteSnapshottingDataStream unit test failure by passing SnapshotsInProgress.Entry.SUCCESS in the createEntrymethod.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove license option in gradlew command (#41)

* Remove license option in gradlew command

* Remove "This username and password is part of trial license. Let's remove this too" from TESTING.asciidoc

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove x-pack from build, distribution and packaging. (#43)

This PR removes references to x-pack from buildSrc, distribution and qa modules.

Signed-off-by: Peter Nied <petern@amazon.com>

* Removing _reload_search_analyzers related changes since the related x-pack support is removed (#48)

Signed-off-by: Peter Nied <petern@amazon.com>

* Fixing Rest Converters Tests after x-pack removal (#54)

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove license statement from CONTRIBUTING.md (#58)

Signed-off-by: Peter Nied <petern@amazon.com>

* Revert back refresh policy in RequestConverters. (#55)

This PR reverts back the deleted code (#16, #54) related to refresh policies.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove unused imports in RemoteClustersIT and InternalTestCluster

This commit removes unused imports that are causing checkStyle failures.

Signed-off-by: Peter Nied <petern@amazon.com>

* [DOCS] temporarily comment verifyDocsLuceneVersion in qa:verify-version-constants

Docs have temporarily been removed. This commit can be reverted if the OSS
docs are restored.

Signed-off-by: Peter Nied <petern@amazon.com>

* Mute AnalyticsAggsIT test failure

AnalyticsAggsIT needs to be removed. This mutes the test until removal is complete.

Signed-off-by: Peter Nied <petern@amazon.com>

* [MUTE] AwaitsFix failing tests

This commit mutes failing tests in:
    * IndicesClientIT
    * SearchIT (Freeze/UnFreeze)
    * IndicesClientDocumentationIT

Fixes are identified and will be merged in a followup PR.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove packaging tests for the x-pack command line tools. (#56)

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove x-pack aggregations. (#59)

This PR removes the x-pack aggregations: string_stats, top_metrics and inference.

Resolves #51
Relates #2

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove x-pack data-frame analytics hlrc. (#62)

This PR removes the hlrc for x-pack data-frame analytics.

Relates #2

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove ILM policy from GetDataStreamAction Response. (#63)

Signed-off-by: Peter Nied <petern@amazon.com>

* Ensure ReplicationOperation notify listener once (#68256)

ReplicationOperation can notify the listener twice if the primary shard
is demoted after it has completed the primary operation.

Closes #68049

Signed-off-by: Peter Nied <petern@amazon.com>

* Fix search template request (#43509)

A seed was hit in (#43157) that caused mutateInstance to generate an identical
instance. This change prevents that.

Signed-off-by: Peter Nied <petern@amazon.com>

* Lower skip version for token_cound yaml test (#68583)

Signed-off-by: Peter Nied <petern@amazon.com>

* Revert previous change to fix import issue.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove unused imports in ArchiveTests

Signed-off-by: Peter Nied <petern@amazon.com>

* Fix unit test for removal of x-pack aggregations. (#65)

This PR fixes the unit test which failed after removal of the x-pack aggregations #59.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove ProtocolUtils, TimeUtils, and XContentSource from HLRC (#64)

This commit removes the ProtocolUtils, TimeUtils, and XContentSource utility classes which is only used for xpack HLRC.

Signed-off-by: Peter Nied <petern@amazon.com>

* [PURIFY] Remove x-pack feature flag from yaml test (#68)

This commit removes the xpack no_xpack feature flag from the yaml test suite.

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove testcase testSearchWithBasicLicensedQuery since basic license is no longer applicable (#74)

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove UnusedImports (#76)

Signed-off-by: Peter Nied <petern@amazon.com>

* Bring back the REST specs for data streams. (#78)

Add back the REST specs for data streams which were moved to x-pack as part of the commit fe12217

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove unused imports after x-pack feature flag removed from yaml test (#81)

Signed-off-by: Peter Nied <petern@amazon.com>

* [TEST] Fix Feature Flags in Test Framework and SortTemplates yaml failure (#82)

This commit adds parse logic to correctly parse feature flags in the test framework. It also fixes a test failure in cat.templates/Sort Templates yaml test.

Signed-off-by: Peter Nied <petern@amazon.com>

* Run precommit and unit tests as part of github actions. (#84)

Signed-off-by: Peter Nied <petern@amazon.com>

* Removing FreezeIndex related code since its x-pack counterpart is removed (#85)

Signed-off-by: Peter Nied <petern@amazon.com>

* Only run pre-commit checks in GitHub actions. (#94)

Signed-off-by: Peter Nied <petern@amazon.com>

* Fixing Bwc checks for 7.10.3 (#93)

Signed-off-by: Peter Nied <petern@amazon.com>

* Temporary fix for license check path for debian packaging. (#97)

This currently unblocks the gradle check and subsequently will be removed by the meta issue #50

Signed-off-by: Peter Nied <petern@amazon.com>

* Disable plugincli feature (#101)

Plugins CLI - disable installing official plugins by name.

Currently the plugin cli allows installation of a plugin by name in which case it downloads the plugin artifacts from the official elastic artifacts repository.

We will enable it once we have the new official artifacts download URL (Tracking Issue: #100)

Signed-off-by: Peter Nied <petern@amazon.com>

* Support for continious integration with Jenkins (#96)

Adding jenkinsfile to describe the build / test / deployment process for this repository

Signed-off-by: Peter Nied <petern@amazon.com>

* Remove any non oss from build, package, and distribution (#102)

This commit changes the building, packaging, and testing framework to only support OSS on different distributions.

Next steps:

completely remove -oss flag dependencies in package and build tests
move 6.x bwc testing to be an explicit option
remove any references to elastic.co download site (or replace with downloads from the OSS website)

Co-authored-by: Himanshu Setia <setiah@amazon.com>
Co-authored-by: Rabi Panda <pandarab@amazon.com>
Co-authored-by: Himanshu Setia <58999915+setiah@users.noreply.github.com>
Co-authored-by: Sarat Vemulapalli <vemsarat@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Remove x-pact from RESI API username and password (#117)

Signed-off-by: Peter Nied <petern@amazon.com>

* Update signoff message (#121)

Signed-off-by: Harold Wang <harowang@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Update CI workflow to work on new infra (#123)

* Update CI workflow to work on new infra

- Backward compatability tests are disabled during CI by default #113
- Added property to allow for disabling bwc tests
- Added agent label to use specific hardware https://www.jenkins.io/doc/book/pipeline/syntax/#agent

Signed-off-by: Peter Nied <petern@amazon.com>

* Disable BWC checks. (#130)

As part of this PR, we are disabling the BWC checks. Once we have finalized the versions for the fork, we can re-enable it with right configurations.

Relates #105

Signed-off-by: Rabi Panda <pandarab@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Create CODE_OF_CONDUCT.md (#124)

Explicitly adding code of conduct from https://opendistro.github.io/for-elasticsearch/codeofconduct.html

Signed-off-by: Peter Nied <petern@amazon.com>

* Add script to perform signoff check between commits (#152)

* Add script to perform signoff check between commits

Signed-off-by: Peter Nied <petern@amazon.com>

* [Rename] server/src/main/java/org/apache (#162)

This commit refactors all instances of elasticsearch in
server/src/main/java/org/apache to opensearch.

Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Revert "[Rename] server/src/main/java/org/apache (#162)"

This reverts commit c50e8c8
which went should have merged to the rename branch instead of
the main branch.

Signed-off-by: Peter Nied <petern@amazon.com>

* Update CODE_OF_CONDUCT.md

replaced renameme

Signed-off-by: Peter Nied <petern@amazon.com>

* Dummy commit to test the CI/CD workflow

Signed-off-by: Peter Nied <petern@amazon.com>

* Update .gitignore

Signed-off-by: Peter Nied <petern@amazon.com>

* Fixing transport deserialization with oss distribution (#218)

Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* Update LICENSE.txt (#227)

updating to Apache 2.0 License from https://www.apache.org/licenses/LICENSE-2.0.txt

Signed-off-by: Peter Nied <petern@amazon.com>

* Update NOTICE.TXT with OpenSearch copyright (#232)

This commit updates the NOTICE.txt file to include the OpenSearch copyright
notice.

Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>

* fixed reference to old repo (#333)

This commit fixes the url reference to bwc disabled message.

Signed-off-by: Kyle Davis <kyledvs@amazon.com>

Co-authored-by: nknize <nknize@gmail.com>
Co-authored-by: Huan Jiang <huanji@amazon.com>
Co-authored-by: Rabi Panda <rabipanda@icloud.com>
Co-authored-by: Rabi Panda <adnapibar@gmail.com>
Co-authored-by: nknize <nknize@amazon.com>
Co-authored-by: Sarat Vemulapalli <vemsarat@amazon.com>
Co-authored-by: Harold Wang <74381974+harold-wang@users.noreply.github.com>
Co-authored-by: Himanshu Setia <58999915+setiah@users.noreply.github.com>
Co-authored-by: Nhat Nguyen <nhat.nguyen@elastic.co>
Co-authored-by: Jack Conradson <osjdconrad@gmail.com>
Co-authored-by: Christoph Büscher <cbuescher@posteo.de>
Co-authored-by: Abbas Hussain <abbas_10690@yahoo.com>
Co-authored-by: Peter Nied <pnied@microsoft.com>
Co-authored-by: Himanshu Setia <setiah@amazon.com>
Co-authored-by: Rabi Panda <pandarab@amazon.com>
Co-authored-by: Peter Nied <petern@amazon.com>
Co-authored-by: CEHENKLE <henkle@amazon.com>
Co-authored-by: Barani <bbarani@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Kyle J. Davis <halldirector@gmail.com>
Bukhtawar referenced this pull request in Bukhtawar/OpenSearch Sep 2, 2023
@Bukhtawar
Merge pull request #152 from Bukhtawar/remote-store-enabled-its
daa07c4 
Change action names to make tests work forcefully
@dbwiddis dbwiddis mentioned this pull request Sep 5, 2023
Merged
soosinha added a commit to soosinha/OpenSearch that referenced this pull request Sep 19, 2023
@soosinha
Squashed commit of the following:
cfae3e7 
commit 62feea0
Author: Sachin Kale <kalsac@amazon.com>
Date:   Wed Sep 6 09:23:56 2023 +0530

    Fix SharedClusterSnapshotRestoreIT and RestoreSnapshotIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit fdd357c
Author: Sachin Kale <kalsac@amazon.com>
Date:   Tue Sep 5 15:24:10 2023 +0530

    Fix CorruptedFileIT and SearchPreferenceIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit f0f631b
Author: bansvaru <bansvaru@amazon.com>
Date:   Mon Sep 4 19:31:02 2023 +0530

    fix CorruptedFileIT.testPrimaryCorruptionDuringReplicationDoesNotFailReplicaShard for remote store

    Signed-off-by: bansvaru <bansvaru@amazon.com>

commit 55acae7
Author: bansvaru <bansvaru@amazon.com>
Date:   Mon Sep 4 18:37:45 2023 +0530

    fix CorruptedFileIT.testCorruptFileAndRecover for remote store

    Signed-off-by: bansvaru <bansvaru@amazon.com>

commit b3262a5
Author: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Date:   Mon Sep 4 18:24:06 2023 +0530

    Fixing tests

    Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>

commit 054a5c1
Author: Sachin Kale <kalsac@amazon.com>
Date:   Mon Sep 4 16:16:32 2023 +0530

    Mute SingleNodeDiscoveryIT.testCannotJoinNodeWithSingleNodeDiscovery

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit e36fa0e
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Mon Sep 4 15:57:42 2023 +0530

    mark SimpleStats as awaits fix as it doesn't index docs

commit 2cf9d13
Author: Sachin Kale <kalsac@amazon.com>
Date:   Mon Sep 4 15:52:40 2023 +0530

    Fix SearchableSnapshotIT.testFileCacheStats

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit b2e5dc6
Author: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Date:   Mon Sep 4 15:21:34 2023 +0530

    Fixing tests

    Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>

commit a0eb936
Author: Sachin Kale <kalsac@amazon.com>
Date:   Mon Sep 4 14:56:30 2023 +0530

    Fix BlobStoreIncrementalityIT, again

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit a437510
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Mon Sep 4 14:54:39 2023 +0530

    removing primary search preference as relocation is happening here

commit 6753be8
Author: Sachin Kale <kalsac@amazon.com>
Date:   Mon Sep 4 14:25:34 2023 +0530

    Fix SegmentReplicationIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 65bc7cd
Author: Sachin Kale <kalsac@amazon.com>
Date:   Mon Sep 4 12:22:10 2023 +0530

    Fix FullRollingRestartIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 59d08b3
Author: Ashish Singh <ssashish@amazon.com>
Date:   Mon Sep 4 12:18:51 2023 +0530

    Awaits fix MultiClusterRepoAccessIT.testConcurrentDeleteFromOtherCluster

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit bc4a134
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Mon Sep 4 12:16:23 2023 +0530

    comparing only max seq no on replicas with primary . Avoid comparing global and local ckp

commit 4437109
Author: Ashish Singh <ssashish@amazon.com>
Date:   Mon Sep 4 12:01:19 2023 +0530

    Fix SuggestSearchIT.testSuggestWithManyCandidates() test

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit 892d78a
Author: Sachin Kale <kalsac@amazon.com>
Date:   Mon Sep 4 11:49:06 2023 +0530

    Fix BlobStoreIncrementalityIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 6c2d70a
Author: Ashish Singh <ssashish@amazon.com>
Date:   Mon Sep 4 11:36:31 2023 +0530

    Fix QueryRescorerIT.testEquivalence() test

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit 2a89345
Author: Sachin Kale <kalsac@amazon.com>
Date:   Mon Sep 4 10:52:18 2023 +0530

    Fix SegmentReplicationStatsIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 34e4191
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sun Sep 3 18:50:51 2023 +0530

    Fix SearchTimeoutIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 07b1296
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sun Sep 3 18:05:25 2023 +0530

    Fix BlobStoreIncrementalityIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 3ec0d9a
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sun Sep 3 17:11:34 2023 +0530

    Mute SegmentReplicationPressureIT and SegmentReplicationWithRemoteStorePressureIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit f09d6ed
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sun Sep 3 16:36:49 2023 +0530

    test

commit f7a8bdd
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sun Sep 3 15:51:34 2023 +0530

    Skipping TruncatedRecoveryIT as we sync segments once from remote store and download all data for this test case

commit 49ce212
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sun Sep 3 14:55:41 2023 +0530

    test

commit 0ec5189
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sun Sep 3 14:02:21 2023 +0530

    omitting seg rep cluster setting it

commit c7df464
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sun Sep 3 13:20:48 2023 +0530

    updates

commit a5803ea
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sun Sep 3 12:33:50 2023 +0530

    Fix too many open files in PartitionedRoutingIT by reducing number of docs

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 2fc1ca4
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sun Sep 3 09:44:11 2023 +0530

    AwaitsFix 1 shallow test in CloneSnapshotIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit c086764
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sun Sep 3 09:42:36 2023 +0530

    AwaitsFix 2 shallow tests in SnapshotStatusApisIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit 6a7d078
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sun Sep 3 09:37:36 2023 +0530

    AwaitsFix testReuseInFileBasedPeerRecovery in RecoveryFromGatewayIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit 8ef7368
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sun Sep 3 00:42:19 2023 +0530

    test

commit 29f5de5
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sun Sep 3 00:12:07 2023 +0530

    update

commit eefca84
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 23:39:10 2023 +0530

    test

commit c148ffc
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 22:57:52 2023 +0530

    test

commit b2eeda9
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 22:18:27 2023 +0530

    test

commit 59a0120
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 22:16:40 2023 +0530

    test

commit 20df770
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sat Sep 2 21:29:44 2023 +0530

    Fix ClusterShardLimitIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit b1c0bce
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sat Sep 2 21:22:15 2023 +0530

    Removing static to fix BooleanTermsIT  and DerivativeIT

commit 136f9dc
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 21:24:09 2023 +0530

    Fix DiskThresholdDeciderIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 5b7af05
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 21:24:06 2023 +0530

    test

commit 83224fa
Merge: eb37566 3d780c8
Author: Bukhtawar Khan <bukhtawar7152@gmail.com>
Date:   Sat Sep 2 21:09:52 2023 +0530

    Merge pull request opensearch-project#153 from Bukhtawar/remote-store-enabled-its

    Fixup for SegrepReplicationRelocationIT

commit eb37566
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 21:09:07 2023 +0530

    Fix SegmentReplicationAllocationIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 3d780c8
Merge: 5dc0e3f 7e94f98
Author: Bukhtawar Khan <bukhtawar7152@gmail.com>
Date:   Sat Sep 2 21:09:04 2023 +0530

    Merge branch 'remote-store-enabled-its' into remote-store-enabled-its

commit 5dc0e3f
Author: Bukhtawar Khan <bukhtawa@amazon.com>
Date:   Sat Sep 2 21:04:32 2023 +0530

    Fixup for SegrepReplicationRelocationIT

    Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>

commit 7e94f98
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sat Sep 2 20:47:25 2023 +0530

    Adding isRemoteStoreEnabled and await fix relocation IT

commit f17ddf1
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sat Sep 2 19:53:53 2023 +0530

    Awaits fix testSimplePreference in SearchPreferenceIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit daa07c4
Merge: eeecea6 393a7af
Author: Bukhtawar Khan <bukhtawar7152@gmail.com>
Date:   Sat Sep 2 18:33:58 2023 +0530

    Merge pull request opensearch-project#152 from Bukhtawar/remote-store-enabled-its

    Change action names to make tests work forcefully

commit 393a7af
Author: Bukhtawar Khan <bukhtawa@amazon.com>
Date:   Sat Sep 2 18:32:58 2023 +0530

    Change action names to make tests work forcefully

    Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>

commit eeecea6
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sat Sep 2 18:30:39 2023 +0530

    Awaits fix testNodesOnlyRandom in SearchPreferenceIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit 499c2cd
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sat Sep 2 18:29:01 2023 +0530

    Awaits fix testNoPreferenceRandom in SearchPreferenceIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit e7bcc8c
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sat Sep 2 18:26:09 2023 +0530

    Awaits fix RemoteStoreForceMergeIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit 299df96
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 18:21:23 2023 +0530

    push

commit 741afb8
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 18:00:13 2023 +0530

    update

commit 6ab5add
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sat Sep 2 17:58:02 2023 +0530

    Fix testZeroRemoteStoreStatsOnNonRemoteStoreIndex in IndexStatsIT

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit d945660
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 17:56:41 2023 +0530

    updates

commit c9acbbb
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 17:35:55 2023 +0530

    Fix MedianAbsoluteDeviationIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 3e84751
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sat Sep 2 16:37:28 2023 +0530

    Fix all tests in RemoveCorruptedShardDataCommandIT - 10 iters passed

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit f77c722
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sat Sep 2 16:29:36 2023 +0530

    ignoring test failing in segrep as well

commit d08aadb
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 16:05:29 2023 +0530

    Mute SegmentReplicationSnapshotIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit fd7451c
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 15:52:27 2023 +0530

    Fix ShardIndexingPressureSettingsIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit c513180
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 15:36:24 2023 +0530

    Fix IndexingPressureIT and RemoteIndexSnapshotStatusApiIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 27e1d96
Merge: 27015e4 09e9ffa
Author: Bukhtawar Khan <bukhtawar7152@gmail.com>
Date:   Sat Sep 2 15:33:00 2023 +0530

    Merge pull request opensearch-project#151 from Bukhtawar/remote-store-enabled-its

    Empty replication leases on replica

commit 09e9ffa
Author: Bukhtawar Khan <bukhtawa@amazon.com>
Date:   Sat Sep 2 15:31:54 2023 +0530

    Empty replication leases on replica

    Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>

commit 27015e4
Author: Ashish Singh <ssashish@amazon.com>
Date:   Sat Sep 2 15:21:46 2023 +0530

    Fix AdjacencyMatrixIT - no failures in 10 iters

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit f64c4fa
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 15:20:44 2023 +0530

    Fix FiltersIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 9bea58d
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 14:41:48 2023 +0530

    Fix ConcurrentSearchTasksIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 907ca18
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 14:21:19 2023 +0530

    Fix AbstractTasksIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 268e711
Merge: e805cec 11fd9d9
Author: Bukhtawar Khan <bukhtawar7152@gmail.com>
Date:   Sat Sep 2 13:31:10 2023 +0530

    Merge pull request opensearch-project#150 from Bukhtawar/remote-store-enabled-its

    Disabling tests as write thread pool block on replica doesn't impact …

commit 11fd9d9
Author: Bukhtawar Khan <bukhtawa@amazon.com>
Date:   Sat Sep 2 13:30:25 2023 +0530

    Disabling tests as write thread pool block on replica doesn't impact primary term validation on transport worker

    Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>

commit e805cec
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sat Sep 2 12:47:12 2023 +0530

    ignoring WRR and IndexRecoveryIT

    Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

commit e971bc1
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sat Sep 2 12:39:08 2023 +0530

    ignoring tests which should fail with remote store

commit c5150b0
Merge: 09e08e3 6f60931
Author: Bukhtawar Khan <bukhtawar7152@gmail.com>
Date:   Sat Sep 2 11:55:37 2023 +0530

    Merge pull request opensearch-project#149 from Bukhtawar/remote-store-enabled-its

    Fix up searchable snapshot to not sync from remote

commit 6f60931
Author: Bukhtawar Khan <bukhtawa@amazon.com>
Date:   Sat Sep 2 11:52:38 2023 +0530

    Fix searchable snapshot to not sync from remote

    Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>

commit 09e08e3
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 11:25:38 2023 +0530

    Fix MedianAbsoluteDeviationIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit ec30cb6
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sat Sep 2 11:23:12 2023 +0530

    Setting primary preference in Rest Request and clients

commit b2e2c86
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 11:10:26 2023 +0530

    update

commit 2f85d03
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Sat Sep 2 10:57:55 2023 +0530

    using setUpTest instead of setupSuiteScopeCluster

commit 0af7d70
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Sat Sep 2 10:06:24 2023 +0530

    update

commit f8cf4c4
Author: Sachin Kale <kalsac@amazon.com>
Date:   Sat Sep 2 00:52:12 2023 +0530

    Fix RepositoriesIT

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 9fdcb39
Author: Sachin Kale <kalsac@amazon.com>
Date:   Fri Sep 1 23:07:08 2023 +0530

    Fix bunch of tests that were still using SuiteScopeTestCase

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 0f29caf
Merge: 998cc58 4bdc7c1
Author: Arpit Bandejiya <abandeji@amazon.com>
Date:   Fri Sep 1 18:06:20 2023 +0530

    Merge branch 'remote-store-enabled-its' of github.com:sachinpkale/OpenSearch into remote-store-enabled-its

commit 998cc58
Author: Arpit Bandejiya <abandeji@amazon.com>
Date:   Fri Sep 1 18:05:55 2023 +0530

    Fix the GlobalCheckpointSyncIT

commit 4bdc7c1
Author: Sachin Kale <kalsac@amazon.com>
Date:   Fri Sep 1 17:34:04 2023 +0530

    Enforce test scope for all the test with SuiteScopeTestCase

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 10dc127
Author: Ranjith Ramachandra <ramaran@amazon.com>
Date:   Fri Sep 1 16:58:28 2023 +0530

    updated

commit 6144fc8
Author: Gaurav Bafna <gbbafna@amazon.com>
Date:   Fri Sep 1 17:18:32 2023 +0530

    Fixing cluster state

commit 215b936
Author: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Date:   Fri Sep 1 17:07:15 2023 +0530

    Adding assertBusy to SearchSliceIT

    Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>

commit 6c28a4e
Author: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Date:   Fri Sep 1 16:24:32 2023 +0530

    Muting tests not applicable to remote store

    Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>

commit 3be1f3d
Author: Sachin Kale <kalsac@amazon.com>
Date:   Fri Sep 1 14:59:44 2023 +0530

    Do not wipe cluster at all

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 12775c3
Author: Sachin Kale <kalsac@amazon.com>
Date:   Fri Sep 1 14:48:42 2023 +0530

    Few fixes

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 98322fa
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Fri Sep 1 02:59:54 2023 +0530

    Removing unnecessary diffs

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit 3262e78
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Fri Sep 1 00:30:35 2023 +0530

    Removing remote store specific cluster settings instead rely on node attributes, fixed UTs and ITs

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit d0af9e3
Author: Ashish Singh <ssashish@amazon.com>
Date:   Fri Sep 1 13:16:55 2023 +0530

    Remove repository wipe

    Signed-off-by: Ashish Singh <ssashish@amazon.com>

commit dddf695
Author: Sachin Kale <kalsac@amazon.com>
Date:   Fri Sep 1 11:32:14 2023 +0530

    Fix AbstractMultiClustersTestCase

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 7f06e8e
Author: Sachin Kale <kalsac@amazon.com>
Date:   Fri Sep 1 11:18:50 2023 +0530

    Make all tests run in TEST scope

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 55bd2ac
Author: Sachin Kale <kalsac@amazon.com>
Date:   Fri Sep 1 09:29:20 2023 +0530

    Change default scope to TEST

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit b7534f5
Author: Sachin Kale <kalsac@amazon.com>
Date:   Thu Aug 31 21:04:21 2023 +0530

    Fixing bunch of tests

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 3b93358
Author: Sachin Kale <kalsac@amazon.com>
Date:   Thu Aug 31 11:03:10 2023 +0530

    Enable remote store for all integ tests

    Signed-off-by: Sachin Kale <kalsac@amazon.com>

commit 228cf7b
Author: Marc Handalian <handalm@amazon.com>
Date:   Tue Aug 29 22:55:14 2023 -0700

    Mock implementation.

    Signed-off-by: Marc Handalian <handalm@amazon.com>

commit 6919141
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Wed Aug 30 20:32:10 2023 +0530

    Fixing Additional Tests, there might still be some flaky ones

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit d0c2b5b
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Wed Aug 30 14:33:36 2023 +0530

    Removing verifyLocally and move to existing verify methods. If the repository is a system repository only local verification will happen

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit c94713e
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Tue Aug 29 23:56:52 2023 +0530

    Fixing ITs

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit a227d20
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Tue Aug 29 17:02:58 2023 +0530

    Updating/Fixing tests

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit bc0e562
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Mon Aug 28 19:42:26 2023 +0530

    Introducing verifylocally to perform verification without cluster being formed such that a node is able to connect to connect and has necessary permissions

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit 23cc00f
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Mon Aug 28 14:33:41 2023 +0530

    Addressed few comments, updated javadocs and added verify logic to be updated once system repo pr is merged

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit 40f85c7
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Sun Aug 27 18:10:22 2023 +0530

    Updating REMOTE_STORE_COMPATIBILITY_MODE_SETTING value enum javadoc

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit d07c6f6
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Sun Aug 27 17:11:34 2023 +0530

    Updating CompatibilityMode enum

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit 496c00d
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Sun Aug 27 16:55:56 2023 +0530

    Fixing tests

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit 2956dd1
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Sun Aug 27 13:04:09 2023 +0530

    Using CoundDownLatch

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit d97cc06
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Sun Aug 27 02:53:24 2023 +0530

    Updating javadoc and RepoRegistration IT

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit a7316a8
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Sun Aug 27 02:29:08 2023 +0530

    Fixing repository verification logic

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit f1409b1
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Sat Aug 26 22:10:39 2023 +0530

    Code changes to do the repository verification at the time of node bootstrap.

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

commit d6c7866
Author: Dharmesh 💤 <sdharms@amazon.com>
Date:   Sat Aug 26 14:20:01 2023 +0530

    [Remote Store] Changes to perform repository registration during bootstrap via node attributes.

    Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setiah setiah setiah approved these changes

@nknize nknize Awaiting requested review from nknize nknize is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peternied @chloe-zh @stockholmux @setiah