-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "master" terminology in code comments, and internal variable, method and class names #1548
Closed
12 tasks done
Labels
enhancement
Enhancement or improvement to existing feature or request
v2.1.0
Issues and PRs related to version 2.1.0
Comments
tlfeng
added
enhancement
Enhancement or improvement to existing feature or request
untriaged
labels
Nov 15, 2021
5 tasks
5 tasks
This was referenced Mar 17, 2022
5 tasks
tlfeng
added
v2.1.0
Issues and PRs related to version 2.1.0
and removed
v2.0.0
Version 2.0.0
labels
Apr 12, 2022
This was referenced Apr 27, 2022
5 tasks
This was referenced May 11, 2022
5 tasks
Nearly all the usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhancement or improvement to existing feature or request
v2.1.0
Issues and PRs related to version 2.1.0
Is your feature request related to a problem? Please describe.
Replace "master" terminology in the code base, but only the places that won't impact the backwards compatibility.
A part of #472
Describe the solution you'd like
Replace all the "master" terminology in the following location:
Any APIs or configurations will not be impacted.
Directories:
The issue to track "master" word in Log messages: #2539
There are 3 usages with "master" terminology in
server
directory that need to be replaced in caution:_BECOME_MASTER_TASK_
https://github.com/opensearch-project/OpenSearch/blob/1.3.1/server/src/main/java/org/opensearch/cluster/coordination/JoinTaskExecutor.java#L107 (PR: Rename BecomeMasterTask to BecomeClusterManagerTask in JoinTaskExecutor #3099)_must_join_elected_master_
https://github.com/opensearch-project/OpenSearch/blob/1.3.1/server/src/main/java/org/opensearch/cluster/coordination/CoordinationMetadata.java#L354 (PR: Rename reserved node id '_must_join_elected_master_' to '_must_join_elected_cluster_manager_' that used by in DetachClusterCommand #3116)no master
https://github.com/opensearch-project/OpenSearch/blob/1.3.1/server/src/main/java/org/opensearch/cluster/coordination/NoMasterBlockService.java#L48 (PR: Rename ClusterBlock description 'no master' to 'no cluster-manager' #3133)Describe alternatives you've considered
None.
Additional context
None.
The text was updated successfully, but these errors were encountered: