Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Replace internal usages of 'master' term in 'server/src/main' directory (#2519) #3165

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented May 3, 2022

Description

Backport PR #2519 to 2.x branch.

  • Replace the non-inclusive terminology "master" with "cluster manager" in code comments, internal variable/method/class names, in server/src/main directory.
  • Backwards compatibility is not impacted.

Replacement rules:

  • master -> cluster_manager or clusterManager (variable name) or cluster-manager (code comment)
  • Master -> ClusterManager

Issues Resolved

A part of #1548

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng requested a review from a team as a code owner May 3, 2022 18:44
@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0 labels May 3, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 499cb89268b52904f4bb934d248616e777dbc14a
Log 4955

Reports 4955

@tlfeng tlfeng force-pushed the 2.x-replace-master-internal-server-main branch from 499cb89 to 32ef2c8 Compare May 3, 2022 22:00
@tlfeng tlfeng added backport 2.0 Backport to 2.0 branch v2.0.0 Version 2.0.0 and removed v2.0.0 Version 2.0.0 backport 2.0 Backport to 2.0 branch labels May 3, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 32ef2c8846d80be1e6245382a1227022183b1c66
Log 4969

Reports 4969

@tlfeng tlfeng force-pushed the 2.x-replace-master-internal-server-main branch from 32ef2c8 to eb041f0 Compare May 3, 2022 22:46
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success eb041f0
Log 4974

Reports 4974

@dblock dblock merged commit acbcf76 into opensearch-project:2.x May 4, 2022
@tlfeng tlfeng deleted the 2.x-replace-master-internal-server-main branch May 4, 2022 21:04
@tlfeng
Copy link
Collaborator Author

tlfeng commented May 4, 2022

@dblock Thank you so much for your review! 🏆 👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants