Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Replace internal usages of 'master' term in 'client' directory #3284

Merged
merged 1 commit into from
May 11, 2022
Merged

[2.x] Replace internal usages of 'master' term in 'client' directory #3284

merged 1 commit into from
May 11, 2022

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented May 11, 2022

Description

Backport commit dd7add2 / PR #3088 to 2.x branch.

  • Replace the non-inclusive terminology "master" with "cluster manager" in code comments, internal variable and method names, in client directory.
  • Backwards compatibility is not impacted.

Replacement rules:

  • master -> cluster_manager or clusterManager (variable name) or cluster-manager (code comment)
  • Master -> ClusterManager

Issues Resolved

A part of #1548

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Replace internal usages of 'master' term in 'client' directory (opens…
c024c3a 
…earch-project#3088)

* Replace internal usages of 'master' term in 'client' directory

Signed-off-by: Tianli Feng <ftianli@amazon.com>

* Add a uni test for NodeSelector to test deprecated master role

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng requested review from a team and reta as code owners May 11, 2022 06:38
@tlfeng tlfeng changed the title [2.x] client replace master int [2.x] Replace internal usages of 'master' term in 'client' directory May 11, 2022
@tlfeng tlfeng changed the base branch from main to 2.x May 11, 2022 06:38
@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0 labels May 11, 2022
@tlfeng tlfeng mentioned this pull request May 11, 2022
Merged
5 tasks
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success c024c3a
Log 5227

Reports 5227

@dblock dblock merged commit bdefab0 into opensearch-project:2.x May 11, 2022
@tlfeng tlfeng deleted the 2.x-client-replace-master-int branch May 11, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlfeng @opensearch-ci-bot @dblock