Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance debug, trace & info logs for remote store flows #10182

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Sep 22, 2023

Description

This PR improves the logging by adding debug, info and trace logs.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Compatibility status:

Checks if related components are compatible with change 976a659

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@ashking94 ashking94 self-assigned this Sep 22, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94 ashking94 force-pushed the remote-logging branch 2 times, most recently from 192e3ef to 2dcc471 Compare September 22, 2023 17:37
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.CloneSnapshotIT.testCloneShallowSnapshotIndex

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #10182 (976a659) into main (a8969cb) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 84.53%.

@@             Coverage Diff              @@
##               main   #10182      +/-   ##
============================================
- Coverage     71.11%   71.11%   -0.01%     
- Complexity    58188    58218      +30     
============================================
  Files          4830     4830              
  Lines        274440   274494      +54     
  Branches      39993    39999       +6     
============================================
+ Hits         195175   195197      +22     
- Misses        62897    62900       +3     
- Partials      16368    16397      +29     
Files Coverage Δ
...src/main/java/org/opensearch/core/index/Index.java 100.00% <ø> (ø)
...rch/index/remote/RemoteSegmentTransferTracker.java 81.10% <100.00%> (+0.17%) ⬆️
...index/shard/CloseableRetryableRefreshListener.java 81.03% <100.00%> (+0.67%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 69.76% <100.00%> (+0.89%) ⬆️
...java/org/opensearch/index/shard/StoreRecovery.java 56.95% <ø> (+0.14%) ⬆️
...earch/index/store/RemoteSegmentStoreDirectory.java 89.67% <100.00%> (+0.26%) ⬆️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 92.30% <100.00%> (ø)
...search/index/translog/InternalTranslogManager.java 72.22% <100.00%> (+0.19%) ⬆️
...rg/opensearch/index/translog/RemoteFsTranslog.java 71.49% <100.00%> (+0.56%) ⬆️
...dex/translog/transfer/TranslogTransferManager.java 72.33% <100.00%> (-0.69%) ⬇️
... and 9 more

... and 459 files with indirect coverage changes

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

Flaky test - #10154

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sachinpkale sachinpkale merged commit e617da3 into opensearch-project:main Sep 26, 2023
13 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Sep 26, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10182-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e617da375740065a3878cea093ac8eadaf2a821a
# Push it to GitHub
git push --set-upstream origin backport/backport-10182-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10182-to-2.x.

ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Sep 26, 2023
…roject#10182)

* Enhance debug, trace & info logs for remote store flows

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add shardId to logger and more logs

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Rename unkwown index name to _unknown_

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94
Copy link
Member Author

Auto backport failed. Raised manual backport - #10237. Conflicts came up due to #9710 not being backported.

ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Sep 27, 2023
…roject#10182)

* Enhance debug, trace & info logs for remote store flows

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add shardId to logger and more logs

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Rename unkwown index name to _unknown_

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
sachinpkale pushed a commit that referenced this pull request Sep 27, 2023
#10182) (#10237)

* Enhance debug, trace & info logs for remote store flows (#10182)

* Enhance debug, trace & info logs for remote store flows

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add shardId to logger and more logs

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Rename unkwown index name to _unknown_

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
…roject#10182)

* Enhance debug, trace & info logs for remote store flows

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add shardId to logger and more logs

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Rename unkwown index name to _unknown_

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…roject#10182)

* Enhance debug, trace & info logs for remote store flows

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add shardId to logger and more logs

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Rename unkwown index name to _unknown_

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants