-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance debug, trace & info logs for remote store flows #10182
Enhance debug, trace & info logs for remote store flows #10182
Conversation
Compatibility status:Checks if related components are compatible with change 976a659 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git] |
Gradle Check (Jenkins) Run Completed with:
|
0659964
to
d254c51
Compare
Gradle Check (Jenkins) Run Completed with:
|
192e3ef
to
2dcc471
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
2dcc471
to
edf315a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10182 +/- ##
============================================
- Coverage 71.11% 71.11% -0.01%
- Complexity 58188 58218 +30
============================================
Files 4830 4830
Lines 274440 274494 +54
Branches 39993 39999 +6
============================================
+ Hits 195175 195197 +22
- Misses 62897 62900 +3
- Partials 16368 16397 +29
|
server/src/main/java/org/opensearch/index/remote/RemoteSegmentTransferTracker.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
Show resolved
Hide resolved
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
edf315a
to
b8840f2
Compare
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Flaky test - #10154 |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10182-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e617da375740065a3878cea093ac8eadaf2a821a
# Push it to GitHub
git push --set-upstream origin backport/backport-10182-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…roject#10182) * Enhance debug, trace & info logs for remote store flows Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add shardId to logger and more logs Signed-off-by: Ashish Singh <ssashish@amazon.com> * Rename unkwown index name to _unknown_ Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…roject#10182) * Enhance debug, trace & info logs for remote store flows Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add shardId to logger and more logs Signed-off-by: Ashish Singh <ssashish@amazon.com> * Rename unkwown index name to _unknown_ Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
#10182) (#10237) * Enhance debug, trace & info logs for remote store flows (#10182) * Enhance debug, trace & info logs for remote store flows Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add shardId to logger and more logs Signed-off-by: Ashish Singh <ssashish@amazon.com> * Rename unkwown index name to _unknown_ Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…roject#10182) * Enhance debug, trace & info logs for remote store flows Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add shardId to logger and more logs Signed-off-by: Ashish Singh <ssashish@amazon.com> * Rename unkwown index name to _unknown_ Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…roject#10182) * Enhance debug, trace & info logs for remote store flows Signed-off-by: Ashish Singh <ssashish@amazon.com> * Add shardId to logger and more logs Signed-off-by: Ashish Singh <ssashish@amazon.com> * Rename unkwown index name to _unknown_ Signed-off-by: Ashish Singh <ssashish@amazon.com> * Empty-Commit Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This PR improves the logging by adding debug, info and trace logs.
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.