Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enhance debug, trace & info logs for remote store flows (#10182) #10237

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

ashking94
Copy link
Member

Backports e617da3 from #10182

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Compatibility status:

Checks if related components are compatible with change bde1dff

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…roject#10182)

* Enhance debug, trace & info logs for remote store flows

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add shardId to logger and more logs

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Rename unkwown index name to _unknown_

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDeleteOperations

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #10237 (bde1dff) into 2.x (ecb3ed5) will increase coverage by 0.00%.
Report is 3 commits behind head on 2.x.
The diff coverage is 86.27%.

@@            Coverage Diff             @@
##                2.x   #10237    +/-   ##
==========================================
  Coverage     70.74%   70.75%            
+ Complexity    58276    58261    -15     
==========================================
  Files          4814     4814            
  Lines        275430   275523    +93     
  Branches      40493    40501     +8     
==========================================
+ Hits         194853   194940    +87     
+ Misses        63973    63878    -95     
- Partials      16604    16705   +101     
Files Coverage Δ
...src/main/java/org/opensearch/core/index/Index.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/index/IndexService.java 75.59% <100.00%> (ø)
...rch/index/remote/RemoteSegmentTransferTracker.java 81.10% <100.00%> (+0.17%) ⬆️
...index/shard/CloseableRetryableRefreshListener.java 81.03% <100.00%> (+0.67%) ⬆️
...java/org/opensearch/index/shard/StoreRecovery.java 56.95% <ø> (+0.67%) ⬆️
...earch/index/store/RemoteSegmentStoreDirectory.java 89.67% <100.00%> (-0.40%) ⬇️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 92.30% <100.00%> (ø)
...rc/main/java/org/opensearch/index/store/Store.java 81.71% <100.00%> (+0.33%) ⬆️
...search/index/translog/InternalTranslogManager.java 66.66% <100.00%> (-4.67%) ⬇️
...rg/opensearch/index/translog/RemoteFsTranslog.java 70.53% <100.00%> (-0.41%) ⬇️
... and 12 more

... and 458 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 6e4a11e into opensearch-project:2.x Sep 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants