Fix system_repository setting is restored after cluster metadata recovery from local disk

[linuxpi]

Description

• system_repository setting value was removed during toXContent call of RepositoriesMetadata
• This was done to remove this setting from GetRepositoies API call
• But toXContent also serializes data for persistent local disk state.
• So during cluster state recovery from local disk, this system_repository setting was lost.
• This change ensures system_respository setting is persisted in local disk state

Related Issues

Resolves #10555

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change b3860c3

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/27591/
• CommitID: 6ce854b

[codecov]

Codecov Report

Merging #10556 (b3860c3) into main (a54108c) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 36.36%.

@@             Coverage Diff              @@
##               main   #10556      +/-   ##
============================================
- Coverage     71.18%   71.17%   -0.01%     
- Complexity    58407    58411       +4     
============================================
  Files          4844     4845       +1     
  Lines        275306   275312       +6     
  Branches      40086    40086              
============================================
- Hits         195969   195955      -14     
- Misses        62948    62992      +44     
+ Partials      16389    16365      -24     

Files	Coverage Δ
...ibs/core/src/main/java/org/opensearch/Version.java	78.09% <100.00%> (ø)
...in/java/org/opensearch/index/shard/IndexShard.java	69.47% <ø> (-0.47%)	⬇️
...ster/repositories/get/GetRepositoriesResponse.java	56.25% <0.00%> (ø)
...nsearch/cluster/metadata/RepositoriesMetadata.java	75.00% <0.00%> (-1.93%)	⬇️
...dex/translog/transfer/TranslogTransferManager.java	79.37% <50.00%> (ø)
...search/index/translog/InternalTranslogManager.java	66.43% <0.00%> (-0.93%)	⬇️
...anslog/transfer/TranslogUploadFailedException.java	50.00% <50.00%> (ø)

... and 436 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/27617/
• CommitID: 5b8be12
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[gbbafna]

    org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testReplicationAfterPrimaryRefreshAndFlush
    org.opensearch.search.aggregations.metrics.CardinalityWithRequestBreakerIT.testRequestBreaker {p0={"search.concurrent_segment_search.enabled":"true"}}

Unrelated failures .

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/27626/
• CommitID: 3e39eb0
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/27712/
• CommitID: 112f624
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/27718/
• CommitID: 13a08e7
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/27721/
• CommitID: 112f624
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/27729/
• CommitID: 3e39eb0
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

• URL: https://build.ci.opensearch.org/job/gradle-check/27731/
• CommitID: b3860c3
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.