Add plumbing logic for IndexingPressureService in Transport Actions. #1113
+591
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saurabh Singh <sisurab@amazon.com>
|
✅ DCO Check Passed bd2fda3 |
|
✅ Gradle Wrapper Validation success bd2fda3 |
|
✅ Gradle Precommit success bd2fda3 |
This was referenced Aug 23, 2021
Bukhtawar
reviewed
Aug 23, 2021
Comment on lines
+28
to
+40
| public Releasable markCoordinatingOperationStarted(long bytes, boolean forceExecution) { | ||
| if (isShardIndexingPressureEnabled() == false) { | ||
| return shardIndexingPressure.markCoordinatingOperationStarted(bytes, forceExecution); | ||
| } else { | ||
| return () -> {}; | ||
| } | ||
| } | ||
|
|
||
| public Releasable markCoordinatingOperationStarted(ShardId shardId, long bytes, boolean forceExecution) { | ||
| if (isShardIndexingPressureEnabled()) { | ||
| return shardIndexingPressure.markCoordinatingOperationStarted(shardId, bytes, forceExecution); | ||
| } else { | ||
| return shardIndexingPressure.markCoordinatingOperationStarted(bytes, forceExecution); | ||
| return () -> {}; |
There was a problem hiding this comment.
Methods look pretty confusing. On one occasion for isShardIndexingPressureEnabled we return empty while in another case we invoke ShardIndexingPressure
There was a problem hiding this comment.
When isShardIndexingPressureEnabled is enabled, which implies we are doing Shard level accounting, then shardIndexingPressure.markCoordinatingOperationStarted(shardId, bytes, forceExecution) with attribute shardId is invoked.
For the other case when, when isShardIndexingPressureEnabled is disabled, which implies we are only doing Node level accounting (and not Shard level), then shardIndexingPressure.markCoordinatingOperationStarted(bytes, forceExecution) without attribute shardId is invoked.
We could have club these but then, even for Node level accounting caller would need to unnecessarily pass shardId or null at plumbing point. This way caller can chose to call markCoordinatingOperationStarted based on what attributes it has, without worrying about if ShardIndexingPressure is enabled or disabled.
Bukhtawar
approved these changes
Aug 26, 2021
shwetathareja
merged commit 73d1680
into
opensearch-project:feature/478_indexBackPressure
adnapibar
pushed a commit
that referenced
this pull request
Sep 15, 2021
…1113) Signed-off-by: Saurabh Singh <sisurab@amazon.com>
adnapibar
pushed a commit
that referenced
this pull request
Sep 15, 2021
…1113) Signed-off-by: Saurabh Singh <sisurab@amazon.com>
5 tasks
getsaurabh02
added a commit
to getsaurabh02/OpenSearch
that referenced
this pull request
Oct 6, 2021
…pensearch-project#1113) Signed-off-by: Saurabh Singh <sisurab@amazon.com>
5 tasks
adnapibar
added a commit
that referenced
this pull request
Oct 7, 2021
Shard level indexing pressure improves the current Indexing Pressure framework which performs memory accounting at node level and rejects the requests. This takes a step further to have rejections based on the memory accounting at shard level along with other key performance factors like throughput and last successful requests. **Key features** - Granular tracking of indexing tasks performance, at every shard level, for each node role i.e. coordinator, primary and replica. - Smarter rejections by discarding the requests intended only for problematic index or shard, while still allowing others to continue (fairness in rejection). - Rejections thresholds governed by combination of configurable parameters (such as memory limits on node) and dynamic parameters (such as latency increase, throughput degradation). - Node level and shard level indexing pressure statistics exposed through stats api. - Integration of Indexing pressure stats with Plugins for for metric visibility and auto-tuning in future. - Control knobs to tune to the key performance thresholds which control rejections, to address any specific requirement or issues. - Control knobs to run the feature in shadow-mode or enforced-mode. In shadow-mode only internal rejection breakdown metrics will be published while no actual rejections will be performed. The changes were divided into small manageable chunks as part of the following PRs against a feature branch. - Add Shard Indexing Pressure Settings. #716 - Add Shard Indexing Pressure Tracker. #717 - Refactor IndexingPressure to allow extension. #718 - Add Shard Indexing Pressure Store #838 - Add Shard Indexing Pressure Memory Manager #945 - Add ShardIndexingPressure framework level construct and Stats #1015 - Add Indexing Pressure Service which acts as orchestrator for IP #1084 - Add plumbing logic for IndexingPressureService in Transport Actions. #1113 - Add shard indexing pressure metric/stats via rest end point. #1171 - Add shard indexing pressure integration tests. #1198 Signed-off-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com>
getsaurabh02
added a commit
to getsaurabh02/OpenSearch
that referenced
this pull request
Oct 7, 2021
Shard level indexing pressure improves the current Indexing Pressure framework which performs memory accounting at node level and rejects the requests. This takes a step further to have rejections based on the memory accounting at shard level along with other key performance factors like throughput and last successful requests. **Key features** - Granular tracking of indexing tasks performance, at every shard level, for each node role i.e. coordinator, primary and replica. - Smarter rejections by discarding the requests intended only for problematic index or shard, while still allowing others to continue (fairness in rejection). - Rejections thresholds governed by combination of configurable parameters (such as memory limits on node) and dynamic parameters (such as latency increase, throughput degradation). - Node level and shard level indexing pressure statistics exposed through stats api. - Integration of Indexing pressure stats with Plugins for for metric visibility and auto-tuning in future. - Control knobs to tune to the key performance thresholds which control rejections, to address any specific requirement or issues. - Control knobs to run the feature in shadow-mode or enforced-mode. In shadow-mode only internal rejection breakdown metrics will be published while no actual rejections will be performed. The changes were divided into small manageable chunks as part of the following PRs against a feature branch. - Add Shard Indexing Pressure Settings. opensearch-project#716 - Add Shard Indexing Pressure Tracker. opensearch-project#717 - Refactor IndexingPressure to allow extension. opensearch-project#718 - Add Shard Indexing Pressure Store opensearch-project#838 - Add Shard Indexing Pressure Memory Manager opensearch-project#945 - Add ShardIndexingPressure framework level construct and Stats opensearch-project#1015 - Add Indexing Pressure Service which acts as orchestrator for IP opensearch-project#1084 - Add plumbing logic for IndexingPressureService in Transport Actions. opensearch-project#1113 - Add shard indexing pressure metric/stats via rest end point. opensearch-project#1171 - Add shard indexing pressure integration tests. opensearch-project#1198 Signed-off-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com>
5 tasks
tlfeng
pushed a commit
that referenced
this pull request
Oct 11, 2021
Shard level indexing pressure improves the current Indexing Pressure framework which performs memory accounting at node level and rejects the requests. This takes a step further to have rejections based on the memory accounting at shard level along with other key performance factors like throughput and last successful requests. **Key features** - Granular tracking of indexing tasks performance, at every shard level, for each node role i.e. coordinator, primary and replica. - Smarter rejections by discarding the requests intended only for problematic index or shard, while still allowing others to continue (fairness in rejection). - Rejections thresholds governed by combination of configurable parameters (such as memory limits on node) and dynamic parameters (such as latency increase, throughput degradation). - Node level and shard level indexing pressure statistics exposed through stats api. - Integration of Indexing pressure stats with Plugins for for metric visibility and auto-tuning in future. - Control knobs to tune to the key performance thresholds which control rejections, to address any specific requirement or issues. - Control knobs to run the feature in shadow-mode or enforced-mode. In shadow-mode only internal rejection breakdown metrics will be published while no actual rejections will be performed. The changes were divided into small manageable chunks as part of the following PRs against a feature branch. - Add Shard Indexing Pressure Settings. #716 - Add Shard Indexing Pressure Tracker. #717 - Refactor IndexingPressure to allow extension. #718 - Add Shard Indexing Pressure Store #838 - Add Shard Indexing Pressure Memory Manager #945 - Add ShardIndexingPressure framework level construct and Stats #1015 - Add Indexing Pressure Service which acts as orchestrator for IP #1084 - Add plumbing logic for IndexingPressureService in Transport Actions. #1113 - Add shard indexing pressure metric/stats via rest end point. #1171 - Add shard indexing pressure integration tests. #1198 Signed-off-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is next among the planned PRs for Shard Indexing Pressure (#478). It introduces the main integration logic of Indexing Pressure Service with Node and Transport Action classes. These IP Service APIs, will now be called appropriately for during the indexing flow. Multiple tests also updated accordingly.
Signed-off-by: Saurabh Singh sisurab@amazon.com
Issues Resolved
Addresses Item 8 of #478
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.