Shard Indexing Pressure changes to be merged #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-project#716) Signed-off-by: Saurabh Singh <sisurab@amazon.com>
opensearch-project#718) Signed-off-by: Saurabh Singh <sisurab@amazon.com>
…arch-project#717) Signed-off-by: Saurabh Singh <sisurab@amazon.com>
…h-project#838) * Add Shard Indexing Pressure Store (opensearch-project#478) Signed-off-by: Saurabh Singh <sisurab@amazon.com> * Added comments and shard allocation based on compute in hot store. Signed-off-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com>
…pensearch-project#945) It introduces a Memory Manager for Shard Indexing Pressure. It is responsible for increasing and decreasing the allocated shard limit based on incoming requests, and validate the current values against the thresholds. Signed-off-by: Saurabh Singh <sisurab@amazon.com>
…arch-project#1015) * Add ShardIndexingPressure framework level construct and related Stats artefacts. * Test and code refactoring for shard indexing pressure. * Moved the average calculation logic to common memory manager util. * Add wrapper for releasable in ShardIndexingPressure operations. Signed-off-by: Saurabh Singh <sisurab@amazon.com>
… pressure interfaces. (opensearch-project#1084) Signed-off-by: Saurabh Singh <sisurab@amazon.com>
…pensearch-project#1113) Signed-off-by: Saurabh Singh <sisurab@amazon.com>
…rch-project#1171) * Add shard indexing pressure metric/stats via rest end point. Signed-off-by: Saurabh Singh <sisurab@amazon.com>
Signed-off-by: Saurabh Singh <sisurab@amazon.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
getsaurabh02
changed the title
|
✅ DCO Check Passed 67b0be6 |
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success 67b0be6 |
|
start gradle check |
5 tasks
|
✅ Gradle Precommit success 67b0be6 |
tushar-kharbanda72
approved these changes
Oct 7, 2021
tlfeng
approved these changes
Oct 7, 2021
getsaurabh02
added a commit
to getsaurabh02/OpenSearch
that referenced
this pull request
Oct 7, 2021
Shard level indexing pressure improves the current Indexing Pressure framework which performs memory accounting at node level and rejects the requests. This takes a step further to have rejections based on the memory accounting at shard level along with other key performance factors like throughput and last successful requests. **Key features** - Granular tracking of indexing tasks performance, at every shard level, for each node role i.e. coordinator, primary and replica. - Smarter rejections by discarding the requests intended only for problematic index or shard, while still allowing others to continue (fairness in rejection). - Rejections thresholds governed by combination of configurable parameters (such as memory limits on node) and dynamic parameters (such as latency increase, throughput degradation). - Node level and shard level indexing pressure statistics exposed through stats api. - Integration of Indexing pressure stats with Plugins for for metric visibility and auto-tuning in future. - Control knobs to tune to the key performance thresholds which control rejections, to address any specific requirement or issues. - Control knobs to run the feature in shadow-mode or enforced-mode. In shadow-mode only internal rejection breakdown metrics will be published while no actual rejections will be performed. The changes were divided into small manageable chunks as part of the following PRs against a feature branch. - Add Shard Indexing Pressure Settings. opensearch-project#716 - Add Shard Indexing Pressure Tracker. opensearch-project#717 - Refactor IndexingPressure to allow extension. opensearch-project#718 - Add Shard Indexing Pressure Store opensearch-project#838 - Add Shard Indexing Pressure Memory Manager opensearch-project#945 - Add ShardIndexingPressure framework level construct and Stats opensearch-project#1015 - Add Indexing Pressure Service which acts as orchestrator for IP opensearch-project#1084 - Add plumbing logic for IndexingPressureService in Transport Actions. opensearch-project#1113 - Add shard indexing pressure metric/stats via rest end point. opensearch-project#1171 - Add shard indexing pressure integration tests. opensearch-project#1198 Signed-off-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com>
reta
reviewed
Oct 7, 2021
|
|
||
| private final Map<ShardId, ShardIndexingPressureTracker> shardIndexingPressureHotStore = | ||
| ConcurrentCollections.newConcurrentMapWithAggressiveConcurrency(); | ||
| private final Map<ShardId, ShardIndexingPressureTracker> shardIndexingPressureColdStore = new HashMap<>(); |
There was a problem hiding this comment.
@adnapibar I believe shardIndexingPressureColdStore should be using safe concurrent structure or synchronization, much like shardIndexingPressureHotStore, thoughts?
There was a problem hiding this comment.
That was the initial proposal in the Store PR. However we later realised we don't need strong concurrency guarantees on cold store, since ordering/uniqueness of trackers is governed by Hot Store anyways. So we decided to change to it to a regular map.
tlfeng
pushed a commit
that referenced
this pull request
Oct 11, 2021
Shard level indexing pressure improves the current Indexing Pressure framework which performs memory accounting at node level and rejects the requests. This takes a step further to have rejections based on the memory accounting at shard level along with other key performance factors like throughput and last successful requests. **Key features** - Granular tracking of indexing tasks performance, at every shard level, for each node role i.e. coordinator, primary and replica. - Smarter rejections by discarding the requests intended only for problematic index or shard, while still allowing others to continue (fairness in rejection). - Rejections thresholds governed by combination of configurable parameters (such as memory limits on node) and dynamic parameters (such as latency increase, throughput degradation). - Node level and shard level indexing pressure statistics exposed through stats api. - Integration of Indexing pressure stats with Plugins for for metric visibility and auto-tuning in future. - Control knobs to tune to the key performance thresholds which control rejections, to address any specific requirement or issues. - Control knobs to run the feature in shadow-mode or enforced-mode. In shadow-mode only internal rejection breakdown metrics will be published while no actual rejections will be performed. The changes were divided into small manageable chunks as part of the following PRs against a feature branch. - Add Shard Indexing Pressure Settings. #716 - Add Shard Indexing Pressure Tracker. #717 - Refactor IndexingPressure to allow extension. #718 - Add Shard Indexing Pressure Store #838 - Add Shard Indexing Pressure Memory Manager #945 - Add ShardIndexingPressure framework level construct and Stats #1015 - Add Indexing Pressure Service which acts as orchestrator for IP #1084 - Add plumbing logic for IndexingPressureService in Transport Actions. #1113 - Add shard indexing pressure metric/stats via rest end point. #1171 - Add shard indexing pressure integration tests. #1198 Signed-off-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com>
5 tasks
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Nov 18, 2021
…pensearch-project#1343)" This reverts commit 11237da. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to merge the changes for the shard level indexing back-pressure changes from the feature branch. The changes were divided into small manageable chunks as part of the following PRs against the feature branch.
Issues Resolved
#478
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.