-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handled recovery to start from lowest seqno in the translog based on retention lease #1217
Handled recovery to start from lowest seqno in the translog based on retention lease #1217
Conversation
Signed-off-by: Sai Kumar <karanas@amazon.com>
✅ Gradle Wrapper Validation success 3a293c7d37e8d59e43d9381c8b3c6e1456713b70 |
❌ DCO Check Failed 3a293c7d37e8d59e43d9381c8b3c6e1456713b70 |
3a293c7
to
6c546a3
Compare
✅ Gradle Wrapper Validation success 6c546a3 |
❌ DCO Check Failed 6c546a3 |
✅ Gradle Precommit success 3a293c7d37e8d59e43d9381c8b3c6e1456713b70 |
✅ Gradle Precommit success 6c546a3 |
.mapToLong(RetentionLease::retainingSequenceNumber) | ||
.min() | ||
.orElse(Long.MAX_VALUE); | ||
final long safeCommitSeqNo = Long.parseLong(safeCommitRef.getIndexCommit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this right, tlog recovery is a mechanism to optimize serialization. Why would start sequence number change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to have the same set of tlog ops from the primary shard onto the replica shard during the peer recovery. This ensures the ops are available in tlog as well in newly recovered shard
Description
if pruning is enabled,
Issues Resolved
#1100
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.