Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for translog pruning based on retention leases #1038

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Support for translog pruning based on retention leases #1038

merged 3 commits into from
Sep 8, 2021
+220 −11

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Aug 2, 2021 •
edited
Loading

Description

  • Adds support for translog pruning based on retention leases based on dynamic index setting - index.translog.retention_lease.pruning.enabled
  • Used primarily by replication plugin
  • Once replication is started on the index, this dynamic setting is enabled to prune translog operations based on the current index settings and retention leases

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 99252615658a9cf38ca5a2f6c85f4d37d08ac196

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed 99252615658a9cf38ca5a2f6c85f4d37d08ac196
Run ./dev-tools/signoff-check.sh remotes/origin/main 99252615658a9cf38ca5a2f6c85f4d37d08ac196 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed ac00b1ea6f620d89dcbf4d907c51c8ca122979db

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 99252615658a9cf38ca5a2f6c85f4d37d08ac196
Log 886

@saikaranam-amazon saikaranam-amazon marked this pull request as ready for review August 2, 2021 13:47
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success ac00b1ea6f620d89dcbf4d907c51c8ca122979db

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success ac00b1ea6f620d89dcbf4d907c51c8ca122979db

@saikaranam-amazon saikaranam-amazon mentioned this pull request Aug 10, 2021
Closed
Bukhtawar
Bukhtawar reviewed Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, please add tests covering the changes. Pinging @itiyamas for help with review

server/src/main/java/org/opensearch/index/IndexSettings.java Outdated Show resolved Hide resolved
@itiyamas
Copy link
Contributor

Is there an issue where this has been discussed? Why is this change needed? Some context will help.

@saikaranam-amazon
Copy link
Member Author

@Bukhtawar - Adding tests in the next revision.
@itiyamas - Added issue here #1100

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed d8f59aebdec8859a376be1892a69569e19d103a7

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success d8f59aebdec8859a376be1892a69569e19d103a7

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success d8f59aebdec8859a376be1892a69569e19d103a7

@ankitkala ankitkala mentioned this pull request Aug 25, 2021
Merged
1 task
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 49e7627

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 49e7627

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 49e7627
Log 1062

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 00c892d

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 00c892d

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 00c892d

@saikaranam-amazon saikaranam-amazon mentioned this pull request Sep 6, 2021
Closed
5 tasks
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 5acacdde252e3a0aa758efec26ba655b65364507

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 5acacdde252e3a0aa758efec26ba655b65364507

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure da240524ed9f66c825670ba9262ac496c82b1cb8
Log 1118

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Wrapper Validation failure da240524ed9f66c825670ba9262ac496c82b1cb8

:alert: Gradle Wrapper integrity has been altered

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 52fc576

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 52fc576

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 52fc576

@itiyamas
Copy link
Contributor

itiyamas commented Sep 8, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 52fc576
Log 501

Reports 501

@itiyamas itiyamas merged commit a9e1913 into opensearch-project:main Sep 8, 2021
@saikaranam-amazon saikaranam-amazon mentioned this pull request Sep 8, 2021
Merged
5 tasks
@nknize
Copy link
Collaborator

nknize commented Sep 8, 2021

we need to make sure these PRs are being labeled appropriately so we can track them in the change log

@nknize nknize added pending backport Identifies an issue or PR that still needs to be backported distributed framework v2.0.0 Version 2.0.0 labels Sep 8, 2021
@saikaranam-amazon saikaranam-amazon mentioned this pull request Sep 18, 2021
Merged
5 tasks
saikaranam-amazon added a commit to saikaranam-amazon/OpenSearch that referenced this pull request Sep 20, 2021
@saikaranam-amazon
Support for translog pruning based on retention leases (opensearch-pr…
4c1a8ad 
…oject#1038)

Signed-off-by: Sai Kumar <karanas@amazon.com>
saikaranam-amazon added a commit to saikaranam-amazon/OpenSearch that referenced this pull request Sep 21, 2021
@saikaranam-amazon
Support for translog pruning based on retention leases (opensearch-pr…
7e8fb94 
…oject#1038)

Signed-off-by: Sai Kumar <karanas@amazon.com>
@nknize nknize mentioned this pull request Sep 23, 2021
Open
nknize pushed a commit to saikaranam-amazon/OpenSearch that referenced this pull request Sep 25, 2021
@saikaranam-amazon @nknize
Support for translog pruning based on retention leases (opensearch-pr…
1e1d3b8 
…oject#1038)

(cherry picked from commit a9e1913)

Signed-off-by: Sai Kumar <karanas@amazon.com>
nknize added a commit that referenced this pull request Sep 26, 2021
@saikaranam-amazon @nknize
[Backport] Support for translog pruning based on retention leases (#1226
294cee4 
)

Support for translog pruning based on retention leases (#1038)

Co-authored-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Sai Kumar <karanas@amazon.com>
nknize pushed a commit to saikaranam-amazon/OpenSearch that referenced this pull request Sep 26, 2021
@saikaranam-amazon @nknize
Support for translog pruning based on retention leases (opensearch-pr…
4e4a983 
…oject#1038)

Signed-off-by: Sai Kumar <karanas@amazon.com>
nknize added a commit that referenced this pull request Sep 26, 2021
@saikaranam-amazon @nknize
[Backport] Support for translog pruning based on retention leases (#1038
eba365c 
) (#1256)

Support for translog pruning based on retention leases; including deprecations for
refactoring to ccr plugin in the future.

Co-authored-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Sai Kumar <karanas@amazon.com>
@dblock dblock removed the pending backport Identifies an issue or PR that still needs to be backported label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar left review comments

@itiyamas itiyamas itiyamas approved these changes

Assignees
No one assigned
Labels
distributed framework v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saikaranam-amazon @opensearch-ci-bot @itiyamas @nknize @Bukhtawar @dblock