Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replication plugin to Opensearch 1.1 build manifest #315

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Aug 25, 2021

Description

Add replication plugin to Opensearch 1.1 build manifest
PR on plugin side: opensearch-project/cross-cluster-replication#119

Also, replication build depends on the following change on opensearch: opensearch-project/OpenSearch#1038 . So the PR should be deployed for build to go through.

Issues Resolved

#266

Testing done

./bundle-workflow/build.sh manifests/opensearch-1.1.0.yml --snapshot --component cross-cluster-replication

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double-confirm, what does the .zip file name/output look like from both --snapshot and without run?

@ankitkala
Copy link
Member Author

ankitkala commented Aug 26, 2021

Just to double-confirm, what does the .zip file name/output look like from both --snapshot and without run?

opensearch-cross-cluster-replication-1.1.0-SNAPSHOT.zip and opensearch-cross-cluster-replication-1.1.0.zip

@dblock dblock requested a review from gaiksaya August 27, 2021 03:00
@dblock
Copy link
Member

dblock commented Aug 27, 2021

This looks good, comment when the dependent PRs went in so we can merge?

@dblock
Copy link
Member

dblock commented Aug 31, 2021

I don't see a CI on https://github.com/opensearch-project/cross-cluster-replication. Because we're rebuilding the world in bundle-workflow we can't add a repo without that or this repo will effectively become the CI for cross-cluster-replication.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cross-cluster-replication will need CI

@ankitkala
Copy link
Member Author

I don't see a CI on https://github.com/opensearch-project/cross-cluster-replication. Because we're rebuilding the world in bundle-workflow we can't add a repo without that or this repo will effectively become the CI for cross-cluster-replication.

These are separate set of changes which are being added here: opensearch-project/cross-cluster-replication#123

@codecov-commenter
Copy link

Codecov Report

Merging #315 (e162af8) into main (b253175) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   57.45%   57.45%           
=======================================
  Files          34       34           
  Lines         992      992           
=======================================
  Hits          570      570           
  Misses        422      422           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b253175...e162af8. Read the comment docs.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitkala The new CI check is not yet passing, please resolve these issues and ping us to take another look.

@saikaranam-amazon
Copy link
Member

@peternied Could you please take a look into the PR?

  • Build issues are resolved

peterzhuamazon
peterzhuamazon previously approved these changes Sep 27, 2021
@@ -37,6 +37,9 @@ components:
- name: security
repository: https://github.com/opensearch-project/security.git
ref: "1.1"
- name: cross-cluster-replication
repository: https://github.com/opensearch-project/cross-cluster-replication.git
ref: 1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be a string

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gaiksaya
gaiksaya previously approved these changes Sep 27, 2021
@dblock
Copy link
Member

dblock commented Sep 27, 2021

More tests failing.

Signed-off-by: Sai Kumar <karanas@amazon.com>
@dblock dblock dismissed peternied’s stale review September 27, 2021 20:58

Moving forward.

@dblock dblock merged commit d459fa0 into opensearch-project:main Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants