-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replication plugin to Opensearch 1.1 build manifest #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double-confirm, what does the .zip file name/output look like from both --snapshot
and without run?
|
This looks good, comment when the dependent PRs went in so we can merge? |
I don't see a CI on https://github.com/opensearch-project/cross-cluster-replication. Because we're rebuilding the world in bundle-workflow we can't add a repo without that or this repo will effectively become the CI for cross-cluster-replication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cross-cluster-replication will need CI
These are separate set of changes which are being added here: opensearch-project/cross-cluster-replication#123 |
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 57.45% 57.45%
=======================================
Files 34 34
Lines 992 992
=======================================
Hits 570 570
Misses 422 422 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitkala The new CI check is not yet passing, please resolve these issues and ping us to take another look.
@peternied Could you please take a look into the PR?
|
manifests/1.1.0/opensearch-1.1.0.yml
Outdated
@@ -37,6 +37,9 @@ components: | |||
- name: security | |||
repository: https://github.com/opensearch-project/security.git | |||
ref: "1.1" | |||
- name: cross-cluster-replication | |||
repository: https://github.com/opensearch-project/cross-cluster-replication.git | |||
ref: 1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be a string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ed041ec
to
7cb8bc7
Compare
More tests failing. |
68a675a
to
304961e
Compare
Signed-off-by: Sai Kumar <karanas@amazon.com>
304961e
to
1021c4e
Compare
Description
Add replication plugin to Opensearch 1.1 build manifest
PR on plugin side: opensearch-project/cross-cluster-replication#119
Also, replication build depends on the following change on opensearch: opensearch-project/OpenSearch#1038 . So the PR should be deployed for build to go through.
Issues Resolved
#266
Testing done
./bundle-workflow/build.sh manifests/opensearch-1.1.0.yml --snapshot --component cross-cluster-replication
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.