[Backport] Support for translog pruning based on retention leases #1226
Conversation
|
✅ DCO Check Passed c5ff5261b102d8cf6fe83568daf6ab86711c9cde |
|
✅ Gradle Wrapper Validation success c5ff5261b102d8cf6fe83568daf6ab86711c9cde |
|
✅ Gradle Precommit success c5ff5261b102d8cf6fe83568daf6ab86711c9cde |
|
start gradle check |
nknize
added
backport
|
❌ Gradle Check failure c5ff5261b102d8cf6fe83568daf6ab86711c9cde |
|
I've seen these issues before: It usually means the checked out codebase that's being built for bwc testing generated a version artifact that did not match the expected version. In this case, the build expected a 1.0.0 build but got something else (my money is on 1.0.1 since 1.0 branch is now at a staged bugfix release). I haven't had a chance to circle back on this so I'm speculating that the bwc builder is either looking for (or needs to look for) the release tag to check out and build the appropriate bwc version. We inherited that code and release tags upstream always looked like @adnapibar is familiar with the BWC builder so perhaps he can take a look? |
|
We should re-add the |
|
Is this feature a blocker for the 1.1 release or can it hold and bake a while for 1.2? |
This is blocker for 1.1 release |
|
Can you rebase your branch onto https://github.com/opensearch-project/OpenSearch/tree/1.x |
saikaranam-amazon
force-pushed
the
1-x-translog-pruning
branch
from
c5ff526 to
81f64c4
Compare
What is it blocking? |
Done. Pushed the change
The changes are needed for the replication plugin releasing with 1.1 |
Do you have a merged PR on the replication plugin repo that depends on this logic? |
|
✅ Gradle Wrapper Validation success 81f64c4d5271944b354d5698becc87579fdfbc5e |
|
✅ DCO Check Passed 81f64c4d5271944b354d5698becc87579fdfbc5e |
Yes, changes are merged here: link |
|
✅ Gradle Precommit success 81f64c4d5271944b354d5698becc87579fdfbc5e |
That change was merged 2 months ago; and it depends on a setting that has not been in OpenSearch core until today? How is this possible? Release is scheduled for less than a week and we're trying to backport a new setting that has no time to bake. Huge -1 for this. |
The changes related to this PR on OpenSearch was raised more than 1 month back after thorough testing from our side. As Opensearch team was tracking multiple releases in between 1.1 and 1.0, changes to previous version were prioritized and reviewed before this. |
The issue was opened 22 days ago. The PR was opened before the issue. The changes were only recently merged to main, and a backport just now opened (2 hrs ago) against 1.x less than a week before the planned release. This is too late. I'm a fan of the proposed change but this didn't have enough time to bake before the 1.1 release. Huge recommendation to bump to 1.2.
Unfortunately that's not the primary core CI; and we're now playing |
|
If we don't want to hold the feature for a 1.2 release then I recommend we hold the 1.1 release for at least a week to let this settle. I like the change, it's just too late to be wedging these in for a 1.1 release in less than a week. I'm going to mark this as a blocker for 1.1 so we have traceability. Let's hold on removing that blocker label until we're comfortable the changes have had time to bake. |
|
start gradle check |
|
@saikaranam-amazon Hi Sai! Can you tell us more about how your testing was done? If we're still seeing changes coming in against 1.1, how have you been able to validate the change against the full set? Thanks! |
|
✅ Gradle Precommit success a958a528d1c5eecdf1bfb265d4cda05bebcb96ad |
saikaranam-amazon
force-pushed
the
1-x-translog-pruning
branch
from
a958a52 to
88ce28b
Compare
|
✅ DCO Check Passed 88ce28ba2f2f61ecde355f1ee60f4bc688a963e3 |
|
✅ Gradle Wrapper Validation success 88ce28ba2f2f61ecde355f1ee60f4bc688a963e3 |
|
✅ Gradle Precommit success 88ce28ba2f2f61ecde355f1ee60f4bc688a963e3 |
|
start gradle check |
|
✅ Gradle Wrapper Validation success 52f50ddd6680eafc9a528f84b76bee39ab9534a9 |
…oject#1038) (cherry picked from commit a9e1913) Signed-off-by: Sai Kumar <karanas@amazon.com>
Signed-off-by: Sai Kumar <karanas@amazon.com>
This commit adds deprecation flags to all added settings, variables, and methods specific to ccr's retention lease pruning mechanism. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Sai Kumar <karanas@amazon.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Sai Kumar <karanas@amazon.com>
Signed-off-by: Sai Kumar <karanas@amazon.com>
|
✅ DCO Check Passed 52f50ddd6680eafc9a528f84b76bee39ab9534a9 |
nknize
force-pushed
the
1-x-translog-pruning
branch
from
52f50dd to
6c38cab
Compare
|
✅ DCO Check Passed 6c38cab |
|
start gradle check |
|
❌ Gradle Precommit failure 52f50ddd6680eafc9a528f84b76bee39ab9534a9 |
|
✅ Gradle Wrapper Validation success 6c38cab |
|
✅ Gradle Precommit success 6c38cab |
|
✅ Gradle Check success 52f50ddd6680eafc9a528f84b76bee39ab9534a9 |
|
unrelated failure.. starting gradle check over |
|
start gradle check |
Description
Backport of #1038
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.