Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Apply fast date histogram optimization at the segment level #12234

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9a0a69f from #12073.

---------

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit 9a0a69f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Compatibility status:

Checks if related components are compatible with change b92176b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Feb 7, 2024

❌ Gradle check result for b92176b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ed7565) 71.25% compared to head (6ed7565) 71.25%.
Report is 2 commits behind head on 2.x.

❗ Current head 6ed7565 differs from pull request most recent head b92176b. Consider uploading reports for the commit b92176b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x   #12234   +/-   ##
=========================================
  Coverage     71.25%   71.25%           
  Complexity    59894    59894           
=========================================
  Files          4939     4939           
  Lines        281748   281748           
  Branches      41259    41259           
=========================================
  Hits         200753   200753           
  Misses        63981    63981           
  Partials      17014    17014           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenlan-amzn
Copy link
Member

❌ Gradle check result for b92176b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

I checked out 2.x branch without my date histogram optimization commits, still can see these 2 test failures

@reta
Copy link
Collaborator

reta commented Feb 7, 2024

I checked out 2.x branch without my date histogram optimization commits, still can see these 2 test failures

@bowenlan-amzn could you please create issues for them? thank you

@bowenlan-amzn
Copy link
Member

I checked out 2.x branch without my date histogram optimization commits, still can see these 2 test failures

@bowenlan-amzn could you please create issues for them? thank you

@reta created one #12239

@bowenlan-amzn
Copy link
Member

merged using #12279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants