Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] 12073 and 12267 #12279

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Feb 9, 2024

Description

Backport #12073 #12267

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions bot and others added 3 commits February 7, 2024 19:01
…ch-project#12073)

---------

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit 9a0a69f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ization (opensearch-project#12267)


---------

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
@bowenlan-amzn bowenlan-amzn changed the title Apply fast date histogram optimization at the segment level (#12073) [Backport 2.x] 12073 and 12267 Feb 9, 2024
@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review February 9, 2024 22:09
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Compatibility status:

Checks if related components are compatible with change a23c8e3

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ Gradle check result for a23c8e3: SUCCESS

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c06f203) 71.16% compared to head (a23c8e3) 71.14%.
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...h/aggregations/bucket/FastFilterRewriteHelper.java 87.71% 3 Missing and 11 partials ⚠️
...egations/bucket/composite/CompositeAggregator.java 90.47% 1 Missing and 1 partial ⚠️
...org/opensearch/gradle/RepositoriesSetupPlugin.java 0.00% 1 Missing ⚠️
...ions/bucket/histogram/DateHistogramAggregator.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12279      +/-   ##
============================================
- Coverage     71.16%   71.14%   -0.03%     
- Complexity    59914    59923       +9     
============================================
  Files          4944     4944              
  Lines        282117   282184      +67     
  Branches      41321    41334      +13     
============================================
- Hits         200774   200750      -24     
- Misses        64308    64479     +171     
+ Partials      17035    16955      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit 25c2fde into opensearch-project:2.x Feb 9, 2024
93 of 104 checks passed
@bowenlan-amzn bowenlan-amzn added the backport 2.12 Backport to 2.12 branch label Feb 10, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 10, 2024
…level (#12279)

* Apply fast date histogram optimization at the segment level (#12073)

---------

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit 9a0a69f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix: reset the filter built at segment level for date histogram optimization (#12267)

---------

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

---------

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 25c2fde)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh pushed a commit that referenced this pull request Feb 10, 2024
…level (#12279) (#12284)

* Apply fast date histogram optimization at the segment level (#12073)

---------


(cherry picked from commit 9a0a69f)


* Fix: reset the filter built at segment level for date histogram optimization (#12267)

---------



---------




(cherry picked from commit 25c2fde)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@bowenlan-amzn bowenlan-amzn deleted the backport2.x branch May 3, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.12 Backport to 2.12 branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants