Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Migration] Update checkpoint from remote nodes replicas #13888

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented May 30, 2024

Description

During remote store migration , we need to update remote store backed replica's checkpoint to the primary .

Related Issues

Resolves #13889

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gbbafna gbbafna changed the title Update checkpoint from remote nodes replicas [Remote Migration] Update checkpoint from remote nodes replicas May 30, 2024
@github-actions github-actions bot added the bug Something isn't working label May 30, 2024
@gbbafna gbbafna requested a review from shourya035 May 30, 2024 06:57
@gbbafna gbbafna marked this pull request as ready for review May 30, 2024 07:47
Copy link
Contributor

❌ Gradle check result for 48325e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label May 30, 2024
Copy link
Contributor

❌ Gradle check result for 48325e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ansjcy added a commit to ansjcy/OpenSearch that referenced this pull request Jun 6, 2024
…ect#13888)"

This reverts commit c89a17c.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
@jed326
Copy link
Collaborator

jed326 commented Jun 6, 2024

@gbbafna @sachinpkale @shourya035 it looks like an NPE was introduced in this PR, see: #14055

Reverting this to unblock builds for now: #14056

Seems like it was also present in the failed gradle checks above as well, for example: https://build.ci.opensearch.org/job/gradle-check/39458/

jed326 pushed a commit that referenced this pull request Jun 6, 2024
This reverts commit c89a17c.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 6, 2024
This reverts commit c89a17c.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit c987d6b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jed326 pushed a commit that referenced this pull request Jun 7, 2024
… (#14059)

This reverts commit c89a17c.


(cherry picked from commit c987d6b)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Jun 7, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
sachinpkale pushed a commit that referenced this pull request Jun 7, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit b06d0b9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Jun 8, 2024
sachinpkale pushed a commit that referenced this pull request Jun 9, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
… (opensearch-project#14047)

(cherry picked from commit c89a17c)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…ect#13888)" (opensearch-project#14056) (opensearch-project#14059)

This reverts commit c89a17c.

(cherry picked from commit c987d6b)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
… (opensearch-project#14062) (opensearch-project#14094)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Remote Migration] Ever increasing segment replication lag during remote store migration
4 participants