Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkpoint from remote nodes replicas (#13888) #14062

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Jun 7, 2024

Description

During remote store migration , we need to update remote store backed replica's checkpoint to the primary .

Also marking multiple Remote Store Migrations flaky tests as AwaitsFix to unblock the builds.

Related Issues

Resolves #13889

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions github-actions bot added the bug Something isn't working label Jun 7, 2024
@gbbafna gbbafna added skip-changelog and removed bug Something isn't working labels Jun 7, 2024
@gbbafna gbbafna marked this pull request as ready for review June 7, 2024 05:07
@github-actions github-actions bot added the bug Something isn't working label Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 7e183f7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Copy link
Collaborator Author

gbbafna commented Jun 7, 2024

[org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/40134/testReport/junit/org.opensearch.indices/IndicesRequestCacheIT/testDeleteAndCreateSameIndexShardOnSameNode__p0___search_concurrent_segment_search_enabled___true___/)
    [org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"false"}}](https://build.ci.opensearch.org/job/gradle-check/40134/testReport/junit/org.opensearch.indices/IndicesRequestCacheIT/testDeleteAndCreateSameIndexShardOnSameNode__p0___opensearch_experimental_feature_pluggable_caching_enabled___false___/)
    [org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/40134/testReport/junit/org.opensearch.indices/IndicesRequestCacheIT/testDeleteAndCreateSameIndexShardOnSameNode__p0___opensearch_experimental_feature_pluggable_caching_enabled___true___/)
    [org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode {p0={"search.concurrent_segment_search.enabled":"false"}}](https://build.ci.opensearch.org/job/gradle-check/40134/testReport/junit/org.opensearch.indices/IndicesRequestCacheIT/testDeleteAndCreateSameIndexShardOnSameNode__p0___search_concurrent_segment_search_enabled___false___/)
    [org.opensearch.search.basic.SearchWithRandomExceptionsIT.testRandomExceptions {p0={"search.concurrent_segment_search.enabled":"false"}}](https://build.ci.opensearch.org/job/gradle-check/40134/testReport/junit/org.opensearch.search.basic/SearchWithRandomExceptionsIT/testRandomExceptions__p0___search_concurrent_segment_search_enabled___false___/)

Failed tests, retrying

@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 7e183f7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Copy link
Collaborator Author

gbbafna commented Jun 7, 2024

Failing flaky

[org.opensearch.cache.common.tier.TieredSpilloverCacheStatsIT.testIndicesLevelAggregation](https://build.ci.opensearch.org/job/gradle-check/40140/testReport/junit/org.opensearch.cache.common.tier/TieredSpilloverCacheStatsIT/testIndicesLevelAggregation/)

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❕ Gradle check result for 7e183f7: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (b15cb0c) to head (7e183f7).
Report is 367 commits behind head on main.

Files Patch % Lines
...s/replication/SegmentReplicationTargetService.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14062      +/-   ##
============================================
+ Coverage     71.42%   71.71%   +0.29%     
- Complexity    59978    61556    +1578     
============================================
  Files          4985     5081      +96     
  Lines        282275   289068    +6793     
  Branches      40946    41836     +890     
============================================
+ Hits         201603   207311    +5708     
- Misses        63999    64660     +661     
- Partials      16673    17097     +424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit b06d0b9 into opensearch-project:main Jun 7, 2024
61 of 63 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit b06d0b9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Jun 8, 2024
sachinpkale pushed a commit that referenced this pull request Jun 9, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
… (opensearch-project#14062) (opensearch-project#14094)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Remote Migration] Ever increasing segment replication lag during remote store migration
2 participants