Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to provide tags with value in Gauge metric #13994

Merged
merged 8 commits into from
Jun 10, 2024

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Jun 5, 2024

Description

Updates the definition of a Gauge meter to add tags at value level instead of the meter.

Related Issues

Resolves #13991

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Gaganjuneja
Copy link
Contributor Author

@reta, Please take a look. Thanks!

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ Gradle check result for 7573b6f: SUCCESS

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (b15cb0c) to head (42768f4).
Report is 373 commits behind head on main.

Files Patch % Lines
...pensearch/telemetry/metrics/TaggedMeasurement.java 0.00% 7 Missing ⚠️
...ch/telemetry/metrics/noop/NoopMetricsRegistry.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13994      +/-   ##
============================================
+ Coverage     71.42%   71.67%   +0.25%     
- Complexity    59978    61588    +1610     
============================================
  Files          4985     5082      +97     
  Lines        282275   289084    +6809     
  Branches      40946    41836     +890     
============================================
+ Hits         201603   207198    +5595     
- Misses        63999    64795     +796     
- Partials      16673    17091     +418     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gaganjuneja Gaganjuneja changed the title Update Gauge meter to add tags with value Adds support to provide tags with value in Gauge metric Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 472af7f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 3d78aea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 3d78aea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for 4f3e265: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for c761859: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Copy link
Contributor

github-actions bot commented Jun 8, 2024

✅ Gradle check result for 42768f4: SUCCESS

@Gaganjuneja
Copy link
Contributor Author

@reta, Need your help in merging this. Thanks!

@reta reta merged commit 24d7069 into opensearch-project:main Jun 10, 2024
29 of 30 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13994-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24d70696ae4e145fccf6042c1f9b9f83b64677b8
# Push it to GitHub
git push --set-upstream origin backport/backport-13994-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13994-to-2.x.

@reta
Copy link
Collaborator

reta commented Jun 10, 2024

@Gaganjuneja the backport failed sadly, could you please send a manual one? thank you

@Gaganjuneja
Copy link
Contributor Author

@Gaganjuneja the backport failed sadly, could you please send a manual one? thank you

backport is failing because of this open PR - #14118

@reta
Copy link
Collaborator

reta commented Jun 10, 2024

backport is failing because of this open PR - #14118

Not sure I got it, there is no backport PR afaict

Gaganjuneja added a commit to Gaganjuneja/OpenSearch that referenced this pull request Jun 10, 2024
…roject#13994)

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds build issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix compilation issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…roject#13994)

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds build issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix compilation issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
reta pushed a commit that referenced this pull request Jun 10, 2024
)

* Adds support to provide tags with value in Gauge metric



* Adds support to provide tags with value in Gauge metric



* Adds support to provide tags with value in Gauge metric



* Adds build issue



* Fix compilation issue



* Empty-Commit



* Empty-Commit



---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…roject#13994) (opensearch-project#14138)

* Adds support to provide tags with value in Gauge metric

* Adds support to provide tags with value in Gauge metric

* Adds support to provide tags with value in Gauge metric

* Adds build issue

* Fix compilation issue

* Empty-Commit

* Empty-Commit

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…roject#13994)

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds support to provide tags with value in Gauge metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds build issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix compilation issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Other Telemetry:Metrics PRs or issues specific to telemetry metrics framework v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] MetricRegistry:createGauge should allow passing the Tags as part of the valueProvider.
2 participants