Fix windows build (mostly)

[dblock]

Description

This fixes much of the Windows build.

What Works

./gradlew :distribution:archives:windows-zip:assemble

This is sufficient for opensearch-project/opensearch-build#767

What Doesn't Work

./gradlew :test:fixtures:azure-fixture:composeUp # causes :build to fail
./gradlew assemble # tries to assemble docker images for CentOS

Issues Resolved

Most of #1379.

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

Can one of the admins verify this patch?

[dblock]

start gradle check

[opensearch-ci-bot]

✅   DCO Check Passed 04af520

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 04af520

[opensearch-ci-bot]

❌   Gradle Precommit failure 04af520
Log 1372

[opensearch-ci-bot]

✅   Gradle Check success 04af520
Log 770

Reports 770

[opensearch-ci-bot]

✅   DCO Check Passed 3677f12

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 3677f12

[opensearch-ci-bot]

✅   Gradle Precommit success 3677f12

[dblock]

start gradle check

[opensearch-ci-bot]

✅   Gradle Check success 3677f12
Log 776

Reports 776

[reta]

@dblock I could help with ./gradlew :test:fixtures:azure-fixture:composeUp # causes :build to fail, please let me know :-)

[dblock]

@dblock I could help with ./gradlew :test:fixtures:azure-fixture:composeUp # causes :build to fail, please let me know :-)

Definitely, please!

[reta]

./gradlew :test:fixtures:azure-fixture:composeUp

@dblock I was running the build on Windows 10 / Docker Desktop 3.6 with latest main, all stages and tests pass with no issues (I see containers started and stopped):

$ ./gradlew :test:fixtures:azure-fixture:composeUp
...
BUILD SUCCESSFUL in 20s
1 actionable task: 1 executed

The check task also passes:

./gradlew :plugins:repository-azure:check
...
BUILD SUCCESSFUL in 6m 8s
200 actionable tasks: 12 executed, 188 up-to-date

May be you could hint what the problem you run into? Thank you!

[dblock]

My bad for not posting the entire error, I’ll do it when I’m back on the computer.

@reta can you successfully run ./gradlew build and assemble on windows all the way? I also think we’re defaulting to building centos packages but otherwise that’s all I know to be a problem

[dblock]

I'm getting an obscure docker compose finished with an exit code 17, and a "not implemented" on stderr.

2021-10-22T17:22:24.908+0000 [INFO] [org.gradle.process.internal.DefaultExecHandle] Successfully started process 'command 'C:\Program Files\Docker\Docker\resources\bin\docker-compose.exe''
2021-10-22T17:22:24.908+0000 [DEBUG] [org.gradle.process.internal.ExecHandleRunner] waiting until streams are handled...
2021-10-22T17:22:26.289+0000 [ERROR] [system.err] not implemented
2021-10-22T17:22:26.333+0000 [DEBUG] [org.gradle.process.internal.DefaultExecHandle] Changing state to: FAILED
2021-10-22T17:22:26.333+0000 [DEBUG] [org.gradle.process.internal.DefaultExecHandle] Process 'command 'C:\Program Files\Docker\Docker\resources\bin\docker-compose.exe'' finished with exit value 17 (state: FAILED)

it's coming from docker-compose itself

./docker-compose -f ./test/fixtures/azure-fixture/docker-compose.yml up
not implemented

https://forums.docker.com/t/docker-compose-up-returns-not-implemented-what-worng/111914/14 says to run docker-compose disable-v2 which gets me further.

[reta]

Hm .... no, I don't see that, very weird .... the ./gradlew build & ./gradlew assemble do fail for me, but for different reasons:

$ ./gradlew build
> Task :build-tools:integTest FAILED

(symbolic link tests)

$ ./gradlew assemble

> Task :distribution:archives:buildLinuxArm64Tar FAILED
> Task :distribution:archives:buildLinuxTar FAILED

Which is related to #1406

[reta]

Just saw it, #1425, so it explains why it fails for you (Docker Desktop 4.x) and not for me (Docker Desktop 3.6.x).

[dblock]

Let's move the discussion to #1425.

[dblock]

So let's assume I solve my docker issue ...

$ ./gradlew assemble

> Task :distribution:archives:buildLinuxArm64Tar FAILED
> Task :distribution:archives:buildLinuxTar FAILED

Shouldn't it be building Windows stuff here, i.e. buildWindowsZip?

[reta]

Exactly, this is what I would have expected, looking why

[reta]

So let's assume I solve my docker issue ...

$ ./gradlew assemble

> Task :distribution:archives:buildLinuxArm64Tar FAILED
> Task :distribution:archives:buildLinuxTar FAILED

Shouldn't it be building Windows stuff here, i.e. buildWindowsZip?

@dblock it seems like we always build all distributions but we run into #1430

[dblock]

@dblock it seems like we always build all distributions but we run into #1430

Alright, I think we should leave it as is. I'll comment in 1430.