Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend Docker 3.6.0 on Windows #1427

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 22, 2021

Signed-off-by: dblock dblock@dblock.org

Description

On my Windows VM (Windows_Server-2019-English-Full-Base-2021.10.13 AMI) I cannot get Docker 3.6.0 nor 4.1.1 to work fully, but @reta reports Docker 3.6.0 to work properly here, so let's recommend that.

Issues Resolved

Related to #1379.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock changed the title Recommend Docker 3.6.0. Recommend Docker 3.6.0 on Windows Oct 22, 2021
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dblock
Copy link
Member Author

dblock commented Oct 22, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed e7648a6

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success e7648a6

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success e7648a6

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e7648a6
Log 790

Reports 790

@dblock dblock merged commit b180bc8 into opensearch-project:main Oct 22, 2021
@dblock dblock deleted the recommend-docker-3.6 branch October 22, 2021 19:32
nknize pushed a commit that referenced this pull request Oct 26, 2021
Signed-off-by: dblock <dblock@dblock.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants