Add tests for RemoteGlobalMetadataManager #14394

shiv0408 · 2024-06-17T12:31:40Z

Description

Add tests for async read and write of attributes in RemoteGlobalMetadataManager. These flows were added in #14089, #13924 but coverage for these flows were not sufficient.

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

github-actions · 2024-06-17T13:28:22Z

❕ Gradle check result for c0a12f2: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-06-17T13:29:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (b15cb0c) to head (b456243).
Report is 453 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14394      +/-   ##
============================================
+ Coverage     71.42%   71.77%   +0.35%     
- Complexity    59978    62099    +2121     
============================================
  Files          4985     5118     +133     
  Lines        282275   291833    +9558     
  Branches      40946    42180    +1234     
============================================
+ Hits         201603   209456    +7853     
- Misses        63999    65066    +1067     
- Partials      16673    17311     +638

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-06-17T13:38:30Z

❌ Gradle check result for 587c566: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/test/java/org/opensearch/gateway/remote/RemoteGlobalMetadataManagerTests.java

shiv0408 · 2024-06-18T19:39:00Z

❌ Gradle check result for 3aefbed: FAILURE

org.opensearch.upgrades.IndexingIT.testIndexingWithSegRep - #14302

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

github-actions · 2024-06-18T20:46:08Z

✅ Gradle check result for ec042aa: SUCCESS

server/src/test/java/org/opensearch/gateway/remote/RemoteStateTestUtil.java

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

github-actions · 2024-06-19T08:51:39Z

❌ Gradle check result for 5924b92: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

shiv0408 · 2024-06-19T10:47:14Z

❌ Gradle check result for 5924b92: FAILURE

org.opensearch.action.admin.indices.create.RemoteCloneIndexIT.testCreateCloneIndexFailure - #14292
org.opensearch.search.SearchTimeoutIT.testSimpleTimeout {p0={"search.concurrent_segment_search.enabled":"true"}} - #9401

github-actions · 2024-06-19T11:42:07Z

❌ Gradle check result for b456243: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-06-19T18:37:55Z

❕ Gradle check result for b456243: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

* Add tests for RemoteGlobalMetadataManager Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add TestCapturingListener Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Move TestCapturingListener to test/framework Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Added javadoc Signed-off-by: Shivansh Arora <hishiv@amazon.com> --------- Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 8e32ed7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add tests for RemoteGlobalMetadataManager * Add TestCapturingListener * Move TestCapturingListener to test/framework * Added javadoc --------- (cherry picked from commit 8e32ed7) Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add tests for RemoteGlobalMetadataManager Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add TestCapturingListener Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Move TestCapturingListener to test/framework Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Added javadoc Signed-off-by: Shivansh Arora <hishiv@amazon.com> --------- Signed-off-by: Shivansh Arora <hishiv@amazon.com>

…pensearch-project#14458) * Add tests for RemoteGlobalMetadataManager * Add TestCapturingListener * Move TestCapturingListener to test/framework * Added javadoc --------- (cherry picked from commit 8e32ed7) Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>

* Add tests for RemoteGlobalMetadataManager Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add TestCapturingListener Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Move TestCapturingListener to test/framework Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Added javadoc Signed-off-by: Shivansh Arora <hishiv@amazon.com> --------- Signed-off-by: Shivansh Arora <hishiv@amazon.com>

Add tests for RemoteGlobalMetadataManager

587c566

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

shiv0408 force-pushed the global_manager_tests branch from c0a12f2 to 587c566 Compare June 17, 2024 12:43

shiv0408 added the skip-changelog label Jun 17, 2024

shiv0408 marked this pull request as ready for review June 17, 2024 13:29

shiv0408 requested review from anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami, tlfeng and VachaShah as code owners June 17, 2024 13:29

andrross reviewed Jun 17, 2024

View reviewed changes

server/src/test/java/org/opensearch/gateway/remote/RemoteGlobalMetadataManagerTests.java Outdated Show resolved Hide resolved

opensearch-ci-bot mentioned this pull request Jun 17, 2024

[AUTOCUT] Gradle Check Flaky Test Report for RemoteSplitIndexIT #14296

Open

Add TestCapturingListener

ec042aa

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

shiv0408 force-pushed the global_manager_tests branch from 3aefbed to ec042aa Compare June 18, 2024 19:39

andrross reviewed Jun 18, 2024

View reviewed changes

server/src/test/java/org/opensearch/gateway/remote/RemoteStateTestUtil.java Outdated Show resolved Hide resolved

opensearch-ci-bot mentioned this pull request Jun 18, 2024

[AUTOCUT] Gradle Check Flaky Test Report for IndexingIT #14302

Open

Move TestCapturingListener to test/framework

5924b92

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

Added javadoc

b456243

Signed-off-by: Shivansh Arora <hishiv@amazon.com>

opensearch-ci-bot mentioned this pull request Jun 19, 2024

[AUTOCUT] Gradle Check Flaky Test Report for RemoteCloneIndexIT #14292

Open

soosinha approved these changes Jun 19, 2024

View reviewed changes

andrross approved these changes Jun 19, 2024

View reviewed changes

dblock merged commit 8e32ed7 into opensearch-project:main Jun 19, 2024
31 of 32 checks passed

dblock added the backport 2.x Backport to 2.x branch label Jun 19, 2024

opensearch-trigger-bot bot mentioned this pull request Jun 19, 2024

[Backport 2.x] Add tests for RemoteGlobalMetadataManager #14458

Merged

This was referenced Jun 20, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MinimumClusterManagerNodesIT #14289

Open

[AUTOCUT] Gradle Check Flaky Test Report for ResourceAwareTasksTests #14293

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteIndexRecoveryIT #14323

Open

shiv0408 mentioned this pull request Jun 20, 2024

Add unittests for RemoteClusterStateAttributesManager #14427

Merged

3 tasks

shiv0408 self-assigned this Aug 5, 2024

shiv0408 mentioned this pull request Sep 11, 2024

Release latch listeners in case of no-op RoutingTableService #15614

Open

3 tasks

opensearch-ci-bot mentioned this pull request Sep 24, 2024

[AUTOCUT] Gradle Check Flaky Test Report for SearchTimeoutIT #16056

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for RemoteGlobalMetadataManager #14394

Add tests for RemoteGlobalMetadataManager #14394

shiv0408 commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024

codecov bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024

shiv0408 commented Jun 18, 2024

github-actions bot commented Jun 18, 2024

github-actions bot commented Jun 19, 2024

shiv0408 commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024

github-actions bot commented Jun 19, 2024

Add tests for RemoteGlobalMetadataManager #14394

Add tests for RemoteGlobalMetadataManager #14394

Conversation

shiv0408 commented Jun 17, 2024 • edited Loading

Description

Check List

github-actions bot commented Jun 17, 2024

codecov bot commented Jun 17, 2024 • edited Loading

Codecov Report

github-actions bot commented Jun 17, 2024

shiv0408 commented Jun 18, 2024

github-actions bot commented Jun 18, 2024

github-actions bot commented Jun 19, 2024

shiv0408 commented Jun 19, 2024 • edited Loading

github-actions bot commented Jun 19, 2024

github-actions bot commented Jun 19, 2024

shiv0408 commented Jun 17, 2024 •

edited

Loading

codecov bot commented Jun 17, 2024 •

edited

Loading

shiv0408 commented Jun 19, 2024 •

edited

Loading