-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct RHLC searchTemplate & mtermVectors endpoints to have leading slash #14465
Correct RHLC searchTemplate & mtermVectors endpoints to have leading slash #14465
Conversation
a85a318
to
1b710de
Compare
❌ Gradle check result for a85a318: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 1b710de: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…slash Signed-off-by: Thomas Farr <tsfarr@amazon.com>
1b710de
to
319b5ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14465 +/- ##
============================================
+ Coverage 71.42% 71.75% +0.33%
- Complexity 59978 62060 +2082
============================================
Files 4985 5118 +133
Lines 282275 291976 +9701
Branches 40946 42211 +1265
============================================
+ Hits 201603 209498 +7895
- Misses 63999 65164 +1165
- Partials 16673 17314 +641 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
❕ Gradle check result for a9ae678: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14465-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9675c4f6ec0d412993ef361bce44a8b789bff27b
# Push it to GitHub
git push --set-upstream origin backport/backport-14465-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…slash (opensearch-project#14465) Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 9675c4f)
…slash (opensearch-project#14465) (opensearch-project#14480) Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 9675c4f) Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> (cherry picked from commit a9d806a)
…slash (opensearch-project#14465) Signed-off-by: Thomas Farr <tsfarr@amazon.com>
…slash (opensearch-project#14465) (opensearch-project#14480) Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 9675c4f) Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
…slash (opensearch-project#14465) Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Description
These non-absolute paths (ie. no leading /) are being passed verbatim to the HTTP request which results in a technically invalid request start-line of
GET _render/template HTTP/1.1
which should beGET /_render/template HTTP/1.1
. OpenSearch itself is lenient and happily serves this request, however in cases of stricter intermediaries such as proxies or load-balances as in Amazon OpenSearch Service, this request ends up denied with a 400 Bad Request.Ideally this would be solved globally in
RestClient
(#14423) however this in the minimal easily backportable fix for now.Related Issues
Relates to #14423
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.