Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.15] Correct RHLC searchTemplate & mtermVectors endpoints to have leading slash (#14465) (#14480) #14487

Merged

Conversation

Xtansia
Copy link
Contributor

@Xtansia Xtansia commented Jun 21, 2024

Description

Backport a9d806a from #14465 / #14480

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…slash (opensearch-project#14465) (opensearch-project#14480)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 9675c4f)

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit a9d806a)
@Xtansia Xtansia changed the title Correct RHLC searchTemplate & mtermVectors endpoints to have leading slash (#14465) (#14480) [Backport 2.15] Correct RHLC searchTemplate & mtermVectors endpoints to have leading slash (#14465) (#14480) Jun 21, 2024
Copy link
Contributor

❌ Gradle check result for 8582afc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 21, 2024

@Xtansia I believe 2.15 has sailed away already, we have go / no go call today

Copy link
Contributor

❌ Gradle check result for 8582afc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 8582afc: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.15@61dbcd0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             2.15   #14487   +/-   ##
=======================================
  Coverage        ?   71.43%           
  Complexity      ?    62239           
=======================================
  Files           ?     5094           
  Lines           ?   292444           
  Branches        ?    42626           
=======================================
  Hits            ?   208910           
  Misses          ?    65966           
  Partials        ?    17568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants