Implementing pagination for _cat/indices API #14718

gargharsh3134 · 2024-07-11T05:19:22Z

Description

Changes include:

Introducing new _list/indices API which will display paginated results.
Since, for paginated responses, next_token and what element is getting paginated will also have to be displayed, RestTable and Table classes have been extended to accommodate pagination related metadata
New RestListAction (similar to RestCatAction), to output all _list APIs.
Support of paginationStrategies and PageTokens. Different Pagination Strategies can implement PaginationStragety interface. The interface has been kept very open, considering the strategies can greatly vary in terms of what all parameters they might require to parse a token and generate a list of page from a data store (for e.g. ClusterState is a data store for IndexBasedPaginationStrategy, which has been added as part of this PR).

Functional Testing on a local cluster:

_list API:


gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list"       
:‑|
/_list/indices
/_list/indices/{index}

All the indices in the cluster

gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_cat/indices"                                                                                               
green open test-index  FclPNwqmQie3RnpoOYpLTg 2 3 0 0 1.6kb 416b
green open test-index2 k5FNOQcvSV679Hcs1g-OwQ 2 3 0 0 1.6kb 416b
green open index4-test s2AJ5CoYRru-8lbB871pWA 2 3 0 0 1.6kb 416b

Retrieving indices in pages of size=1, using _list API, in plain text format:

gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1"         
green open index4-test s2AJ5CoYRru-8lbB871pWA 2 3 0 0 1.6kb 416b
next_token MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q=

gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&next_token=MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q="
green open test-index2 k5FNOQcvSV679Hcs1g-OwQ 2 3 0 0 1.6kb 416b
next_token MiQxNzE5NDI3NTM3MzcwJDE3MTk0Mjc1NTYzODEkdGVzdC1pbmRleDI=

gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&next_token=MiQxNzE5NDI3NTM3MzcwJDE3MTk0Mjc1NTYzODEkdGVzdC1pbmRleDI="
green open test-index FclPNwqmQie3RnpoOYpLTg 2 3 0 0 1.6kb 416b
next_token null

Retrieving indices in pages of size=1, using _list API, in JSON format:

gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&format=json&pretty"                                                 
{
  "next_token" : "MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q=",
  "indices" : [
    {
      "health" : "green",
      "status" : "open",
      "index" : "index4-test",
      "uuid" : "s2AJ5CoYRru-8lbB871pWA",
      "pri" : "2",
      "rep" : "3",
      "docs.count" : "0",
      "docs.deleted" : "0",
      "store.size" : "1.6kb",
      "pri.store.size" : "416b"
    }
  ]
}
gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&format=json&pretty&next_token=MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q="
{
  "next_token" : "MiQxNzE5NDI3NTM3MzcwJDE3MTk0Mjc1NTYzODEkdGVzdC1pbmRleDI=",
  "indices" : [
    {
      "health" : "green",
      "status" : "open",
      "index" : "test-index2",
      "uuid" : "k5FNOQcvSV679Hcs1g-OwQ",
      "pri" : "2",
      "rep" : "3",
      "docs.count" : "0",
      "docs.deleted" : "0",
      "store.size" : "1.6kb",
      "pri.store.size" : "416b"
    }
  ]
}
gkharsh@bcd07443f159 OpenSearch % curl "localhost:9200/_list/indices?size=1&format=json&pretty&next_token=MiQxNzE5NDI3NTM3MzcwJDE3MTk0Mjc1NTYzODEkdGVzdC1pbmRleDI="
{
  "next_token" : null,
  "indices" : [
    {
      "health" : "green",
      "status" : "open",
      "index" : "test-index",
      "uuid" : "FclPNwqmQie3RnpoOYpLTg",
      "pri" : "2",
      "rep" : "3",
      "docs.count" : "0",
      "docs.deleted" : "0",
      "store.size" : "1.6kb",
      "pri.store.size" : "416b"
    }
  ]
}

Related Issues

Resolves #14258

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-07-11T06:09:26Z

❌ Gradle check result for 4924a71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

github-actions · 2024-08-05T07:48:49Z

❌ Gradle check result for 0cfb0e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/rest/action/cat/RestIndicesAction.java

server/src/main/java/org/opensearch/rest/pagination/PaginationStrategy.java

server/src/main/java/org/opensearch/rest/action/cat/RestIndicesAction.java

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

github-actions · 2024-08-29T11:29:36Z

❌ Gradle check result for d665722: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dblock · 2024-08-29T11:35:09Z

This looks like a great start.

I would consider (don't feel strongly about it though) wrapping additional metadata into metadata to support other fields like total count.

{
  "metadata": {
      "next_token" : "MSQxNzE5NDI3NDk3NDQ0JDE3MTk0Mjc1NTYzODEkaW5kZXg0LXRlc3Q=",
      "total_count": 200
   },
  "indices" : [
    {
      "health" : "green",
      "status" : "open",
      "index" : "index4-test",
      "uuid" : "s2AJ5CoYRru-8lbB871pWA",
      "pri" : "2",
      "rep" : "3",
      "docs.count" : "0",
      "docs.deleted" : "0",
      "store.size" : "1.6kb",
      "pri.store.size" : "416b"
    }
  ]
}

From the implementation POV, can we build RestIndicesListAction to be a lot thinner where all pagination parts are generic except data fetching? I think a goal should be that to opt into _list/* one adds a ListAction interface to some existing classes and fills out the parts that actually fetch a page of data given a token and that's it. Otherwise it's too easy to accidentally start returning a different object from a non-paginated API vs. a paginated API, which I think is a red flag.

dblock · 2024-08-29T11:39:36Z

server/src/main/java/org/opensearch/rest/action/list/RestIndicesListAction.java

+ final boolean includeUnloadedSegments = request.paramAsBoolean("include_unloaded_segments", false);
+ final String requestedToken = request.param("next_token");
+ final int pageSize = Integer.parseInt(request.param("size", DEFAULT_LIST_INDICES_PAGE_SIZE_STRING));
+ final String requestedSortOrder = request.param("sort", "ascending");


This is the part that I think should be thinned out. Instead of receiving a RestRequest it should be a PaginatedRestRequest where a bunch of parameters that are not list index specific (token, etc.) were parsed outside of RestIndicesListAction.

Thanks @dblock for the feedback. Makes sense to declutter this and also avoid duplication of code. Let me think through a bit more on, if and how can this be achieved.

Have moved things to a common place now. RestIndicesList action is now directly extending RestIndicesAction and all the existing parameters are hence only getting parsed at one place. While, the pagination related params can be parsed individually by the list/paginated APIs.

server/src/main/java/org/opensearch/rest/action/list/RestIndicesListAction.java

rajiv-kv · 2024-09-02T07:57:16Z

server/src/main/java/org/opensearch/rest/action/list/RestIndicesListAction.java

+ // Fetch all the indices from clusterStateRequest for a paginated query.
+ RestIndicesAction.RestIndicesActionCommonUtils.sendClusterStateRequest(
+ indices,
+ IndicesOptions.lenientExpandHidden(),


this one should be from the request as the cluster-state will be source of truth to resolve the user expression.

rajiv-kv · 2024-09-02T08:03:45Z

server/src/main/java/org/opensearch/rest/action/list/RestIndicesListAction.java

+
+ @Override
+ public RestChannelConsumer doListRequest(final RestRequest request, final NodeClient client) {
+ final String[] indices = Strings.splitStringByCommaToArray(request.param("index"));


i think the request parameters should be common for cat and list indices and should be parsed in a single place. The only additional request parameter the list action should parse is paginatedToken.

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

github-actions · 2024-09-03T05:15:25Z

❌ Gradle check result for 2bc80f0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

gargharsh3134 · 2024-09-03T11:40:37Z

server/src/main/java/org/opensearch/rest/action/list/RestIndicesListAction.java

+ */
+public class RestIndicesListAction extends RestIndicesAction {
+
+ protected static final int MAX_SUPPORTED_LIST_INDICES_PAGE_SIZE_STRING = 1000;


Added this as a placeholder for now. Need to decide on whether should we impose such limits, and if yes, what should be the values.

we can test to see what should be reasonable default in terms of latency,

server/src/main/java/org/opensearch/rest/action/cat/AbstractCatAction.java

server/src/main/java/org/opensearch/rest/action/cat/RestIndicesAction.java

rajiv-kv · 2024-09-03T11:40:52Z

server/src/main/java/org/opensearch/rest/action/cat/RestIndicesAction.java

+ indicesToBeQueried,
+ paginationMetadata
+ );
+ groupedListener.onResponse(clusterStateResponse);



the comment below needs an update

The thing is GetSettings call will require indicesOptions from the request itself. Other calls aren't resolving the wildcards in a way GetSettings call does. The existing tests start to fail when GetSettings call is made with lenient indicesOptions. Need to check on how to call this behaviour out now

server/src/main/java/org/opensearch/common/Table.java

server/src/main/java/org/opensearch/rest/action/cat/AbstractCatAction.java

server/src/main/java/org/opensearch/rest/action/list/RestIndicesListAction.java

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

…oken interface Signed-off-by: Harsh Garg <gkharsh@amazon.com>

github-actions · 2024-09-04T01:48:18Z

❌ Gradle check result for f1b5016: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

rajiv-kv · 2024-09-06T08:22:15Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ private final PaginatedQueryResponse paginatedQueryResponse;
+ private final List<String> indicesFromRequestedToken;
+
+ public IndexBasedPaginationStrategy(PaginatedQueryRequest paginatedQueryRequest, String paginatedElement, ClusterState clusterState) {


Constructor seems to have the core implementation of retrieving the page data. Should we move to a seperate init(clusterState) method and have construtor for only extracting paginatedQueryRequest and setting up member variables.

Simplified the logic and moved out the implementation to private methods. Please see if the concern is now addressed.

It might be good to define a static method retriveIndexPageFromClusterState (clusterState, lastRetrievedPage): IndexPage given that constructor is processing the core logic

paginatedElement can be a static constant and need not be passed by caller

Updated in the revision.

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

rajiv-kv · 2024-09-06T14:22:40Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+
+ public String generateEncryptedToken() {
+ return PaginationStrategy.encryptStringToken(
+ posToStartPage + "$" + creationTimeOfLastRespondedIndex + "$" + queryStartTime + "$" + nameOfLastRespondedIndex


could the nameOfLastRespondedIndex contain the seperator $ ?

can we define constants to map the position of token to fields ?

could the nameOfLastRespondedIndex contain the seperator $ ?

Yeah, sorry this was one of the open point. "$" is an allowed index name, and was kept as a placeholder.

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

github-actions · 2024-09-11T05:25:48Z

❌ Gradle check result for 0621975: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

rajiv-kv · 2024-09-11T11:37:29Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ sortedIndicesList.size()
+ );
+ return new PaginatedQueryResponse(
+ positionToStartNextPage >= sortedIndicesList.size()


is this check required given that you are performing min above ?

Revised implementation has a slightly different logic, please check.

rajiv-kv · 2024-09-13T13:16:36Z

server/src/main/java/org/opensearch/rest/pagination/PaginatedQueryRequest.java

+ private final String sort;
+ private final int size;
+
+ public PaginatedQueryRequest(String requested_token, String sort, int size) {


nit: underscore in variable name.

rajiv-kv · 2024-09-13T13:19:03Z

server/src/main/java/org/opensearch/rest/pagination/PaginationStrategy.java

+ */
+public interface PaginationStrategy<T> {
+
+ String DESCENDING_SORT_PARAM_VALUE = "descending";


Should ascending and descending be enum constants ?

I think just a static string should be sufficient. While defining the specs, we can call this out as an ENUM and provide the values inside specs itself. Please let me know if it looks incorrect.

rajiv-kv · 2024-09-13T13:23:48Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ private final PaginatedQueryResponse paginatedQueryResponse;
+ private final List<String> indicesFromRequestedToken;
+
+ public IndexBasedPaginationStrategy(PaginatedQueryRequest paginatedQueryRequest, String paginatedElement, ClusterState clusterState) {


It might be good to define a static method retriveIndexPageFromClusterState (clusterState, lastRetrievedPage): IndexPage given that constructor is processing the core logic

paginatedElement can be a static constant and need not be passed by caller

rajiv-kv · 2024-09-13T14:17:30Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ paginatedQueryRequest.getSort()
+ );
+ this.indicesFromRequestedToken = getIndicesFromRequestedToken(sortedIndicesList, paginatedQueryRequest);
+ this.paginatedQueryResponse = getPaginatedResponseFromRequestedToken(sortedIndicesList, paginatedQueryRequest, paginatedElement);


Is it not the case that indicesFromRequestedToken is the data corresponding to the page. Why are we passing sortedIndicesList again to getPaginatedResponseFromRequestedToken ?

Please check the new logic to get the paginated response object and let me know if it's still a concern.

rajiv-kv · 2024-09-13T14:32:46Z

server/src/main/java/org/opensearch/rest/pagination/PaginationStrategy.java

+ * Utility method to get list of indices sorted by their creation time.
+ */
+ static List<IndexMetadata> getListOfIndicesSortedByCreateTime(final ClusterState clusterState, String sortOrder) {
+ return clusterState.metadata().indices().values().stream().sorted((metadata1, metadata2) -> {


Can we define two comparatorFn -> asc and desc and use it based on DESCENDING_SORT_PARAM_VALUE. This is to avoid branching inside the comparatorFn.

I have defined a new comparator, but still kept only a single method. Since it's just one comparison that changes, thought it's better to avoid code duplication. But still open to defining two separate methods, if you feel that would bring out more clarity

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

rajiv-kv · 2024-09-13T14:43:14Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ if (!Objects.equals(currentIndexAtLastSentPosition.getIndex().getName(), requestedToken.nameOfLastRespondedIndex)) {
+ // case denoting already responded index/indices has/have been deleted/added in between the paginated queries.
+ // find the index whose creation time is just after/before (based on sortOrder) the index which was last responded.
+ if (!DESCENDING_SORT_PARAM_VALUE.equals(paginatedQueryRequest.getSort())) {


Lets define two different nextPageFn based on sort order. We can link them with sort enum

Have defined a new predicate for filtering and comparator for sorting, please check again.

rajiv-kv · 2024-09-13T14:50:09Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ while (requestedPageStartIndexNumber > 0
+ && (sortedIndicesList.get(requestedPageStartIndexNumber - 1)
+ .getCreationDate() > requestedToken.creationTimeOfLastRespondedIndex)) {
+ requestedPageStartIndexNumber--;
+ }


Is it guranteed that the prevPage returned had all the elements less than (or) equal to creationTimeOfLastRespondedIndex ? Can we add it to comment and relevant method in comment.

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

github-actions · 2024-09-19T05:24:06Z

❌ Gradle check result for 3bedc82: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

shwetathareja · 2024-09-04T18:26:42Z

server/src/main/java/org/opensearch/rest/action/cat/AbstractCatAction.java

@@ -57,9 +59,11 @@
 */
 public abstract class AbstractCatAction extends BaseRestHandler {


why do we want to change AbstractCatAction at all? we can keep the changes in AbstractListAction?

Added AbstractListAction which is now extending AbstractCatAction as discussed, please see if it resolves the concern now.

shwetathareja · 2024-09-04T18:32:38Z

server/src/main/java/org/opensearch/rest/action/list/RestIndicesListAction.java

+ if (!Objects.equals(paginatedQueryRequest.getSort(), "ascending")
+ && !Objects.equals(paginatedQueryRequest.getSort(), "descending")) {


just use asc or desc and also use constants instead of hard coded values

Updated in the revision.

shwetathareja · 2024-09-04T18:35:53Z

server/src/main/java/org/opensearch/rest/pagination/PaginatedQueryRequest.java

+ return sort;
+ }
+
+ public String getRequestedTokenStr() {


getRequestedToken remove Str

Updated in the revision.

shwetathareja · 2024-09-04T18:36:36Z

server/src/main/java/org/opensearch/rest/pagination/PaginatedQueryRequest.java

+ * Class specific to paginated queries, which will contain common query params required by a paginated API.
+ */
+@PublicApi(since = "2.17.0")
+public class PaginatedQueryRequest {


Just PaginatedRequestParams

Renamed to PageParams as discussed.

shwetathareja · 2024-09-19T09:40:00Z

server/src/main/java/org/opensearch/rest/action/cat/AbstractCatAction.java

+ * @return boolean denoting whether the RestAction will output paginated responses or not.
+ * Is kept false by default, every paginated action to override and return true.
+ */
+ public boolean isActionPaginated() {


would it make sense to add AbstractListAction instead of adding in AbstractCatAction as list are separate APIs anyway.

Updated in the revision.

shwetathareja · 2024-09-19T10:16:45Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ this.paginatedQueryResponse = getPaginatedResponseForRequestedToken(paginatedQueryRequest.getSize(), sortedIndicesList);
+ }
+
+ private static Predicate<IndexMetadata> getMetadataListFilter(String requestedTokenStr, String sortOrder) {


getIndicesFilter

Updated in the revision.

shwetathareja · 2024-09-19T10:20:33Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ return indexMetadata -> {
+ if (indexMetadata.getIndex().getName().equals(requestedToken.nameOfLastRespondedIndex)) {
+ return false;
+ } else if (indexMetadata.getCreationDate() == requestedToken.creationTimeOfLastRespondedIndex) {


creationTimeOfLastRespondedIndex - LastIndexCreationTime
nameOfLastRespondedIndex. - LastIndexName

Updated in the revision.

shwetathareja · 2024-09-19T10:22:06Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ };
+ }
+
+ private static Comparator<IndexMetadata> getMetadataListComparator(String sortOrder) {


getIndexComparator

Updated in the revision.

shwetathareja · 2024-09-19T10:23:19Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ };
+ }
+
+ private List<IndexMetadata> getMetadataListForRequestedToken(


getIndicesForToken

Updated in the revision.

shwetathareja · 2024-09-19T10:24:21Z

server/src/main/java/org/opensearch/rest/pagination/IndexBasedPaginationStrategy.java

+ return sortedIndicesList.subList(0, Math.min(paginatedQueryRequest.getSize(), sortedIndicesList.size()));
+ }
+
+ private PaginatedQueryResponse getPaginatedResponseForRequestedToken(int pageSize, List<IndexMetadata> sortedIndicesList) {


getResponseForToken

this method is not returning actual response?

As discussed, this is just for returning the token. Renamed appropriately.

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

github-actions · 2024-09-20T05:08:55Z

❌ Gradle check result for 8a39c52: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions bot added Cluster Manager enhancement Enhancement or improvement to existing feature or request labels Jul 11, 2024

Implementing pagination for _cat/indices

0cfb0e9

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

gargharsh3134 force-pushed the catIndicesPaginationPR branch from 4924a71 to 0cfb0e9 Compare August 5, 2024 07:18

github-actions bot added the v2.17.0 label Aug 5, 2024

rajiv-kv reviewed Aug 20, 2024

View reviewed changes

Adding RestIndicesListAction along with RestListAction changes

d665722

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

dblock reviewed Aug 29, 2024

View reviewed changes

rajiv-kv reviewed Sep 2, 2024

View reviewed changes

Harsh Garg added 2 commits September 3, 2024 09:12

Combining the doList and doCat methods and adding UTs

60eefd6

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

Merge branch 'main' into catIndicesPaginationPR

2bc80f0

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

gargharsh3134 marked this pull request as ready for review September 3, 2024 03:49

gargharsh3134 requested review from anasalkouz, andrross, ashking94, Bukhtawar, CEHENKLE, dbwiddis, gbbafna, jainankitk, kotwanikunal, linuxpi, mch2, msfroh, nknize and owaiskazi19 as code owners September 3, 2024 03:49

gargharsh3134 requested review from reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami and VachaShah as code owners September 3, 2024 03:49

gargharsh3134 commented Sep 3, 2024

View reviewed changes

rajiv-kv reviewed Sep 3, 2024

View reviewed changes

Added paginated query request and response classes and removed page t…

f1b5016

…oken interface Signed-off-by: Harsh Garg <gkharsh@amazon.com>

rajiv-kv reviewed Sep 6, 2024

View reviewed changes

Removing queryStartTime from IndexStrategyToken

0621975

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

rajiv-kv reviewed Sep 16, 2024

View reviewed changes

Refactoring strategy to simplify generating list of requested indices

3bedc82

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

shwetathareja reviewed Sep 19, 2024

View reviewed changes

Adding AbstractListAction and renaming pagination related classes

9aebdce

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

gargharsh3134 force-pushed the catIndicesPaginationPR branch from 180811d to 9aebdce Compare September 20, 2024 04:22

Merge branch 'main' into catIndicesPaginationPR

8a39c52

Signed-off-by: Harsh Garg <gkharsh@amazon.com>

		@@ -57,9 +59,11 @@
		*/
		public abstract class AbstractCatAction extends BaseRestHandler {

		if (!Objects.equals(paginatedQueryRequest.getSort(), "ascending")
		&& !Objects.equals(paginatedQueryRequest.getSort(), "descending")) {

Implementing pagination for _cat/indices API #14718

Are you sure you want to change the base?

Implementing pagination for _cat/indices API #14718

Conversation

gargharsh3134 commented Jul 11, 2024 • edited Loading

Description

Functional Testing on a local cluster:

Related Issues

Check List

github-actions bot commented Jul 11, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 29, 2024

dblock commented Aug 29, 2024 • edited Loading

dblock Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024

gargharsh3134 commented Jul 11, 2024 •

edited

Loading

dblock commented Aug 29, 2024 •

edited

Loading

dblock Aug 29, 2024 •

edited

Loading