Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isActionPaginated to DelegatingRestHandler #4763

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 1, 2024

Description

This PR fixes a test failure in DelegatingRestHandlerTests after the RestHandler interface was changed in opensearch-project/OpenSearch#14718 to add a new method called isActionPaginated

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.62%. Comparing base (9c5e32a) to head (f9cbbde).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4763      +/-   ##
==========================================
- Coverage   65.63%   65.62%   -0.02%     
==========================================
  Files         321      321              
  Lines       22538    22539       +1     
  Branches     3611     3611              
==========================================
- Hits        14793    14791       -2     
- Misses       5932     5939       +7     
+ Partials     1813     1809       -4     
Files with missing lines Coverage Δ
...nsearch/security/filter/DelegatingRestHandler.java 93.75% <100.00%> (+0.41%) ⬆️

... and 4 files with indirect coverage changes

@cwperks cwperks added the backport 2.x backport to 2.x branch label Oct 1, 2024
@cwperks cwperks merged commit df115d8 into opensearch-project:main Oct 1, 2024
42 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit df115d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants